Skip to contentSkip to conversation

Option to disable filtering of duplicate LE ADV

DISCUSSION Brennan Ashton 4 participants 6 messages Sep 9, 2016 – Sep 12, 2016 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

Right now in all of the le_scan functions filter_dup is set to LE_SCAN_FILTER_DUP_ENABLE.  This is not always desired with beacons as the content may change.  I can force this by sending the HCI commands to enable scanning without this filter, but then the mgmt api (and DBUS) cannot be used for scanning.

I was wondering if people had thoughts on making this configurable?

--Brennan

#1 lore raw

Hi Brennan,

Quoted 7 lines · Brennan Ashton

Right now in all of the le_scan functions filter_dup is set to LE_SCAN_FILTER_DUP_ENABLE. This is not always desired with beacons as the content may change. I can force this by sending the HCI commands to enable scanning without this filter, but then the mgmt api (and DBUS) cannot be used for scanning.

I was wondering if people had thoughts on making this configurable?

Check out the SetDiscoveryFilter:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/adapter-api.txt

When that is used it will not enable duplicated filter and in fact is the only way to discover beacons which don't have discoverable flags sets e.g. broadcaster.

Signature · 1 line
Luiz Augusto von Dentz
#2 lore raw

Hi Luiz,

Quoted 9 lines · Luiz Augusto von Dentz
Quoted 7 lines · Brennan Ashton

Right now in all of the le_scan functions filter_dup is set to LE_SCAN_FILTER_DUP_ENABLE. This is not always desired with beacons as the content may change. I can force this by sending the HCI commands to enable scanning without this filter, but then the mgmt api (and DBUS) cannot be used for scanning.

I was wondering if people had thoughts on making this configurable?

Quoted 7 lines

Check out the SetDiscoveryFilter:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/adapter-api.txt

When that is used it will not enable duplicated filter and in fact is the only way to discover beacons which don't have discoverable flags sets e.g. broadcaster.

Actually Brennan is right that none of these methods disable duplicate filtering. All of the places in the kernel that set the LE scan parameters explicitly enable duplicate filtering. I suppose we should seriously consider extending the mgmt API to allow performing LE scan without the duplicate filtering. Right now the only way to do that is through raw HCI access.

Johan

maintainer
#3 lore raw

Hi Johan,

Quoted 16 lines
Quoted 8 lines
Quoted 7 lines

Right now in all of the le_scan functions filter_dup is set to LE_SCAN_FILTER_DUP_ENABLE. This is not always desired with beacons as the content may change. I can force this by sending the HCI commands to enable scanning without this filter, but then the mgmt api (and DBUS) cannot be used for scanning.

I was wondering if people had thoughts on making this configurable?

Quoted 7 lines

Check out the SetDiscoveryFilter:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/adapter-api.txt

When that is used it will not enable duplicated filter and in fact is the only way to discover beacons which don't have discoverable flags sets e.g. broadcaster.

Quoted 6 lines

Actually Brennan is right that none of these methods disable duplicate filtering. All of the places in the kernel that set the LE scan parameters explicitly enable duplicate filtering. I suppose we should seriously consider extending the mgmt API to allow performing LE scan without the duplicate filtering. Right now the only way to do that is through raw HCI access.

however when a driver sets the strict duplicate filtering quirk, then scanning will be restarted and thus new advertising data can be found.

Regards

Marcel

#4 lore raw

Hi Marcel, Johan,

Quoted 18 lines · Marcel Holtmann

Hi Johan,

Quoted 16 lines
Quoted 15 lines
Quoted 7 lines

Right now in all of the le_scan functions filter_dup is set to LE_SCAN_FILTER_DUP_ENABLE. This is not always desired with beacons as the content may change. I can force this by sending the HCI commands to enable scanning without this filter, but then the mgmt api (and DBUS) cannot be used for scanning.

I was wondering if people had thoughts on making this configurable?

Check out the SetDiscoveryFilter:

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/adapter-api.txt

When that is used it will not enable duplicated filter and in fact is the only way to discover beacons which don't have discoverable flags sets e.g. broadcaster.

Quoted 8 lines
Quoted 6 lines

Actually Brennan is right that none of these methods disable duplicate filtering. All of the places in the kernel that set the LE scan parameters explicitly enable duplicate filtering. I suppose we should seriously consider extending the mgmt API to allow performing LE scan without the duplicate filtering. Right now the only way to do that is through raw HCI access.

however when a driver sets the strict duplicate filtering quirk, then scanning will be restarted and thus new advertising data can be found.

Im not sure what the quirk actually means but it doesn't look like it will be able to attend the RSSI filtering since the controller may omit results thus why I though duplicate was not enabled when filtering is. From the code it looks like the quirk would force restarting the scanning:

/* If duplicate filtering does not report RSSI changes, then restart
* scanning to ensure updated result with updated RSSI values. */
if (test_bit(HCI_QUIRK_STRICT_DUPLICATE_FILTER, &hdev->quirks)) { restart_le_scan(hdev);

Isn't that a causing a little too many restarts? I wonder if there is anyone using this quirk in practice? And is this really worth it instead of just disabling the duplicate filter?

Signature · 1 line
Luiz Augusto von Dentz
#5 lore raw
Quoted 61 lines · Luiz Augusto von Dentz

Hi Marcel, Johan,

On Mon, Sep 12, 2016 at 9:47 AM, Marcel Holtmann <[email protected]

Quoted 42 lines

wrote:

Hi Johan,

Quoted 27 lines
Quoted 18 lines
Quoted 13 lines

Right now in all of the le_scan functions filter_dup is set to
LE_SCAN_FILTER_DUP_ENABLE.  This is not always desired with beacons as
the content may change.  I can force this by sending the HCI commands
to enable scanning without this filter, but then the mgmt api (and
DBUS) cannot be used for scanning.

Quoted 2 lines

I was wondering if people had thoughts on making this configurable?

Check out the SetDiscoveryFilter:

Quoted 8 lines

https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/adapte
r-api.txt

When that is used it will not enable duplicated filter and in fact is
the only way to discover beacons which don't have discoverable flags
sets e.g. broadcaster.

Quoted 10 lines

Actually Brennan is right that none of these methods disable duplicate
filtering. All of the places in the kernel that set the LE scan parameters explicitly enable duplicate filtering. I suppose we should
seriously consider extending the mgmt API to allow performing LE scan
without the duplicate filtering. Right now the only way to do that is
through raw HCI access.

Quoted 3 lines

however when a driver sets the strict duplicate filtering quirk, then scanning will be restarted and thus new advertising data can be found.

Im not sure what the quirk actually means but it doesn't look like it will be able to attend the RSSI filtering since the controller may omit results thus why I though duplicate was not enabled when filtering is. From the code it looks like the quirk would force restarting the scanning:

/* If duplicate filtering does not report RSSI changes, then restart
* scanning to ensure updated result with updated RSSI values. */
if (test_bit(HCI_QUIRK_STRICT_DUPLICATE_FILTER, &hdev->quirks)) { restart_le_scan(hdev);

Quoted 4 lines

Isn't that a causing a little too many restarts? I wonder if there is anyone using this quirk in practice? And is this really worth it instead of just disabling the duplicate filter?

I am not sure I fully understand what this quirk, but I suspect we are going to want to have the option for turning on duplicate filtering. Beacons and mesh are going to become more and more common and the later would cause an HCI event every time a new packet was broadcast. In most cases these are not of interest to people unless they are explicity expecting them.

I would propose adding SetSuplicateFilter to the adaptor API. I am happy to write some code for this today if people think this makes sense.

--Brennan