Revert "net: asix: Fix AX88772B when used with DriverModel"
PATCH 1/1 Revert "net: asix: Fix AX88772B when used with DriverModel"
As discussed before rather than Joshua's patch the one from Alban should long since have been applied:
https://www.mail-archive.com/u-boot at lists.denx.de/msg221455.html
This reverts commit 41d1258aceb45b45f9e68f67a9c40f0afbc09dc9.
---
drivers/usb/eth/asix.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/usb/eth/asix.c +0 -5
@@ -819,11 +819,6 @@ int asix_eth_recv(struct udevice *dev, int flags, uchar **packetp) } *packetp = ptr +sizeof (packet_len); - -if ((ueth->pusb_dev->descriptor.idVendor ==ASIX_USB_VENDOR_ID ) && - (ueth->pusb_dev->descriptor.idProduct ==AX88772B_USB_PRODUCT_ID )) - *packetp +=2 ; -return packet_len; err:
Signature · 1 line
2.5.5
PATCH 1/1 Revert "net: asix: Fix AX88772B when used with DriverModel"
Hi Marcel,
Quoted 8 lines · Marcel Ziswiler
As discussed before rather than Joshua's patch the one from Alban should long since have been applied:
https://www.mail-archive.com/u-boot at lists.denx.de/msg221455.html
This reverts commit
41d1258aceb45b45f9e68f67a9c40f0afbc09dc9.Signed-off-by Marcel Ziswiler <[email protected]>
I had not seen the other patch to know the reason behind the 2 bytes. It was never assigned to me, it was assigned to Marek - He has it marked as superseded in PW: https://patchwork.ozlabs.org/patch/655265/
He says that the patch from Alban does not build, but I don't see a follow-up.
Sorry about that.
-Joe
PATCH 1/1 Revert "net: asix: Fix AX88772B when used with DriverModel"
Quoted 10 lines · Joe Hershberger
Hi Marcel,
Quoted 6 lines · Marcel Ziswiler
As discussed before rather than Joshua's patch the one from Alban should long since have been applied:
https://www.mail-archive.com/u-boot at lists.denx.de/msg221455.html
Quoted 7 lines
Quoted 3 lines
This reverts commit
41d1258aceb45b45f9e68f67a9c40f0afbc09dc9.Signed-off-by Marcel Ziswiler <[email protected]>I had not seen the other patch to know the reason behind the 2 bytes. It was never assigned to me, it was assigned to Marek - He has it marked as superseded in PW: https://patchwork.ozlabs.org/patch/655265
/
Sure, I also have not noticed Joshua's which got in way quick.
Quoted 2 lines
He says that the patch from Alban does not build, but I don't see a follow-up.
Hm, it builds and runs fine for my two boards the Colibri T20 and Colibri T30 both using one of them?AX88772B chips each.
@Marek: May I ask what exactly about Alban's patch does not build for you?
Quoted 1 line
Sorry about that.
No problem. We will figure it out.
Thanks, Joe
PATCH 1/1 Revert "net: asix: Fix AX88772B when used with DriverModel"
Quoted 21 lines · Marcel Ziswiler
Quoted 10 lines · Joe Hershberger
Hi Marcel,
Quoted 6 lines · Marcel Ziswiler
As discussed before rather than Joshua's patch the one from Alban should long since have been applied:
https://www.mail-archive.com/u-boot at lists.denx.de/msg221455.html
Quoted 7 lines
Quoted 3 lines
This reverts commit
41d1258aceb45b45f9e68f67a9c40f0afbc09dc9.Signed-off-by Marcel Ziswiler <[email protected]>I had not seen the other patch to know the reason behind the 2 bytes. It was never assigned to me, it was assigned to Marek - He has it marked as superseded in PW: https://patchwork.ozlabs.org/patch/655265
/Sure, I also have not noticed Joshua's which got in way quick.
Quoted 8 lines
Quoted 2 lines
He says that the patch from Alban does not build, but I don't see a follow-up.
Hm, it builds and runs fine for my two boards the Colibri T20 and Colibri T30 both using one of them AX88772B chips each.
@Marek: May I ask what exactly about Alban's patch does not build for you?
I don't know anymore, sorry. It most likely failed buildman run of the u-boot-usb tree during some PR, so I removed the patch from the PR.
Quoted 6 lines
Quoted 1 line
Sorry about that.
No problem. We will figure it out.
Thanks, Joe
Signature · 2 lines
Best regards, Marek Vasut