extcon: Introduce EXTCON_PROP_DISP_HPD property
PATCH 1/1 extcon: Introduce EXTCON_PROP_DISP_HPD property
EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd interrupt, this property can be used.
--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
include/linux/extcon.h +13 -1
@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) +/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD +* @type: integer (intval) +* @value: 0 (no hpd) or 1 (hpd) +* @default: 0 (no hpd) +* +*/ + +#define EXTCON_PROP_DISP_HPD 150 +/* Properties of EXTCON_TYPE_DISP. */ #define EXTCON_PROP_DISP_MIN 150 -#define EXTCON_PROP_DISP_MAX 150 +#define EXTCON_PROP_DISP_MAX 151#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1)/*
Signature · 1 line
1.9.1
Quoted 4 lines · Chris Zhong
EXTCON_PROP_DISP_HPDis need by display port, if the system has no hpd interrupt, this property can be used.Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed
Drop Change-ID: for upstream submissions.
Quoted 1 line
Signed-off-by Chris Zhong <[email protected]>
Otherwise, yes, looks like this is needed.
Quoted 32 lines
--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)include/linux/extcon.h +13
-1@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) +/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD +* @type: integer (intval) +* @value: 0 (no hpd) or 1 (hpd) +* @default: 0 (no hpd) +* +*/ + +#define EXTCON_PROP_DISP_HPD 150 +/* Properties of EXTCON_TYPE_DISP. */ #define EXTCON_PROP_DISP_MIN 150 -#define EXTCON_PROP_DISP_MAX 150 +#define EXTCON_PROP_DISP_MAX 151#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1)/*
Chanwoo Choi
maintainerHi Chris,
Quoted 2 lines · Chris Zhong
EXTCON_PROP_DISP_HPDis need by display port, if the system has no hpd interrupt, this property can be used.
What is meaning of HPD? So, you need to add the description and reference for HPD in commit message.
For example,
When adding EXTCON_PROP_USB_SS property[1],
the commit message included the reference for USB SuperSpeed.
[1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610
Quoted 2 lines
Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed
You have to remove the 'Change-Id'.
Quoted 10 lines
Signed-off-by Chris Zhong <[email protected]>--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)include/linux/extcon.h +0
-0
include/linux/extcon.h line 137
Quoted 7 lines
include/linux/extcon.h +4
-0@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1) +/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD
You should add the full name of 'HPD'.
Quoted 16 lines
include/linux/extcon.h +9
-1+* @type: integer (intval) +* @value: 0 (no hpd) or 1 (hpd) +* @default: 0 (no hpd) +* +*/ + +#define EXTCON_PROP_DISP_HPD 150 +/* Properties of EXTCON_TYPE_DISP. */ #define EXTCON_PROP_DISP_MIN 150 -#define EXTCON_PROP_DISP_MAX 150 +#define EXTCON_PROP_DISP_MAX 151#define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1)/*
Signature · 2 lines
Best Regards, Chanwoo Choi
Chanwoo Choi
maintainerHi Chris,
Quoted 32 lines · Chanwoo Choi
Hi Chris,
Quoted 2 lines · Chris Zhong
EXTCON_PROP_DISP_HPDis need by display port, if the system has no hpd interrupt, this property can be used.What is meaning of HPD? So, you need to add the description and reference for HPD in commit message.
For example,
When addingEXTCON_PROP_USB_SSproperty[1],
the commit message included the reference for USB SuperSpeed.
[1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610Quoted 2 lines
Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed
You have to remove the 'Change-Id'.
Quoted 13 lines
Signed-off-by Chris Zhong <[email protected]>--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)include/linux/extcon.h +0
-0@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1)
Quoted 6 lines
include/linux/extcon.h line 137
Quoted 4 lines
include/linux/extcon.h +4
-0+/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD You should add the full name of 'HPD'.
On previous mail, I replied ambiguous comment.
I mean that you better to add the property name with full name as following:
EXTCON_PROP_DISP_HPD ( Hxxx Pxxx Dxxx)
[snip]
Signature · 2 lines
Best Regards, Chanwoo Choi
Quoted 42 lines · Chanwoo Choi
Hi Chris,
Quoted 32 lines · Chanwoo Choi
Hi Chris,
Quoted 2 lines · Chris Zhong
EXTCON_PROP_DISP_HPDis need by display port, if the system has no hpd interrupt, this property can be used.What is meaning of HPD? So, you need to add the description and reference for HPD in commit message.
For example,
When addingEXTCON_PROP_USB_SSproperty[1],
the commit message included the reference for USB SuperSpeed.
[1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610Quoted 2 lines
Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed
You have to remove the 'Change-Id'.
Quoted 13 lines
Signed-off-by Chris Zhong <[email protected]>--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)include/linux/extcon.h +0
-0@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1)Quoted 6 lines
include/linux/extcon.h line 137
Quoted 4 lines
include/linux/extcon.h +4
-0+/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD You should add the full name of 'HPD'.
Quoted 5 lines
On previous mail, I replied ambiguous comment.
I mean that you better to add the property name with full name as following:
EXTCON_PROP_DISP_HPD( Hxxx Pxxx Dxxx)
What do you prefer ?
HOTPLUGDETECT ? HOT_PLUG_DETECT ? HOTPLUG_DETECT ?
The term "HPD" seems to be quite common in the DisplayPort world; in most presentations it isn't even explained. Personally I would prefer to stick with HPD and explain it in the comments.
Guenter
Quoted 6 lines
[snip]
--
Best Regards,
Chanwoo Choi
Chanwoo Choi
maintainerHi Guenter,
Quoted 45 lines · Guenter Roeck
Quoted 44 lines · Chanwoo Choi
Hi Chris,
Quoted 32 lines · Chanwoo Choi
Hi Chris,
Quoted 2 lines · Chris Zhong
EXTCON_PROP_DISP_HPDis need by display port, if the system has no hpd interrupt, this property can be used.What is meaning of HPD? So, you need to add the description and reference for HPD in commit message.
For example,
When addingEXTCON_PROP_USB_SSproperty[1],
the commit message included the reference for USB SuperSpeed.
[1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=8457a1b49a2af0a0e71f80afed9f7c80de361610Quoted 2 lines
Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed
You have to remove the 'Change-Id'.
Quoted 13 lines
Signed-off-by Chris Zhong <[email protected]>--- include/linux/extcon.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)include/linux/extcon.h +0
-0@@ -131,9 +131,21 @@#define EXTCON_PROP_JACK_MAX 100#define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1)Quoted 6 lines
include/linux/extcon.h line 137
Quoted 4 lines
include/linux/extcon.h +4
-0+/* +* Properties of EXTCON_TYPE_DISP. +* +* - EXTCON_PROP_DISP_HPD You should add the full name of 'HPD'.
On previous mail, I replied ambiguous comment.
Quoted 7 lines
Quoted 3 lines
I mean that you better to add the property name with full name as following:
EXTCON_PROP_DISP_HPD( Hxxx Pxxx Dxxx)What do you prefer ?
HOTPLUGDETECT ?
HOT_PLUG_DETECT?HOTPLUG_DETECT?
I prefer to add 'HPD (Hot Plug Detect)'.
Quoted 4 lines
The term "HPD" seems to be quite common in the DisplayPort world; in most presentations it isn't even explained. Personally I would prefer to stick with HPD and explain it in the comments.
People who are unfamiliar with DisplayPort world need the explanation and full name of HPD. Basically, all abbreviation should show the full name.
Signature · 2 lines
Best Regards, Chanwoo Choi