Skip to contentSkip to conversation

xpp[23]: fix/remove bashism

PATCH In review Sujith H 2 participants 3 messages Sep 12, 2016

lore
Share & tools
lore

Sujith H

author
#0 lore raw

PATCH 1/1 xpp[23]: fix/remove bashism

From: Christopher Larson <[email protected]>

This was breaking on hosts with dash as /bin/sh.

Signed-off-by Christopher Larson <[email protected]>
---
 recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
 recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-core/xml-commons/xpp2_2.1.10.bb +1 -1
index d3baca4..c926722 100644
@@ -19,7 +19,7 @@ do_compile() {
 
     sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:src/java/impl/factory:src/java/impl/format:src/java/impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"
 
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
recipes-core/xml-commons/xpp3_1.1.3.4.O.bb +1 -1
index bedb8a9..f264022 100644
@@ -19,7 +19,7 @@ do_compile() {
     mkdir -p build-oe
 
     sourcepath="src/java/api:src/java/builder:src/java/dom2_builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/parser_pool:src/java/sax2_driver:src/java/serializer_impl:src/java/util:src/java/wrapper"
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name "*.java"`
Signature · 1 line
1.9.1
author
#1 lore raw

Hi,

Hope the patch looks ok. Else do let me know I can work on the same.

Thanks,
Sujith H

Quoted 49 lines · Sujith H

From: Christopher Larson <[email protected]>

This was breaking on hosts with dash as /bin/sh.

Signed-off-by Christopher Larson <[email protected]>
---
 recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
 recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-core/xml-commons/xpp2_2.1.10.bb +0 -0
index d3baca4..c926722 100644
@@ -19,7 +19,7 @@ do_compile() {
 
     sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:

src/java/impl/factory:src/java/impl/format:src/java/ impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"

recipes-core/xml-commons/xpp2_2.1.10.bb +1 -1
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name

"*.java"`

recipes-core/xml-commons/xpp3_1.1.3.4.O.bb +0 -0
index bedb8a9..f264022 100644
@@ -19,7 +19,7 @@ do_compile() {
     mkdir -p build-oe
 
     sourcepath="src/java/api:src/java/builder:src/java/dom2_

builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/ parser_pool:src/java/sax2_driver:src/java/serializer_ impl:src/java/util:src/java/wrapper"

recipes-core/xml-commons/xpp3_1.1.3.4.O.bb +1 -1
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name

"*.java"`

--
1.9.1

Signature · 7 lines
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
#2 lore raw

Hi Sujith,

Quoted 3 lines · sujith h

Hi,

Hope the patch looks ok. Else do let me know I can work on the same.

Yes, it looks good. Pushed to master.

Quoted 2 lines

Thanks,
Sujith H

Best Regards,
Maxin

Quoted 66 lines · Sujith H
Quoted 50 lines

From: Christopher Larson <[email protected]>

This was breaking on hosts with dash as /bin/sh.

Signed-off-by Christopher Larson <[email protected]>
---
 recipes-core/xml-commons/xpp2_2.1.10.bb    | 2 +-
 recipes-core/xml-commons/xpp3_1.1.3.4.O.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-core/xml-commons/xpp2_2.1.10.bb +0 -0
index d3baca4..c926722 100644
@@ -19,7 +19,7 @@ do_compile() {
 
     sourcepath="src/java/drivers/jaxp11:src/java/drivers/sax2:

src/java/impl/factory:src/java/impl/format:src/java/ impl/node:src/java/impl/pullparser:src/java/impl/tag:src/java/intf"

recipes-core/xml-commons/xpp2_2.1.10.bb +1 -1
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name

"*.java"`

recipes-core/xml-commons/xpp3_1.1.3.4.O.bb +0 -0
index bedb8a9..f264022 100644
@@ -19,7 +19,7 @@ do_compile() {
     mkdir -p build-oe
 
     sourcepath="src/java/api:src/java/builder:src/java/dom2_

builder:src/java/mxp1_min:src/java/mxp1_standard:src/java/ parser_pool:src/java/sax2_driver:src/java/serializer_ impl:src/java/util:src/java/wrapper"

recipes-core/xml-commons/xpp3_1.1.3.4.O.bb +1 -1
-    findpath="${sourcepath//:/ }"
+    findpath="$(echo "$sourcepath" | tr : " ")"
 
     javac -sourcepath $sourcepath -d build-oe `find $findpath -name

"*.java"`

--
1.9.1

Signature · 12 lines
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c
-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel