Patch "vhost/scsi: fix reuse of &vq->iov[out] in response" has been added to the 4.7-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
vhost/scsi: fix reuse of &vq->iov[out] in response
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
vhost-scsi-fix-reuse-of-vq-iov-in-response.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
a77ec83a57890240c546df00ca5df1cdeedb1cc3Mon Sep 17 00:00:00 2001
From: Benjamin Coddington <[email protected]>
Date: Mon, 6 Jun 2016 18:07:59 -0400
Subject: vhost/scsi: fix reuse of &vq->iov[out] in response
From: Benjamin Coddington <[email protected]>
commit a77ec83a57890240c546df00ca5df1cdeedb1cc3 upstream.
The address of the iovec &vq->iov[out] is not guaranteed to contain the scsi command's response iovec throughout the lifetime of the command. Rather, it is more likely to contain an iovec from an immediately following command after looping back around to vhost_get_vq_desc(). Pass along the iovec entirely instead.
--- drivers/vhost/scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/vhost/scsi.c +3 -3
@@ -88,7 +88,7 @@ struct vhost_scsi_cmd {struct scatterlist *tvc_prot_sgl;struct page **tvc_upages;/* Pointer to response header iovec */ -struct iovec *tvc_resp_iov; +struct iovec tvc_resp_iov;/* Pointer to vhost_scsi for our device */ struct vhost_scsi *tvc_vhost;/* Pointer to vhost_virtqueue for the cmd */
@@ -547,7 +547,7 @@ static void vhost_scsi_complete_cmd_workmemcpy (v_rsp.sense, cmd->tvc_sense_buf, se_cmd->scsi_sense_length); -iov_iter_init (&iov_iter,READ , cmd->tvc_resp_iov, +iov_iter_init (&iov_iter,READ , &cmd->tvc_resp_iov, cmd->tvc_in_iovs,sizeof (v_rsp)); ret =copy_to_iter (&v_rsp,sizeof (v_rsp), &iov_iter);if (likely (ret ==sizeof (v_rsp))) {
@@ -1044,7 +1044,7 @@ vhost_scsi_handle_vq(struct vhost_scsi * } cmd->tvc_vhost = vs; cmd->tvc_vq = vq; - cmd->tvc_resp_iov = &vq->iov[out]; + cmd->tvc_resp_iov = vq->iov[out]; cmd->tvc_in_iovs = in; pr_debug("vhost_scsi got command opcode: %#02x, lun: %d\n",
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/vhost-scsi-fix-reuse-of-vq-iov-in-response.patch