Patch "ovl: remove posix_acl_default from workdir" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ovl: remove posix_acl_default from workdir
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ovl-remove-posix_acl_default-from-workdir.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
c11b9fdd6a612f376a5e886505f1c54c16d8c380Mon Sep 17 00:00:00 2001
From: Miklos Szeredi <[email protected]>
Date: Thu, 1 Sep 2016 11:11:59 +0200
Subject: ovl: remove posix_acl_default from workdir
From: Miklos Szeredi <[email protected]>
commit c11b9fdd6a612f376a5e886505f1c54c16d8c380 upstream.
Clear out posix acl xattrs on workdir and also reset the mode after creation so that an inherited sgid bit is cleared.
--- fs/overlayfs/super.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
fs/overlayfs/super.c +19 -0
@@ -763,6 +763,10 @@ retry:struct kstat stat = { .mode =S_IFDIR |0 , }; +struct iattr attr = { + .ia_valid =ATTR_MODE , + .ia_mode = stat.mode, + };if (work->d_inode) { err = -EEXIST ;
@@ -778,6 +782,21 @@ retry: err =ovl_create_real (dir, work, &stat,NULL ,NULL , true);if (err) goto out_dput; + + err =vfs_removexattr (work,XATTR_NAME_POSIX_ACL_DEFAULT ); +if (err && err != -ENODATA ) + goto out_dput; + + err =vfs_removexattr (work,XATTR_NAME_POSIX_ACL_ACCESS ); +if (err && err != -ENODATA ) + goto out_dput; + +/* Clear any inherited mode bits */ +inode_lock (work->d_inode); + err =notify_change (work, &attr,NULL ); +inode_unlock (work->d_inode); +if (err) + goto out_dput; } out_unlock:mutex_unlock (&dir->i_mutex);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/ovl-listxattr-use-strnlen.patch queue-4.4/ovl-remove-posix_acl_default-from-workdir.patch queue-4.4/ovl-don-t-copy-up-opaqueness.patch queue-4.4/ovl-proper-cleanup-of-workdir.patch queue-4.4/ovl-fix-workdir-creation.patch