Skip to contentSkip to conversation

staging: rtl8188eu: cleanup long line in odm.c

PATCH Superseded Michael Straube 2 participants 3 messages Mar 25, 2020 – Mar 26, 2020 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: cleanup long line in odm.c

Cleanup line over 80 characters by removing unnecessary parentheses.

---
 drivers/staging/rtl8188eu/hal/odm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/odm.c +1 -1
index a6eb9798b6f8..ed1a6ea0eecf 100644
@@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)
 	if (pDM_Odm->bLinked) {
 		if (pDM_Odm->RSSI_Min > 25) {
 			CurCCK_CCAThres = 0xcd;
-		} else if ((pDM_Odm->RSSI_Min <= 25) && (pDM_Odm->RSSI_Min > 10)) {
+		} else if (pDM_Odm->RSSI_Min <= 25 && pDM_Odm->RSSI_Min > 10) {
 			CurCCK_CCAThres = 0x83;
 		} else {
 			if (FalseAlmCnt->Cnt_Cck_fail > 1000)
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Michael Straube

Cleanup line over 80 characters by removing unnecessary parentheses.

[]

drivers/staging/rtl8188eu/hal/odm.c

Quoted 1 line
drivers/staging/rtl8188eu/hal/odm.c +0 -0

[]

drivers/staging/rtl8188eu/hal/odm.c void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm) · line 593

Quoted 6 lines
drivers/staging/rtl8188eu/hal/odm.c +1 -1
@@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)
 	if (pDM_Odm->bLinked) {
 		if (pDM_Odm->RSSI_Min > 25) {
 			CurCCK_CCAThres = 0xcd;
-		} else if ((pDM_Odm->RSSI_Min <= 25) && (pDM_Odm->RSSI_Min > 10)) {
+		} else if (pDM_Odm->RSSI_Min <= 25 && pDM_Odm->RSSI_Min > 10) {

The test above this already guarantees pDM_Odm->RSSI_Min <= 25 so the block could be written just

		} else if (pDM->RSSI_Min > 10) {
Quoted 3 lines
drivers/staging/rtl8188eu/hal/odm.c +0 -0
 			CurCCK_CCAThres = 0x83;
 		} else {
 			if (FalseAlmCnt->Cnt_Cck_fail > 1000)
#2 lore raw
Quoted 15 lines · Joe Perches
Quoted 1 line · Michael Straube

Cleanup line over 80 characters by removing unnecessary parentheses.

[]

drivers/staging/rtl8188eu/hal/odm.c

Quoted 1 line
drivers/staging/rtl8188eu/hal/odm.c +0 -0

[]

drivers/staging/rtl8188eu/hal/odm.c void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm) · line 593

Quoted 6 lines
drivers/staging/rtl8188eu/hal/odm.c +1 -1
@@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)
  	if (pDM_Odm->bLinked) {
  		if (pDM_Odm->RSSI_Min > 25) {
  			CurCCK_CCAThres = 0xcd;
-		} else if ((pDM_Odm->RSSI_Min <= 25) && (pDM_Odm->RSSI_Min > 10)) {
+		} else if (pDM_Odm->RSSI_Min <= 25 && pDM_Odm->RSSI_Min > 10) {

The test above this already guarantees pDM_Odm->RSSI_Min <= 25 so the block could be written just

Quoted 2 lines
		} else if (pDM->RSSI_Min > 10) {

Ah, yes. Thank you. :)