colibri_t30: fix usb ethernet functionality
PATCH 1/1 colibri_t30: fix usb ethernet functionality
Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
("net: Stop including NFS overhead in defragment max") the following has been reproducibly observed while trying to transfer data over TFTP:
Load address: 0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5
This patch fixes this by upping our maximal de-fragmentation aka IP packet size again.
---
include/configs/colibri_t30.h | 1 + 1 file changed, 1 insertion(+)
include/configs/colibri_t30.h +1 -0
@@ -48,6 +48,7 @@/* General networking support */ #define CONFIG_IP_DEFRAG +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)#define CONFIG_TFTP_BLOCKSIZE 16384#define CONFIG_TFTP_TSIZE
Signature · 1 line
2.5.5
PATCH 1/1 colibri_t30: fix usb ethernet functionality
Hi Marcel,
Quoted 24 lines · Marcel Ziswiler
Since commit
aa7a648747d8c704a9a81c9e493d386930724e9d
("net: Stop including NFS overhead in defragment max") the following has been reproducibly observed while trying to transfer data over TFTP:Load address:
0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5This patch fixes this by upping our maximal de-fragmentation aka IP packet size again.
Signed-off-by Marcel Ziswiler <[email protected]>---
include/configs/colibri_t30.h | 1 + 1 file changed, 1 insertion(+)include/configs/colibri_t30.h +0
-0
include/configs/colibri_t30.h line 51
Quoted 4 lines
include/configs/colibri_t30.h +1
-0@@ -48,6 +48,7 @@/* General networking support */ #define CONFIG_IP_DEFRAG +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
I suspect this is more than you need, right? You are using TFTP, not NFS. You probably only need an extra 34 bytes.
include/configs/colibri_t30.h line 52
Quoted 1 line
include/configs/colibri_t30.h +0
-0#define CONFIG_TFTP_BLOCKSIZE 16384
You could also just reduce this by 34 bytes.
Quoted 9 lines
include/configs/colibri_t30.h +0
-1#define CONFIG_TFTP_TSIZE --2.5.5
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Marek Vasut
AppliedPATCH 1/1 colibri_t30: fix usb ethernet functionality
In reply to Marcel ZiswilerQuoted 25 lines · Marcel Ziswiler
Since commit
aa7a648747d8c704a9a81c9e493d386930724e9d
("net: Stop including NFS overhead in defragment max") the following has been reproducibly observed while trying to transfer data over TFTP:Load address:
0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5This patch fixes this by upping our maximal de-fragmentation aka IP packet size again.
Signed-off-by Marcel Ziswiler <[email protected]>---
include/configs/colibri_t30.h | 1 + 1 file changed, 1 insertion(+)include/configs/colibri_t30.h +0
-0
include/configs/colibri_t30.h line 54
Quoted 7 lines
include/configs/colibri_t30.h +1
-0@@ -48,6 +48,7 @@/* General networking support */ #define CONFIG_IP_DEFRAG +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)#define CONFIG_TFTP_BLOCKSIZE 16384#define CONFIG_TFTP_TSIZE
Applied, thanks . If you need to rectify this further based on Joe's feedback, please do, but I want this fixed before the release.
Signature · 2 lines
Best regards, Marek Vasut
PATCH 1/1 colibri_t30: fix usb ethernet functionality
Quoted 23 lines · Marek Vasut
Quoted 22 lines · Marcel Ziswiler
Since commit
aa7a648747d8c704a9a81c9e493d386930724e9d("net: Stop including NFS overhead in defragment max") the following
has been reproducibly observed while trying to transfer data over TFTP:Load address:
0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5This patch fixes this by upping our maximal de-fragmentation aka IP packet size again.
Signed-off-by Marcel Ziswiler <[email protected]>---
?include/configs/colibri_t30.h | 1 +
?1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 6 lines
include/configs/colibri_t30.h +0
-0@@ -48,6 +48,7 @@Quoted 8 lines
?
?/* General networking support */
?#defineCONFIG_IP_DEFRAG
+#defineCONFIG_NET_MAXDEFRAG(16384 + 4096 + 24)
?#defineCONFIG_TFTP_BLOCKSIZE16384
?#defineCONFIG_TFTP_TSIZE
?Applied, thanks . If you need to rectify this further based on Joe's feedback, please do, but I want this fixed before the release.
Unfortunately the release already happened. Nevertheless I will send an updated version 2 ASAP which fixes all of our boards currently exhibiting this issue the way Joe suggested.
PATCH 1/1 colibri_t30: fix usb ethernet functionality
Quoted 41 lines · Marcel Ziswiler
Quoted 30 lines · Marek Vasut
Quoted 29 lines · Marcel Ziswiler
Since commit
aa7a648747d8c704a9a81c9e493d386930724e9d("net: Stop including NFS overhead in defragment max") the following
has been reproducibly observed while trying to transfer data over TFTP:Load address:
0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5This patch fixes this by upping our maximal de-fragmentation aka IP packet size again.
Signed-off-by Marcel Ziswiler <[email protected]>---
include/configs/colibri_t30.h | 1 + 1 file changed, 1 insertion(+)include/configs/colibri_t30.h +0
-0@@ -48,6 +48,7 @@Quoted 9 lines
include/configs/colibri_t30.h line 54
Quoted 7 lines
include/configs/colibri_t30.h +1
-0/* General networking support */ #define CONFIG_IP_DEFRAG +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)#define CONFIG_TFTP_BLOCKSIZE 16384#define CONFIG_TFTP_TSIZE Applied, thanks . If you need to rectify this further based on Joe's feedback, please do, but I want this fixed before the release.
Quoted 4 lines
Unfortunately the release already happened. Nevertheless I will send an updated version 2 ASAP which fixes all of our boards currently exhibiting this issue the way Joe suggested.
Please base that on top of u-boot-usb/master , I already applied V1 . Me and Tom agreed this is not critical enough to wrap it into release.
Signature · 2 lines
Best regards, Marek Vasut