Skip to contentSkip to conversation

ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()

PATCH In review Wei Yongjun 3 participants 3 messages Sep 17, 2016 – Sep 21, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()

From: Wei Yongjun <[email protected]>

Fix the missing clk_disable_unprepare() before return from uni_player_start() in the error handling case.

---
 sound/soc/sti/uniperif_player.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/sti/uniperif_player.c +3 -1
index 645e415..1bc8ebc 100644
@@ -893,8 +893,10 @@ static int uni_player_start(struct uniperif *player)
 	SET_UNIPERIF_SOFT_RST_SOFT_RST(player);
 
 	ret = reset_player(player);
-	if (ret < 0)
+	if (ret < 0) {
+		clk_disable_unprepare(player->clk);
 		return ret;
+	}
 
 	/*
 	 * Does not use IEC61937 features of the uniperipheral hardware.
Acked-by on v1 1/1
#1 lore raw

Hello Wei,

Thanks!

Quoted 27 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Fix the missing clk_disable_unprepare() before return from uni_player_start() in the error handling case.

---
 sound/soc/sti/uniperif_player.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/sti/uniperif_player.c +3 -1
index 645e415..1bc8ebc 100644
@@ -893,8 +893,10 @@ static int uni_player_start(struct uniperif *player)
 	SET_UNIPERIF_SOFT_RST_SOFT_RST(player);
 
 	ret = reset_player(player);
-	if (ret < 0)
+	if (ret < 0) {
+		clk_disable_unprepare(player->clk);
 		return ret;
+	}
 
 	/*
 	 * Does not use IEC61937 features of the uniperipheral hardware.
maintainer
#2 lore raw

Applied "ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()" to the asoc tree

In reply to Wei Yongjun

The patch

ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From b7c8c5d6927f9e6f3b4c0f8fcc99daa4568ad185 Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Sat, 17 Sep 2016 01:34:33 +0000
Subject: [PATCH] ASoC: sti: fix missing clk_disable_unprepare() on error in
uni_player_start()

Fix the missing clk_disable_unprepare() before return from uni_player_start() in the error handling case.

---
 sound/soc/sti/uniperif_player.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/sti/uniperif_player.c +3 -1
index 645e4152e6a1..1bc8ebc2528e 100644
@@ -893,8 +893,10 @@ static int uni_player_start(struct uniperif *player)
 	SET_UNIPERIF_SOFT_RST_SOFT_RST(player);
 
 	ret = reset_player(player);
-	if (ret < 0)
+	if (ret < 0) {
+		clk_disable_unprepare(player->clk);
 		return ret;
+	}
 
 	/*
 	 * Does not use IEC61937 features of the uniperipheral hardware.
Signature · 1 line
2.8.1