Skip to contentSkip to conversation

vme: fake: remove unexpected unlock in fake_master_set()

PATCH New Wei Yongjun 1 participant 1 message Sep 17, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vme: fake: remove unexpected unlock in fake_master_set()

From: Wei Yongjun <[email protected]>

image->lock is unlocked in some error handling path without take the lock, so remove those unexpected unlock.

Fixes 658bcdae9c67 ("vme: Adding Fake VME driver")
---
 drivers/vme/bridges/vme_fake.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/vme/bridges/vme_fake.c +0 -3
index ebf35d3..4b2613d 100644
@@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	}
 
 	if (size & 0xFFFF) {
-		spin_unlock(&image->lock);
 		pr_err("Invalid size alignment\n");
 		retval = -EINVAL;
 		goto err_window;
@@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	case VME_D32:
 		break;
 	default:
-		spin_unlock(&image->lock);
 		pr_err("Invalid data width\n");
 		retval = -EINVAL;
 		goto err_dwidth;
@@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	case VME_USER4:
 		break;
 	default:
-		spin_unlock(&image->lock);
 		pr_err("Invalid address space\n");
 		retval = -EINVAL;
 		goto err_aspace;