Skip to contentSkip to conversation

nigthly-qa-*, nigthly-rpm*: Move RunSanityTests before SendErrorReport

PATCH In review Aníbal Limón 2 participants 2 messages Sep 18, 2016 – Sep 19, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nigthly-qa-*, nigthly-rpm*: Move RunSanityTests before SendErrorReport

If RunSanityTests executes after SendErrorReport and fails, the error report was not send to the errors.yp.org server.

---
 buildset-config.controller/nightly-qa-extras.conf       | 4 ++--
 buildset-config.controller/nightly-qa-logrotate.conf    | 6 ++----
 buildset-config.controller/nightly-qa-pam.conf          | 5 ++---
 buildset-config.controller/nightly-qa-skeleton.conf     | 5 ++---
 buildset-config.controller/nightly-qa-systemd.conf      | 4 ++--
 buildset-config.controller/nightly-qa-targetbuilds.conf | 6 +++---
 buildset-config.controller/nightly-rpm-non-rpm.conf     | 4 ++--
 buildset-config.controller/nightly-rpm.conf             | 4 ++--
 8 files changed, 17 insertions(+), 21 deletions(-)
buildset-config.controller/nightly-qa-extras.conf +2 -2
index 2ec7b50..f796bb1 100644
@@ -18,6 +18,6 @@ steps: [{'SetDest':{}},
                             'distro': 'poky', 'buildhistory' : False,
                             'atextappend' : '\nROOT_HOME = "/root"\n'}},
         {'BuildImages': {'images': 'core-image-minimal'}},
+        {'RunSanityTests': {'images': 'core-image-minimal'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-minimal'}}]
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-logrotate.conf +2 -4
index 41dd135..1545509 100644
@@ -13,8 +13,6 @@ steps: [{'SetDest':{}},
                             'atextappend' : '\nIMAGE_INSTALL_append = " logrotate"\n'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
         {'BuildImages': {'images': 'core-image-sato'}},
+        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'logrotate'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'logrotate'}}]
-
-
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-pam.conf +2 -3
index 5cec2c8..3fdb76f 100644
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
                             'atextappend' : '\nDISTRO_FEATURES_append = " pam"\n'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
         {'BuildImages': {'images': 'core-image-sato'}},
+        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'pam'}},
         {'SendErrorReport': {}},
-        {'DownloadErrorReports': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'pam'}}]
-
+        {'DownloadErrorReports': {}}]
buildset-config.controller/nightly-qa-skeleton.conf +2 -3
index c29ca7b..9ac4c5e 100644
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},
                             'atextappend' : '\nIMAGE_INSTALL_append = " service hello-mod"\n'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto', 'layerdirs': ['meta-skeleton']}},
         {'BuildImages': {'images': 'core-image-sato'}},
+        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'skeletoninit'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'skeletoninit'}}]
-
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-systemd.conf +2 -2
index 662caa6..bb6da0b 100644
@@ -27,6 +27,6 @@ steps: [{'SetDest':{}},
                             'buildhistory' : False, 'distro': 'poky',
                             'initmgr' : 'systemd'}},
         {'BuildImages': {'images': 'core-image-sato'}},
+        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}}]
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-targetbuilds.conf +3 -3
index e31af26..c36f518 100644
@@ -27,7 +27,7 @@ steps: [{'SetDest':{}},
         {'CreateAutoConf': {'machine': 'qemuppc', 'SDKMACHINE' : 'x86_64',
                             'buildhistory' : False, 'distro': 'poky'}},
         {'BuildImages': {'images': 'core-image-sato-sdk'}},
-        {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
         {'RunSanityTests': {'images': 'core-image-sato-sdk',
-                            'suites' : 'ping ssh buildsudoku buildcvs buildiptables'}}]
+                            'suites' : 'ping ssh buildsudoku buildcvs buildiptables'}},
+        {'DownloadErrorReports': {}},
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-rpm-non-rpm.conf +2 -2
index 5290d6d..4ac743a 100644
@@ -13,6 +13,6 @@ steps: [{'SetDest':{}},
                             'packages': 'rpm'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
         {'BuildImages': {'images' : 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}},
+        {'RunSanityTests': {'images' : 'core-image-minimal core-image-sato core-image-sato-sdk'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images' : 'core-image-minimal core-image-sato core-image-sato-sdk'}}]
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-rpm.conf +2 -2
index 2ea2d6e..646127f 100644
@@ -13,6 +13,6 @@ steps: [{'SetDest':{}},
                             'packages': 'rpm'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},
         {'BuildImages': {'images' : 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}},
+        {'RunSanityTests': {'images' : 'core-image-minimal core-image-sato core-image-sato-sdk'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images' : 'core-image-minimal core-image-sato core-image-sato-sdk'}}]
+        {'SendErrorReport': {}}]
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Aníbal Limón

If RunSanityTests executes after SendErrorReport and fails, the error report was not send to the errors.yp.org server.

Pushed, thanks.

Joshua

Quoted 157 lines

---
 buildset-config.controller/nightly-qa-extras.conf       | 4 ++-- buildset-config.controller/nightly-qa-logrotate.conf    | 6 ++---- buildset-config.controller/nightly-qa-pam.conf          | 5 ++--- buildset-config.controller/nightly-qa-skeleton.conf     | 5 ++--- buildset-config.controller/nightly-qa-systemd.conf      | 4 ++-- buildset-config.controller/nightly-qa-targetbuilds.conf | 6 +++--- buildset-config.controller/nightly-rpm-non-rpm.conf     | 4 ++-- buildset-config.controller/nightly-rpm.conf             | 4 ++--

 8 files changed, 17 insertions(+), 21 deletions(-)
buildset-config.controller/nightly-qa-extras.conf +0 -0
index 2ec7b50..f796bb1 100644
@@ -18,6 +18,6 @@ steps: [{'SetDest':{}},

                             'distro': 'poky', 'buildhistory' :
False,
                             'atextappend' : '\nROOT_HOME = "/root"\n'}},
         {'BuildImages': {'images': 'core-image-minimal'}}, +        {'RunSanityTests': {'images': 'core-image-minimal'}}, {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-minimal'}}] +        {'SendErrorReport': {}}]

buildset-config.controller/nightly-qa-logrotate.conf +0 -0
index 41dd135..1545509 100644
@@ -13,8 +13,6 @@ steps: [{'SetDest':{}},

                             'atextappend' : '\nIMAGE_INSTALL_append = " logrotate"\n'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'BuildImages': {'images': 'core-image-sato'}}, +        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'logrotate'}},
         {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'logrotate'}}]

buildset-config.controller/nightly-qa-logrotate.conf +1 -2
-
-
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-pam.conf +0 -0
index 5cec2c8..3fdb76f 100644
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},

                             'atextappend' :
'\nDISTRO_FEATURES_append = " pam"\n'}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'BuildImages': {'images': 'core-image-sato'}}, +        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'pam'}},
         {'SendErrorReport': {}},
-        {'DownloadErrorReports': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'pam'}}]

buildset-config.controller/nightly-qa-pam.conf +1 -1
-
+        {'DownloadErrorReports': {}}]
buildset-config.controller/nightly-qa-skeleton.conf +0 -0
index c29ca7b..9ac4c5e 100644
@@ -13,7 +13,6 @@ steps: [{'SetDest':{}},

                             'atextappend' : '\nIMAGE_INSTALL_append = " service hello-mod"\n'}},
         {'CreateBBLayersConf': {'buildprovider' : 'yocto', 'layerdirs': ['meta-skeleton']}},
         {'BuildImages': {'images': 'core-image-sato'}}, +        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'skeletoninit'}}, {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'skeletoninit'}}]

buildset-config.controller/nightly-qa-skeleton.conf +1 -1
-
+        {'SendErrorReport': {}}]
buildset-config.controller/nightly-qa-systemd.conf +0 -0
index 662caa6..bb6da0b 100644
@@ -27,6 +27,6 @@ steps: [{'SetDest':{}},

                             'buildhistory' : False, 'distro':
'poky',
                             'initmgr' : 'systemd'}}, {'BuildImages': {'images': 'core-image-sato'}}, +        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}}, {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}}]
+        {'SendErrorReport': {}}]

buildset-config.controller/nightly-qa-targetbuilds.conf +0 -0
index e31af26..c36f518 100644
@@ -27,7 +27,7 @@ steps: [{'SetDest':{}},

         {'CreateAutoConf': {'machine': 'qemuppc', 'SDKMACHINE' :
'x86_64',
                             'buildhistory' : False, 'distro':
'poky'}},
         {'BuildImages': {'images': 'core-image-sato-sdk'}}, -        {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
         {'RunSanityTests': {'images': 'core-image-sato-sdk', -                            'suites' : 'ping ssh buildsudoku buildcvs buildiptables'}}]
+                            'suites' : 'ping ssh buildsudoku buildcvs buildiptables'}},
+        {'DownloadErrorReports': {}},
+        {'SendErrorReport': {}}]

buildset-config.controller/nightly-rpm-non-rpm.conf +0 -0
index 5290d6d..4ac743a 100644
@@ -13,6 +13,6 @@ steps: [{'SetDest':{}},
                              'packages': 'rpm'}},
          {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},

         {'BuildImages': {'images' : 'core-image-sato core-image- sato-dev core-image-sato-sdk core-image-minimal core-image-minimal- dev'}},
+        {'RunSanityTests': {'images' : 'core-image-minimal core- image-sato core-image-sato-sdk'}}, {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images' : 'core-image-minimal core- image-sato core-image-sato-sdk'}}]
+        {'SendErrorReport': {}}]

buildset- renamed from buildset-config.controller/nightly-rpm.conf +0 -0

config.controller/nightly-rpm.conf
index 2ea2d6e..646127f 100644

buildset-config.controller/nightly-rpm.conf +0 -0
@@ -13,6 +13,6 @@ steps: [{'SetDest':{}},
                              'packages': 'rpm'}},
          {'CreateBBLayersConf': {'buildprovider' : 'yocto'}},

         {'BuildImages': {'images' : 'core-image-sato core-image- sato-dev core-image-sato-sdk core-image-minimal core-image-minimal- dev'}},
+        {'RunSanityTests': {'images' : 'core-image-minimal core- image-sato core-image-sato-sdk'}}, {'DownloadErrorReports': {}},
-        {'SendErrorReport': {}},
-        {'RunSanityTests': {'images' : 'core-image-minimal core- image-sato core-image-sato-sdk'}}]
+        {'SendErrorReport': {}}]