Skip to contentSkip to conversation

sh-pfc: Initial r8a73a4 PFC support

PATCH In review Magnus Damm 3 participants 8 messages Mar 26, 2013 – Mar 28, 2013 SuperH

lore
Share & tools
lore
#0 lore raw

v2 cover sh-pfc: Initial r8a73a4 PFC support

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

---

Written against renesas-next-20130321 in renesas.git Requires "r8a73a4.h" provided by
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3

 arch/arm/mach-shmobile/include/mach/r8a73a4.h | 1838 +++++-----
 drivers/pinctrl/sh-pfc/Kconfig                |    5 
 drivers/pinctrl/sh-pfc/Makefile               |    1 
 drivers/pinctrl/sh-pfc/core.c                 |    3 
 drivers/pinctrl/sh-pfc/core.h                 |    1 
 drivers/pinctrl/sh-pfc/pfc-r8a73a4.c          | 4592 +++++++++++++++++++------
 6 files changed, 4519 insertions(+), 1921 deletions(-)
#1 lore raw
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere, but could you let me know a bit about the dependencies for this series.

I am assuming it depends on:

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it or should I add it to my tree directly?

#2 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 29 lines · On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere, but could you let me know a bit about the dependencies for this series.

Quoted 7 lines

I am assuming it depends on:

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it or should I add it to my tree directly?

You can add it to your tree directly when it will be ready. I've acked all but patches 01/13 and 06/13. I expect Magnus to resubmit 06/13, could you please have a look at my comments on the cover letter and tell whether 01/13 should be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary from the ARM tree point of view ?

Signature · 3 lines
Regards,

Laurent Pinchart
#3 lore raw
In reply to Magnus Damm
Quoted 26 lines · Simon Horman
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

Quoted 7 lines

I apologise if the information is obvious or available elsewhere, but could you let me know a bit about the dependencies for this series.

I am assuming it depends on:

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Hi Simon,

Thanks for your email. It looks like you estimated the worst-case dependencies. =)

Fortunately, for r8a73a4 (APE6) there is no separate GPIO controller. So regular PFC without any special dependencies is enough. This means that the r8a7779 patches are not needed for r8a73a4. However, to fully support r8a7790 (R-Car H2) we need to follow the same pattern as r8a7779. The automotive SoCs seem to come with a separate GPIO controller.

So based on that the following patches should be enough for merging:

Written against renesas-next-20130321 in renesas.git Requires "r8a73a4.h" provided by
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3

The above r8a73a4 SoC V3 series also requires the following patch:
[PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB

To actually use this code you also need board code provided by a separate patch series.

Thanks,

/ magnus

#4 lore raw
In reply to Magnus Damm
Quoted 53 lines · Magnus Damm
Quoted 26 lines · Simon Horman
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

Quoted 7 lines

I apologise if the information is obvious or available elsewhere, but could you let me know a bit about the dependencies for this series.

I am assuming it depends on:

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Hi Simon,

Thanks for your email. It looks like you estimated the worst-case dependencies. =)

Fortunately, for r8a73a4 (APE6) there is no separate GPIO controller. So regular PFC without any special dependencies is enough. This means that the r8a7779 patches are not needed for r8a73a4. However, to fully support r8a7790 (R-Car H2) we need to follow the same pattern as r8a7779. The automotive SoCs seem to come with a separate GPIO controller.

So based on that the following patches should be enough for merging:

Written against renesas-next-20130321 in renesas.git Requires "r8a73a4.h" provided by
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V3

Quoted 5 lines

The above r8a73a4 SoC V3 series also requires the following patch:
[PATCH/RFC] ARM: shmobile: Disallow PINCTRL without GPIOLIB

To actually use this code you also need board code provided by a separate patch series.

Thanks, got it.

#5 lore raw
In reply to Magnus Damm
Quoted 34 lines · Laurent Pinchart

Hi Simon,

Quoted 31 lines · On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere, but could you let me know a bit about the dependencies for this series.

I am assuming it depends on:

Quoted 8 lines
Quoted 5 lines

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it or should I add it to my tree directly?

You can add it to your tree directly when it will be ready. I've acked all but patches 01/13 and 06/13.

Got it. I will hold off for now.

Quoted 4 lines

I expect Magnus to resubmit 06/13, could you please
have a look at my comments on the cover letter and tell whether 01/13 should be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary from the ARM tree point of view ?

Unfortunately I seem to be missing the email with your comments but I think that it is not strictly necessary to split the patch. Although doing so would allow it to be applied to a separate branch (soc, most likely) it would also set up a dependency on that branch. And to be honest, I have enough branch dependencies already.

Acked-by on the v2 series
#6 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 50 lines · On Wednesday 27 March 2013 21:21:57 Simon Horman wrote:
Quoted 33 lines · Laurent Pinchart
Quoted 32 lines · On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere, but could
you let me know a bit about the dependencies for this series.

I am assuming it depends on:

Quoted 8 lines
Quoted 5 lines

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it or should I add it to my tree directly?

You can add it to your tree directly when it will be ready. I've acked all but patches 01/13 and 06/13.

Got it. I will hold off for now.

Quoted 4 lines

I expect Magnus to resubmit 06/13, could you please
have a look at my comments on the cover letter and tell whether 01/13 should be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary from the ARM tree point of view ?

Quoted 5 lines

Unfortunately I seem to be missing the email with your comments but I think that it is not strictly necessary to split the patch. Although doing so would allow it to be applied to a separate branch (soc, most likely) it would also set up a dependency on that branch. And to be honest, I have enough branch dependencies already.

Fair enough.

for 01/13 then. All that is missing is a resubmission of 06/13.

Signature · 3 lines
Regards,

Laurent Pinchart
#7 lore raw
In reply to Magnus Damm
Quoted 53 lines · Laurent Pinchart

Hi Simon,

Quoted 50 lines · On Wednesday 27 March 2013 21:21:57 Simon Horman wrote:
Quoted 33 lines · Laurent Pinchart
Quoted 32 lines · On Wednesday 27 March 2013 13:56:28 Simon Horman wrote:
Quoted 16 lines · Magnus Damm

sh-pfc: Initial r8a73a4 PFC support (V2)

[PATCH 01/13] sh-pfc: Add r8a73a4 pinmux support
[PATCH 02/13] sh-pfc: r8a73a4: Support sparse GPIO numbers [PATCH 03/13 v2] sh-pfc: r8a73a4: GPIO IRQ support
[PATCH 04/13] sh-pfc: r8a73a4: Add bias (pull-up/down) pinconf support [PATCH 05/13] sh-pfc: r8a73a4: Add SCIF pin groups and functions [PATCH 06/13] sh-pfc: r8a73a4: Add IRQC pin groups and functions [PATCH 07/13] sh-pfc: r8a73a4: Remove SCIF function GPIOS [PATCH 08/13] sh-pfc: r8a73a4: Remove IRQC function GPIOS [PATCH 09/13] ARM: shmobile: r8a73a4: Remove SCIF function GPIOs [PATCH 10/13] ARM: shmobile: r8a73a4: Remove IRQC function GPIOs [PATCH 11/13] sh-pfc: r8a73a4: Remove function GPIOs
[PATCH 12/13] ARM: shmobile: r8a73a4: Remove all GPIO enums [PATCH 13/13] sh-pfc: r8a73a4: Remove unused GPIO bias data

Quoted 6 lines

This series is V2 of initial PFC support for the r8a73a4 SoC. The patches add a regular old-style GPIO function controller and makes it partially converted over to PINCTRL for SCIF and IRQC that are tied up on the APE6EVM board. The final patches remove the GPIO function support, so when new drivers for r8a73a4 are added then PINCTRL support has to be included.

Hi Magnus,

I apologise if the information is obvious or available elsewhere, but could
you let me know a bit about the dependencies for this series.

I am assuming it depends on:

Quoted 8 lines
Quoted 5 lines

[PATCH 00/03 v3] ARM: shmobile: r8a73a4 APE6EVM board support [PATCH/RFC 00/12] Split PFC and GPIO for R8A7779

Laurent, if/when this series is ready do you want to take it or should I add it to my tree directly?

You can add it to your tree directly when it will be ready. I've acked all but patches 01/13 and 06/13.

Got it. I will hold off for now.

Quoted 4 lines

I expect Magnus to resubmit 06/13, could you please
have a look at my comments on the cover letter and tell whether 01/13 should be split in a arch/arm/ patch and a drivers/ patch or if that's unnecessary from the ARM tree point of view ?

Quoted 7 lines
Quoted 5 lines

Unfortunately I seem to be missing the email with your comments but I think that it is not strictly necessary to split the patch. Although doing so would allow it to be applied to a separate branch (soc, most likely) it would also set up a dependency on that branch. And to be honest, I have enough branch dependencies already.

Fair enough.

After all that it seems that there are dependencies in the pinmux branch for a patch by bastian "ARM: shmobile: r8a7740: Migrate from INTC to GIC". But I am still happy for 01/13 to go into pinmux as-is.

Quoted 14 lines

for 01/13 then. All that is missing is a resubmission of 06/13.

Signature · 8 lines
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html