Patch "drm/msm: protect against faults from copy_from_user() in submit ioctl" has been added to the 4.7-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
drm/msm: protect against faults from copy_from_user() in submit ioctl
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-msm-protect-against-faults-from-copy_from_user-in-submit-ioctl.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
d78d383ab354b0b9e1d23404ae0d9fbdeb9aa035Mon Sep 17 00:00:00 2001
From: Rob Clark <[email protected]>
Date: Mon, 22 Aug 2016 15:28:38 -0400
Subject: drm/msm: protect against faults from copy_from_user() in submit ioctl
From: Rob Clark <[email protected]>
commit d78d383ab354b0b9e1d23404ae0d9fbdeb9aa035 upstream.
An evil userspace could try to cause deadlock by passing an unfaulted-in GEM bo as submit->bos (or submit->cmds) table. Which will trigger msm_gem_fault() while we already hold struct_mutex. See:
https://github.com/freedreno/msmtest/blob/master/evilsubmittest.c
--- drivers/gpu/drm/msm/msm_drv.h | 6 ++++++ drivers/gpu/drm/msm/msm_gem.c | 9 +++++++++ drivers/gpu/drm/msm/msm_gem_submit.c | 2 ++ 3 files changed, 17 insertions(+)
drivers/gpu/drm/msm/msm_drv.h +6 -0
@@ -148,6 +148,12 @@ struct msm_drm_private { } vram;struct msm_vblank_ctrl vblank_ctrl; + +/* task holding struct_mutex.. currently only used in submit path +* to detect and reject faults from copy_from_user() for submit +* ioctl. +*/ +struct task_struct *struct_mutex_task; };struct msm_format {
drivers/gpu/drm/msm/msm_gem.c +9 -0
@@ -196,11 +196,20 @@ int msm_gem_fault(struct vm_area_struct {struct drm_gem_object *obj = vma->vm_private_data;struct drm_device *dev = obj->dev; +struct msm_drm_private *priv = dev->dev_private;struct page **pages;unsigned long pfn;pgoff_t pgoff;int ret; +/* This should only happen if userspace tries to pass a mmap'd +* but unfaulted gem bo vaddr into submit ioctl, triggering +* a page fault while struct_mutex is already held. This is +* not a valid use-case so just bail. +*/ +if (priv->struct_mutex_task == current) +return VM_FAULT_SIGBUS ; +/* Make sure we don't parallel update on a fault, nor move or remove * something from beneath our feet */
drivers/gpu/drm/msm/msm_gem_submit.c +2 -0
@@ -394,6 +394,7 @@ int msm_ioctl_gem_submit(struct drm_devireturn -ENOMEM ;mutex_lock (&dev->struct_mutex); + priv->struct_mutex_task = current; ret =submit_lookup_objects (submit, args, file);if (ret)
@@ -479,6 +480,7 @@ out:submit_cleanup (submit);if (ret)msm_gem_submit_free (submit); + priv->struct_mutex_task =NULL ;mutex_unlock (&dev->struct_mutex);return ret; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/drm-msm-protect-against-faults-from-copy_from_user-in-submit-ioctl.patch