drm/i915: Unlock PPS registers after GPU reset
Subsystems (2)
PATCH 1/1 drm/i915: Unlock PPS registers after GPU reset
Reapply the PPS register unlock workaround after GPU reset on platforms where the reset clobbers the display HW state. This at least gets rid of the related WARN during LVDS encoder enabling on PNV.
--- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -3629,6 +3629,7 @@ void intel_finish_reset(struct drm_i915_private *dev_priv)intel_runtime_pm_disable_interrupts (dev_priv);intel_runtime_pm_enable_interrupts (dev_priv); +intel_pps_unlock_regs_wa (dev_priv);intel_modeset_init_hw (dev);spin_lock_irq (&dev_priv->irq_lock);
Signature · 6 lines
2.5.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Unlock PPS registers after GPU reset
== Series Details ==
== Series Details ==
Series: drm/i915: Unlock PPS registers after GPU reset
URL : https://patchwork.freedesktop.org/series/12446/
State : success
== Summary ==
Series 12446v1 drm/i915: Unlock PPS registers after GPU reset
https://patchwork.freedesktop.org/api/1.0/series/12446/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-hsw-4770k)
Test kms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (fi-ivb-3770)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-byt-j1900)
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-j1900)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-j1900 total:244 pass:212 dwarn:0 dfail:0 fail:1 skip:31 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770k total:244 pass:226 dwarn:0 dfail:0 fail:0 skip:18 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:183 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:0 dfail:0 fail:1 skip:22 fi-skl-6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2530/
9aa8c0cdbc076bcc0486d7a31922a0f77c032fe7 drm-intel-nightly: 2016y-09m-14d-09h-19m-25s UTC integration manifest 424c774 drm/i915: Unlock PPS registers after GPU reset
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Unlock PPS registers after GPU reset
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Unlock PPS registers after GPU reset
URL : https://patchwork.freedesktop.org/series/12446/
State : success
== Summary ==
Series 12446v1 drm/i915: Unlock PPS registers after GPU reset
https://patchwork.freedesktop.org/api/1.0/series/12446/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-hsw-4770k)
Test kms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (fi-ivb-3770)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-byt-j1900)
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-j1900)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-j1900 total:244 pass:212 dwarn:0 dfail:0 fail:1 skip:31 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770k total:244 pass:226 dwarn:0 dfail:0 fail:0 skip:18 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:183 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:0 dfail:0 fail:1 skip:22 fi-skl-6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2530/
9aa8c0cdbc076bcc0486d7a31922a0f77c032fe7 drm-intel-nightly: 2016y-09m-14d-09h-19m-25s UTC integration manifest 424c774 drm/i915: Unlock PPS registers after GPU reset
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Unlock PPS registers after GPU reset
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Unlock PPS registers after GPU reset URL : https://patchwork.freedesktop.org/series/12446/
State : success
Thanks for the report and review, I pushed it to -dinq.
Quoted 48 lines
== Summary ==
Series 12446v1 drm/i915: Unlock PPS registers after GPU reset
https://patchwork.freedesktop.org/api/1.0/series/12446/revisions/1/mb
ox/Test
gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-hsw-4770k) Testkms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (fi-ivb-3770) Testkms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-byt-j1900) Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-j1900)fi-bdw-
5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-
n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-
j1900 total:244 pass:212 dwarn:0 dfail:0 fail:1 skip:31 fi-byt-
n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-
4770k total:244 pass:226 dwarn:0 dfail:0 fail:0 skip:18 fi-hsw-
4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-
650 total:244 pass:183 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-
3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-
3770 total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-skl-
6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-
6700hq total:244 pass:221 dwarn:0 dfail:0 fail:1 skip:22 fi-skl-
6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24 fi-snb-
2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-
2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Quoted 6 lines
Results at /archive/results/CI_IGT_test/Patchwork_2530/
9aa8c0cdbc076bcc0486d7a31922a0f77c032fe7drm-intel-nightly: 2016y- 09m-14d-09h-19m-25s UTC integration manifest
424c774 drm/i915: Unlock PPS registers after GPU reset
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Imre Deak
Reapply the PPS register unlock workaround after GPU reset on platforms where the reset clobbers the display HW state. This at least gets rid of the related WARN during LVDS encoder enabling on PNV.
Fixes ed6143b8f75 ("drm/i915/lvds: Restore initial HW state during encoder enabling")Reported-by Ville Syrjälä <[email protected]>Signed-off-by Imre Deak <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_display.c +1
-0@@ -3629,6 +3629,7 @@ void intel_finish_reset(struct drm_i915_private *dev_priv)intel_runtime_pm_disable_interrupts (dev_priv);intel_runtime_pm_enable_interrupts (dev_priv); +intel_pps_unlock_regs_wa (dev_priv);intel_modeset_init_hw (dev);spin_lock_irq (&dev_priv->irq_lock);Signature · 1 line
2.5.0
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx