Skip to contentSkip to conversation

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

PATCH In review Harman Kalra 3 participants 4 messages Sep 21, 2016 – Sep 22, 2016

Subsystems (2)
libata Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Harman Kalra

author
#0 lore raw

PATCH 1/1 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

Signed-off-by Harman Kalra <[email protected]>
---
 drivers/ata/pata_at91.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/ata/pata_at91.c +1 -3
index 9f27b14..1611e0e 100644
@@ -347,10 +347,8 @@ static int at91sam9_smc_fields_init(struct device *dev)
 
 	field.reg = AT91SAM9_SMC_MODE(AT91SAM9_SMC_GENERIC);
 	fields.mode = devm_regmap_field_alloc(dev, smc, field);
-	if (IS_ERR(fields.mode))
-		return PTR_ERR(fields.mode);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(fields.mode);
 }
 
 static int pata_at91_probe(struct platform_device *pdev)
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 2 lines · Sergei Shtylyov

Looks like your patch summary and description got merged together in the
subject.

Also, the subject (summary) should contain driver name as a prefix:
"pata_at91: Use ..."

Quoted 2 lines
Quoted 1 line
Signed-off-by Harman Kalra <[email protected]>

[...]

MBR, Sergei