Patch "audit: fix exe_file access in audit_exe_compare" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
audit: fix exe_file access in audit_exe_compare
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
audit-fix-exe_file-access-in-audit_exe_compare.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5efc244346f9f338765da3d592f7947b0afdc4b5Mon Sep 17 00:00:00 2001
From: Mateusz Guzik <[email protected]>
Date: Tue, 23 Aug 2016 16:20:39 +0200
Subject: audit: fix exe_file access in audit_exe_compare
From: Mateusz Guzik <[email protected]>
commit 5efc244346f9f338765da3d592f7947b0afdc4b5 upstream.
Prior to the change the function would blindly deference mm, exe_file and exe_file->f_inode, each of which could have been NULL or freed.
Use get_task_exe_file to safely obtain stable exe_file.
--- kernel/audit_watch.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
kernel/audit_watch.c +5 -3
@@ -19,6 +19,7 @@* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ +#include <linux/file.h> #include <linux/kernel.h> #include <linux/audit.h> #include <linux/kthread.h>
@@ -544,10 +545,11 @@ int audit_exe_compare(struct task_structunsigned long ino;dev_t dev; -rcu_read_lock (); - exe_file =rcu_dereference (tsk->mm->exe_file); + exe_file =get_task_exe_file (tsk); +if (!exe_file) +return 0 ; ino = exe_file->f_inode->i_ino; dev = exe_file->f_inode->i_sb->s_dev; -rcu_read_unlock (); +fput (exe_file);return audit_mark_compare (mark, ino, dev); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/mm-introduce-get_task_exe_file.patch queue-4.7/audit-fix-exe_file-access-in-audit_exe_compare.patch