Skip to contentSkip to conversation

Patch "iio: accel: kxsd9: Fix scaling bug" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 22, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iio: accel: kxsd9: Fix scaling bug

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iio-accel-kxsd9-fix-scaling-bug.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 307fe9dd11ae44d4f8881ee449a7cbac36e1f5de Mon Sep 17 00:00:00 2001

From: Linus Walleij <[email protected]>
Date: Thu, 1 Sep 2016 11:44:35 +0200
Subject: iio: accel: kxsd9: Fix scaling bug

From: Linus Walleij <[email protected]>

commit 307fe9dd11ae44d4f8881ee449a7cbac36e1f5de upstream.

All the scaling of the KXSD9 involves multiplication with a fraction number < 1.

However the scaling value returned from IIO_INFO_SCALE was unpredictable as only the micros of the value was assigned, and not the integer part, resulting in scaling like this:

$cat in_accel_scale
-1057462640.011978

Fix this by assigning zero to the integer part.

---
 drivers/iio/accel/kxsd9.c |    1 +
 1 file changed, 1 insertion(+)
drivers/iio/accel/kxsd9.c +1 -0
@@ -166,6 +166,7 @@ static int kxsd9_read_raw(struct iio_dev
 		ret = spi_w8r8(st->us, KXSD9_READ(KXSD9_REG_CTRL_C));
 		if (ret < 0)
 			goto error_ret;
+		*val = 0;
 		*val2 = kxsd9_micro_scales[ret & KXSD9_FS_MASK];
 		ret = IIO_VAL_INT_PLUS_MICRO;
 		break;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iio-accel-kxsd9-fix-scaling-bug.patch queue-4.4/pinctrl-sunxi-fix-uart1-cts-rts-pins-at-pg-on-a23-a33.patch queue-4.4/iio-accel-kxsd9-fix-raw-read-return.patch queue-4.4/pinctrl-pistachio-fix-mfio-pll_lock-pinmux.patch