Skip to contentSkip to conversation

Patch "pinctrl: at91-pio4: use %pr format string for resource" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Sep 22, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

pinctrl: at91-pio4: use %pr format string for resource

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pinctrl-at91-pio4-use-pr-format-string-for-resource.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 32844138e31347fc0f61d3bf2d7b9c4583f189e3 Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Wed, 18 Nov 2015 16:21:17 +0100
Subject: pinctrl: at91-pio4: use %pr format string for resource

From: Arnd Bergmann <[email protected]>

commit 32844138e31347fc0f61d3bf2d7b9c4583f189e3 upstream.

resource_size_t may be defined as 32 or 64 bit depending on configuration, so it cannot be printed using the normal format strings, as gcc correctly warns:

pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
pinctrl-at91-pio4.c:1003:41: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start);

This changes the format string to use the special "%pr" format string that prints a resource, and changes the arguments so we the resource structure directly.

---
 drivers/pinctrl/pinctrl-at91-pio4.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-at91-pio4.c +1 -1
@@ -1002,7 +1002,7 @@ static int atmel_pinctrl_probe(struct pl
 		atmel_pioctrl->irqs[i] = res->start;
 		irq_set_chained_handler(res->start, atmel_gpio_irq_handler);
 		irq_set_handler_data(res->start, atmel_pioctrl);
-		dev_dbg(dev, "bank %i: hwirq=%u\n", i, res->start);
+		dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
 	}
 
 	atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/mmc-dw_mmc-use-resource_size_t-to-store-physical-address.patch queue-4.4/net-simplify-napi_synchronize-to-avoid-warnings.patch queue-4.4/soc-qcom-spm-shut-up-uninitialized-variable-warning.patch queue-4.4/kconfig-tinyconfig-provide-whole-choice-blocks-to-avoid-warnings.patch queue-4.4/pinctrl-at91-pio4-use-pr-format-string-for-resource.patch