nvme-cli: propose 'c' vs 'r' for connect flag
RFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
I am not sure if it matters too much except in possibly human usage understanding, but '-r' is used in the 'discover' command for --raw. Change the --reconnect-delay flag single letter to something not being used in any fabrics command.
--- fabrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fabrics.c +1 -1
@@ -759,7 +759,7 @@ int connect(const char *desc, int argc, char **argv) "number of io queues to use (default is core count)" }, {"keep-alive-tmo" ,'k' ,"LIST" ,CFG_STRING , &cfg.keep_alive_tmo, required_argument, "keep alive timeout period in seconds" }, - {"reconnect-delay", 'r', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument, + {"reconnect-delay", 'c', "LIST", CFG_STRING, &cfg.reconnect_delay, required_argument, "reconnect timeout period in seconds" }, {0}, };
Signature · 1 line
2.7.4
RFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
Quoted 5 lines · Jay Freyensee
I am not sure if it matters too much except in possibly human usage understanding, but '-r' is used in the 'discover' command for --raw. Change the --reconnect-delay flag single letter to something not being used in any fabrics command.
Sounds ok to me. But I have to say dealing with these short options start to be a little annoying. For a lot of these commands I'd prefer to simply support long options only if we could (I'll need to look at argconfig.c in a bit more detail how easily that could be done).
RFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
Quoted 17 lines
-----Original Message-----
From: Linux-nvme [mailto:linux-nvme-bounces at lists.infradead.org] On Behalf Of Christoph Hellwig
Sent: Thursday, September 22, 2016 10:33 PM
To: Jay Freyensee
Cc: swise at opengridcomputing.com; linux-nvme at lists.infradead.org
Subject: Re: [PATCH RFC] nvme-cli: propose 'c' vs 'r' for connect flagQuoted 5 lines · Jay Freyensee
I am not sure if it matters too much except in possibly human usage understanding, but '-r' is used in the 'discover' command for --raw. Change the --reconnect-delay flag single letter to something not being used in any fabrics command.
Quoted 4 lines
Sounds ok to me. But I have to say dealing with these short options start to be a little annoying. For a lot of these commands I'd prefer to simply support long options only if we could (I'll need to look at
argconfig.cin a bit more detail how easily that could be done).
You could just not document the short options...
RFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
In reply to Christoph HellwigQuoted 11 lines · Christoph Hellwig
Quoted 5 lines · Jay Freyensee
I am not sure if it matters too much except in possibly human usage understanding, but '-r' is used in the 'discover' command for --raw. Change the --reconnect-delay flag single letter to something not being used in any fabrics command.
Sounds ok to me. But I have to say dealing with these short options start to be a little annoying. For a lot of these commands I'd prefer to simply support long options only if we could (I'll need to look at
argconfig.cin a bit more detail how easily that could be done).
Aw, I like having short opts. Yeah, some were arbitrarily picked to avoid clashes (though I clearly missed some clashes), and difficult to remember, but every sub-command shows consistent helpful usage info with a "--help".
RFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
Quoted 17 lines · Keith Busch
Quoted 9 lines · Christoph Hellwig
Quoted 6 lines · Jay Freyensee
I am not sure if it matters too much except in possibly human usage understanding, but '-r' is used in the 'discover' command for --raw.??Change the --reconnect-delay flag single letter to something not being used in any fabrics command.
Quoted 6 lines
Sounds ok to me.??But I have to say dealing with these short options
start to be a little annoying.??For a lot of these commands I'd prefer
to simply support long options only if we could (I'll need to look atargconfig.cin a bit more detail how easily that could be done).
Quoted 6 lines
Aw, I like having short opts. Yeah, some were arbitrarily picked to avoid
clashes (though I clearly missed some clashes), and difficult to remember,
but every sub-command shows consistent helpful usage info with a " --help".
OK, I'll respin this, add the review tags, and remove the RFC and send it back out.
Sagi Grimberg
maintainerRFC PATCH 1/1 nvme-cli: propose 'c' vs 'r' for connect flag
Quoted 3 lines
OK, I'll respin this, add the review tags, and remove the RFC and send it back out.
I'm fine with '-c' too.