Skip to contentSkip to conversation

arm: dts: qcom: apq8064-nexus7: Add pstore support to nexus7

RFC PATCH In review John Stultz 2 participants 3 messages Sep 24, 2016 – Oct 24, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 arm: dts: qcom: apq8064-nexus7: Add pstore support to nexus7

Add pstore support for the nexus7. This was useful in debugging a crash where the cpus were getting stuck with irqs off and serial output wasn't reliably working.

Cc Kees Cook <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Rob Clark <[email protected]>
Cc Stephen Boyd <[email protected]>
Cc Andy Gross <[email protected]>
Cc Vinay Simha <[email protected]>
Cc Archit Taneja <[email protected]>
---
 arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +14 -0
index 7637092..3005576 100644
@@ -15,6 +15,20 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		ramoops@0x88d00000{
+			compatible = "ramoops";
+			reg = <0x88d00000 0x100000>;
+			record-size     = <0x00020000>;
+			console-size    = <0x00020000>;
+			ftrace-size     = <0x00020000>;
+		};
+	};
+
 	ext_3p3v: regulator-fixed@1 {
 		compatible = "regulator-fixed";
 		regulator-min-microvolt = <3300000>;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 8 lines · John Stultz
 arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +0 -0
index 7637092..3005576 100644

arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts line 23

Quoted 9 lines
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +6 -0
@@ -15,6 +15,20 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		ramoops@0x88d00000{

s/0x//

and add a space between the number and the bracket please. Does this match with the reservation in android kernel?

Quoted 11 lines
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +8 -0
+			compatible = "ramoops";
+			reg = <0x88d00000 0x100000>;
+			record-size     = <0x00020000>;
+			console-size    = <0x00020000>;
+			ftrace-size     = <0x00020000>;
+		};
+	};
+
 	ext_3p3v: regulator-fixed@1 {
 		compatible = "regulator-fixed";
 		regulator-min-microvolt = <3300000>;
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw
Quoted 21 lines · Stephen Boyd
Quoted 8 lines · John Stultz
 arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +0 -0
index 7637092..3005576 100644

arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts line 23

Quoted 9 lines
arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +6 -0
@@ -15,6 +15,20 @@
              stdout-path = "serial0:115200n8";
      };
 
+     reserved-memory {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             ranges;
+
+             ramoops@0x88d00000{

s/0x//

Quoted 1 line

and add a space between the number and the bracket please.

Thanks again for the review. Will fixup the formatting bits.

Quoted 2 lines

Does this
match with the reservation in android kernel?

Yep. From the 3.4 kernel, I see:
pram->start: 0x88d00000 size: 0x100000

thanks
-john