staging: rtl8172: usb_intf.c: Fixed block comment coding style
PATCH v2 1/1 staging: rtl8172: usb_intf.c: Fixed block comment coding style
Fixed a block comment indentation in the rtl8712 usb_intf.c file. Made this as a first commit.
Resubmitted with updated subject.
Please let me know of any feedback you have.
Thanks,
Gonçalo Salazar
--- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +1 -1
@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {* * notes: drv_init() is called when the bus driver has located a card for us * to support. We accept the new device by returning 0. -*/ +*/ static int r871xu_drv_init (struct usb_interface *pusb_intf,const struct usb_device_id *pdid) {
Signature · 1 line
2.7.4
Quoted 5 lines · Gonçalo Salazar
Fixed a block comment indentation in the rtl8712
usb_intf.cfile. Made this as a first commit.
Resubmitted with updated subject.Please let me know of any feedback you have.
I missed this last time, but everything above the --- line goes into the permanent record. Are you sure you want all this to be there? Any chatty remarks and any description of what changed in subsequent submissions should be below the ---. The maintainer will see them, but they are stripped before they get merged into the repo.
Larry
Quoted 23 lines
Thanks,
Gonçalo SalazarSigned-off-by Gonçalo Salazar <[email protected]>--- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/usb_intf.c +1
-1@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {* * notes: drv_init() is called when the bus driver has located a card for us * to support. We accept the new device by returning 0. -*/ +*/ static int r871xu_drv_init (struct usb_interface *pusb_intf,const struct usb_device_id *pdid) {
2016-09-26 1:53 GMT+01:00 Larry Finger <[email protected]>:
Quoted 9 lines · Gonçalo Salazar
Quoted 6 lines
Fixed a block comment indentation in the rtl8712
usb_intf.cfile. Made this as a first commit.
Resubmitted with updated subject.Please let me know of any feedback you have.
Quoted 7 lines
I missed this last time, but everything above the --- line goes into the permanent record. Are you sure you want all this to be there? Any chatty remarks and any description of what changed in subsequent submissions should be below the ---. The maintainer will see them, but they are stripped before they get merged into the repo.
Larry
Made a mistake that should not be in the permanent record... Should I resubmit the patch? or are you able to strip it from the submission?
Gonçalo
Quoted 28 lines
Quoted 27 lines
Thanks,
Gonçalo SalazarSigned-off-by Gonçalo Salazar <[email protected]>--- drivers/staging/rtl8712/usb_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/usb_intf.c +0
-0@@ -369,7 +369,7 @@ static const struct device_type wlan_type = {* * notes: drv_init() is called when the bus driver has located a card for us
* to support. We accept the new device by returning 0.
-*/
+ */
static int r871xu_drv_init(structusb_interface*pusb_intf,
const structusb_device_id*pdid)
{
Quoted 16 lines · Gonçalo Salazar
2016-09-26 1:53 GMT+01:00 Larry Finger <[email protected]>:
Quoted 15 lines · Gonçalo Salazar
Quoted 6 lines
Fixed a block comment indentation in the rtl8712
usb_intf.cfile. Made this as a first commit.
Resubmitted with updated subject.Please let me know of any feedback you have.
I missed this last time, but everything above the --- line goes into the permanent record. Are you sure you want all this to be there? Any chatty remarks and any description of what changed in subsequent submissions should be below the ---. The maintainer will see them, but they are stripped before they get merged into the repo.
Quoted 4 lines
Quoted 1 line
Larry
Made a mistake that should not be in the permanent record... Should I resubmit the patch? or are you able to strip it from the submission?
I am not the one that applies the patches; however, it would be unreasonable to expect the maintainer to edit any patch. You need to submit V3.
Larry