Revert "Skip intel_crt_init for Dell XPS 8700"
Subsystems (2)
PATCH 1/3 Revert "Skip intel_crt_init for Dell XPS 8700"
From: Ville Syrjälä <[email protected]>
This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf.
According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks to commit e4abb733bb72 ("drm/i915: Check VBT for CRT port presence on HSW/BDW") we no longer need to blacklist it based on DMI.
Looking through the bug report, SFUSE_STRAP based detection was apparently also tried and failed, but the VBT based one should still work just fine.
The commit says that the symptom was a frozen machine, but based on the bug report it doesn't look like the CRT detection was at least directly responsible for such a drastic outcome.
Cc: Giacomo Comes <[email protected]>
References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
References: http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]
--- drivers/gpu/drm/i915/intel_crt.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/i915/intel_crt.c +0 -8
@@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = { DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"), }, }, - { - .callback = intel_no_crt_dmi_callback, - .ident = "DELL XPS 8700", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), - DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"), - }, - }, { } };
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm/i915: Register shadow VGA even when it produces spurious detection results
From: Ville Syrjälä <[email protected]>
Having a shadow VGA connector is useful for testing purposes. We currently skip registering the connector on machines where the CRT detect falsely reports it as connected. Let's instead move the the blacklist check to the detect callback (and hpd setup) and if we get a match we always report the connector as disconnected. This way we get a shadow VGA connector to help with testing, while we still avoid the user facing problems from the incorrect detection results.
commit 8ca4013d702d ("CHROMIUM: i915: Add DMI override to skip CRT initialization on ZGB") doesn't provide much in the way of details as to why 'ACER ZGB' was added to the blacklist. Trying to trace it further leads me to a chromeos bugreport I can't access. So based on the fact that the commit added the
"/* Skip machines without VGA that falsely report hotplug events */" comment, I'm going to assume that it was just spurious CRT detection. So it should be safe to move the blacklist to just block the detection and hpd without causing a regression on said machine.
In fact Stéphane confirmed on irc that the problem was indeed just crappy hotplug detect:
"22:29 < marcheu> vsyrjala: the port isn't there, but the load detect is
improperly stubbed in hw
22:29 < marcheu> vsyrjala: so it floats"
so this change should be perfectly fine.
v2: Add irc quote from Stéphane
--- drivers/gpu/drm/i915/intel_crt.c | 47 ++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 23 deletions(-)
drivers/gpu/drm/i915/intel_crt.c +24 -23
@@ -643,6 +643,24 @@ intel_crt_load_detect(struct intel_crt *crt, uint32_t pipe)return status; } +static int intel_spurious_crt_detect_dmi_callback (const struct dmi_system_id *id) +{ +DRM_DEBUG_DRIVER ("Skipping CRT detection for %s\n" , id->ident); +return 1 ; +} + +static const struct dmi_system_id intel_spurious_crt_detect[] = { + { + .callback = intel_spurious_crt_detect_dmi_callback, + .ident ="ACER ZGB" , + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"ACER" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"ZGB" ), + }, + }, + { } +}; +static enum drm_connector_status intel_crt_detect (struct drm_connector *connector,bool force) {
@@ -659,6 +677,10 @@ intel_crt_detect(struct drm_connector *connector, bool force) connector->base.id, connector->name, force); +/* Skip machines without VGA that falsely report hotplug events */ +if (dmi_check_system (intel_spurious_crt_detect)) +return connector_status_disconnected; + power_domain =intel_display_port_power_domain (intel_encoder);intel_display_power_get (dev_priv, power_domain);
@@ -808,24 +830,6 @@ static const struct drm_encoder_funcs intel_crt_enc_funcs = { .destroy = intel_encoder_destroy, }; -static int intel_no_crt_dmi_callback (const struct dmi_system_id *id) -{ -DRM_INFO ("Skipping CRT initialization for %s\n" , id->ident); -return 1 ; -} - -static const struct dmi_system_id intel_no_crt[] = { - { - .callback = intel_no_crt_dmi_callback, - .ident ="ACER ZGB" , - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"ACER" ), -DMI_MATCH (DMI_PRODUCT_NAME ,"ZGB" ), - }, - }, - { } -}; -void intel_crt_init (struct drm_device *dev) {struct drm_connector *connector;
@@ -835,10 +839,6 @@ void intel_crt_init(struct drm_device *dev)i915_reg_t adpa_reg;u32 adpa; -/* Skip machines without VGA that falsely report hotplug events */ -if (dmi_check_system (intel_no_crt)) -return ; -if (HAS_PCH_SPLIT (dev)) adpa_reg =PCH_ADPA ;else if (IS_VALLEYVIEW (dev))
@@ -906,7 +906,8 @@ void intel_crt_init(struct drm_device *dev) crt->base.disable = intel_disable_crt; } crt->base.enable = intel_enable_crt; -if (I915_HAS_HOTPLUG (dev)) +if (I915_HAS_HOTPLUG (dev) && + !dmi_check_system (intel_spurious_crt_detect)) crt->base.hpd_pin =HPD_CRT ;if (HAS_DDI (dev)) { crt->base.port =PORT_E ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915: Add spurious CRT DMI match for Intel DZ77BH-55K
In reply to [email protected]From: Ville Syrjälä <[email protected]>
Intel DZ77BH-55K board doest't have a physical VGA connector, and yet it always detects that something is connected there. Add it to the DMI blacklist to ignore the spurious detection results.
Allows me to drop 'video=VGA-1:d' from my kernel cmdline.
--- drivers/gpu/drm/i915/intel_crt.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/intel_crt.c +8 -0
@@ -658,6 +658,14 @@ static const struct dmi_system_id intel_spurious_crt_detect[] = { DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"), }, }, + { + .callback = intel_spurious_crt_detect_dmi_callback, + .ident = "Intel DZ77BH-55K", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_BOARD_NAME, "DZ77BH-55K"), + }, + }, { } };
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"
In reply to [email protected]== Series Details ==
== Series Details ==
Series: series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"
URL : https://patchwork.freedesktop.org/series/12920/
State : warning
== Summary ==
Series 12920v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/12920/revisions/1/mbox/
Test drv_module_reload_basic:
pass -> SKIP (fi-skl-6770hq)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
pass -> DMESG-WARN (fi-skl-6770hq)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
pass -> DMESG-WARN (fi-skl-6700k)
Test kms_psr_sink_crc:
Subgroup psr_basic:
pass -> DMESG-WARN (fi-skl-6700hq)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22 fi-skl-6700k total:244 pass:218 dwarn:2 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:226 dwarn:2 dfail:0 fail:1 skip:15 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:206 dwarn:0 dfail:0 fail:0 skip:38
Results at /archive/results/CI_IGT_test/Patchwork_2575/
34f3af78be52f23896926b7d41ca51d898c5224d drm-intel-nightly: 2016y-09m-26d-09h-17m-56s UTC integration manifest 17b45ac drm/i915: Add spurious CRT DMI match for Intel DZ77BH-55K
4995164 drm/i915: Register shadow VGA even when it produces spurious detection results 113f2c3 Revert "Skip intel_crt_init for Dell XPS 8700"
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"
Quoted 6 lines · Patchwork
== Series Details ==
Series: series starting with [1/3] Revert "Skip
intel_crt_initfor Dell XPS 8700"
URL : https://patchwork.freedesktop.org/series/12920/
State : warning
Quoted 7 lines
== Summary ==
Series 12920v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/12920/revisions/1/mbox/Test
drv_module_reload_basic:pass -> SKIP (fi-skl-6770hq)
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
This test has been a bit flaky historically, and the droppings aren't clear enough to pinpoint the fault.
Quoted 3 lines
Test
kms_flip:Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (fi-skl-6770hq)
[ 521.531723] [drm:skl_set_cdclk] *ERROR* failed to inform PCU about cdclk change
https://bugs.freedesktop.org/show_bug.cgi?id=97929
[ 521.541043] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe C FIFO underrun
Quoted 3 lines
Test
kms_pipe_crc_basic:Subgroup nonblocking-crc-pipe-a: pass -> DMESG-WARN (fi-skl-6700k)
[ 543.224512] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe B FIFO underrun
I'm going to chalk these up to SKL watermark problems.
Quoted 3 lines
Test
kms_psr_sink_crc:Subgroup psr_basic: pass -> DMESG-WARN (fi-skl-6700hq)
[ 669.493504] [drm:intel_pipe_update_start] *ERROR* Potential atomic update failure on pipe A
Has been happening all along. PSR+DMC messing about with vblank irqs/counters perhaps...
Nothing CRT output related in here, so I'm going to declare the patches as safe.
Quoted 22 lines
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22 fi-skl-6700k total:244 pass:218 dwarn:2 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:226 dwarn:2 dfail:0 fail:1 skip:15 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:206 dwarn:0 dfail:0 fail:0 skip:38Results at /archive/results/CI_IGT_test/Patchwork_2575/
34f3af78be52f23896926b7d41ca51d898c5224ddrm-intel-nightly: 2016y-09m-26d-09h-17m-56s UTC integration manifest 17b45ac drm/i915: Add spurious CRT DMI match for Intel DZ77BH-55K
4995164 drm/i915: Register shadow VGA even when it produces spurious detection results 113f2c3 Revert "Skipintel_crt_initfor Dell XPS 8700"
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"
Quoted 15 lines · Ville Syrjälä
Quoted 6 lines · Patchwork
== Series Details ==
Series: series starting with [1/3] Revert "Skip
intel_crt_initfor Dell XPS 8700"
URL : https://patchwork.freedesktop.org/series/12920/
State : warningQuoted 7 lines
== Summary ==
Series 12920v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/12920/revisions/1/mbox/Test
drv_module_reload_basic:pass -> SKIP (fi-skl-6770hq)
Quoted 8 lines
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in useThis test has been a bit flaky historically, and the droppings aren't clear enough to pinpoint the fault.
I added more breadcrumbs to the test, but this was not run with those changes. :(
BR,
Jani.
Quoted 52 lines
Quoted 4 lines
Test
kms_flip:Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (fi-skl-6770hq)[ 521.531723] [drm:skl_set_cdclk] *ERROR* failed to inform PCU about cdclk changehttps://bugs.freedesktop.org/show_bug.cgi?id=97929
[ 521.541043] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe C FIFO underrunQuoted 3 lines
Test
kms_pipe_crc_basic:Subgroup nonblocking-crc-pipe-a: pass -> DMESG-WARN (fi-skl-6700k)[ 543.224512] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe B FIFO underrunI'm going to chalk these up to SKL watermark problems.
Quoted 3 lines
Test
kms_psr_sink_crc:Subgroup psr_basic: pass -> DMESG-WARN (fi-skl-6700hq)[ 669.493504] [drm:intel_pipe_update_start] *ERROR* Potential atomic update failure on pipe AHas been happening all along. PSR+DMC messing about with vblank irqs/counters perhaps...
Nothing CRT output related in here, so I'm going to declare the patches as safe.
Quoted 22 lines
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22 fi-skl-6700k total:244 pass:218 dwarn:2 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:226 dwarn:2 dfail:0 fail:1 skip:15 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:206 dwarn:0 dfail:0 fail:0 skip:38Results at /archive/results/CI_IGT_test/Patchwork_2575/
34f3af78be52f23896926b7d41ca51d898c5224ddrm-intel-nightly: 2016y-09m-26d-09h-17m-56s UTC integration manifest 17b45ac drm/i915: Add spurious CRT DMI match for Intel DZ77BH-55K
4995164 drm/i915: Register shadow VGA even when it produces spurious detection results 113f2c3 Revert "Skipintel_crt_initfor Dell XPS 8700"
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: ✗ Fi.CI.BAT: warning for series starting with [1/3] Revert "Skip intel_crt_init for Dell XPS 8700"
Quoted 22 lines · Jani Nikula
Quoted 21 lines · Ville Syrjälä
Quoted 6 lines · Patchwork
== Series Details ==
Series: series starting with [1/3] Revert "Skip
intel_crt_initfor Dell XPS 8700"
URL : https://patchwork.freedesktop.org/series/12920/
State : warningQuoted 7 lines
== Summary ==
Series 12920v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/12920/revisions/1/mbox/Test
drv_module_reload_basic:pass -> SKIP (fi-skl-6770hq)rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
rmmod: ERROR: Module i915 is in use
Quoted 5 lines
Quoted 2 lines
This test has been a bit flaky historically, and the droppings aren't clear enough to pinpoint the fault.
I added more breadcrumbs to the test, but this was not run with those changes. :(
Specifically, I mean
832dfbc6e904 igt/drv_module_reload_basic: let intel_ips removal errors through 2085e1476e6e igt/drv_module_reload_basic: let snd_hda_intel removal errors through 8f3cf597e498 igt/drv_module_reload_basic: add helper for checking module reloaded
but IGT used here was
32b20211adf2 benchmarks: Add some missing .gitignore binaries
BR,
Jani.
Quoted 58 lines
BR,
Jani.Quoted 52 lines
Quoted 4 lines
Test
kms_flip:Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (fi-skl-6770hq)[ 521.531723] [drm:skl_set_cdclk] *ERROR* failed to inform PCU about cdclk changehttps://bugs.freedesktop.org/show_bug.cgi?id=97929
[ 521.541043] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe C FIFO underrunQuoted 3 lines
Test
kms_pipe_crc_basic:Subgroup nonblocking-crc-pipe-a: pass -> DMESG-WARN (fi-skl-6700k)[ 543.224512] [drm:intel_cpu_fifo_underrun_irq_handler] *ERROR* CPU pipe B FIFO underrunI'm going to chalk these up to SKL watermark problems.
Quoted 3 lines
Test
kms_psr_sink_crc:Subgroup psr_basic: pass -> DMESG-WARN (fi-skl-6700hq)[ 669.493504] [drm:intel_pipe_update_start] *ERROR* Potential atomic update failure on pipe AHas been happening all along. PSR+DMC messing about with vblank irqs/counters perhaps...
Nothing CRT output related in here, so I'm going to declare the patches as safe.
Quoted 22 lines
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22 fi-skl-6700k total:244 pass:218 dwarn:2 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:226 dwarn:2 dfail:0 fail:1 skip:15 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:206 dwarn:0 dfail:0 fail:0 skip:38Results at /archive/results/CI_IGT_test/Patchwork_2575/
34f3af78be52f23896926b7d41ca51d898c5224ddrm-intel-nightly: 2016y-09m-26d-09h-17m-56s UTC integration manifest 17b45ac drm/i915: Add spurious CRT DMI match for Intel DZ77BH-55K
4995164 drm/i915: Register shadow VGA even when it produces spurious detection results 113f2c3 Revert "Skipintel_crt_initfor Dell XPS 8700"
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · On Mon, Sep 26, 2016 at 12:20:44PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
This reverts commit
10b6ee4a87811a110cb01eaca01eb04da6801baf.According to [1] Dell XPS8700 VBT says '
int_crt_support0', so thanks to commite4abb733bb72("drm/i915: Check VBT for CRT port presence on HSW/BDW") we no longer need to blacklist it based on DMI.Looking through the bug report,
SFUSE_STRAPbased detection was apparently also tried and failed, but the VBT based one should still work just fine.
Quoted 8 lines
The commit says that the symptom was a frozen machine, but based on the bug report it doesn't look like the CRT detection was at least directly responsible for such a drastic outcome.
Cc: Giacomo Comes <[email protected]>
References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
References: http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]Signed-off-by Ville Syrjälä <[email protected]>
Seems all rather reasonable. On all 3 patches:
Quoted 30 lines
--- drivers/gpu/drm/i915/intel_crt.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/i915/intel_crt.c +0
-8@@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = { DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"), }, }, - { - .callback = intel_no_crt_dmi_callback, - .ident = "DELL XPS 8700", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), - DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"), - }, - }, { } };Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Daniel Vetter
Quoted 16 lines · On Mon, Sep 26, 2016 at 12:20:44PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
This reverts commit
10b6ee4a87811a110cb01eaca01eb04da6801baf.According to [1] Dell XPS8700 VBT says '
int_crt_support0', so thanks to commite4abb733bb72("drm/i915: Check VBT for CRT port presence on HSW/BDW") we no longer need to blacklist it based on DMI.Looking through the bug report,
SFUSE_STRAPbased detection was apparently also tried and failed, but the VBT based one should still work just fine.The commit says that the symptom was a frozen machine, but based on the bug report it doesn't look like the CRT detection was at least directly responsible for such a drastic outcome.
Quoted 8 lines
Quoted 4 lines
Cc: Giacomo Comes <[email protected]>
References: https://bugs.freedesktop.org/show_bug.cgi?id=73559
References: http://lists.freedesktop.org/archives/intel-gfx/2014-January/038178.html [1]Signed-off-by Ville Syrjälä <[email protected]>Seems all rather reasonable. On all 3 patches:
Reviewed-by Daniel Vetter <[email protected]>
Thanks. Series pushed to dinq.
Quoted 36 lines
Quoted 31 lines
--- drivers/gpu/drm/i915/intel_crt.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/i915/intel_crt.c +0
-8@@ -823,14 +823,6 @@ static const struct dmi_system_id intel_no_crt[] = { DMI_MATCH(DMI_PRODUCT_NAME, "ZGB"), }, }, - { - .callback = intel_no_crt_dmi_callback, - .ident = "DELL XPS 8700", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), - DMI_MATCH(DMI_PRODUCT_NAME, "XPS 8700"), - }, - }, { } };Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx