drm/i915: Keep track of active forcewake domains in a bitmask
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Keep track of active forcewake domains in a bitmask
From: Tvrtko Ursulin <[email protected]>
There are current places in the code, and there will be more in the future, which iterate the forcewake domains to find out which ones are currently active.
To save them from doing this iteration, we can cheaply keep a mask of active domains in dev_priv->uncore.fw_domains_active.
This has no cost in terms of object size, even manages to shrink it overall by 368 bytes on my config.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_uncore.c | 54 ++++++++++++++++--------------------- 2 files changed, 25 insertions(+), 31 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -588,7 +588,9 @@ struct intel_uncore {struct intel_uncore_funcs funcs;unsigned fifo_count; +enum forcewake_domains fw_domains; +enum forcewake_domains fw_domains_active;struct intel_uncore_forcewake_domain {struct drm_i915_private *i915;
drivers/gpu/drm/i915/intel_uncore.c +23 -31
116 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
There are current places in the code, and there will be more in the future, which iterate the forcewake domains to find out which ones are currently active.
Quoted 8 lines
To save them from doing this iteration, we can cheaply keep a mask of active domains in
dev_priv->uncore.fw_domains_active.This has no cost in terms of object size, even manages to shrink it overall by 368 bytes on my config.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc "Paneri, Praveen" <[email protected]>
Looks solid and should not run afoul of the games played during reset or suspend.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Chris Wilson
Quoted 12 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
There are current places in the code, and there will be more in the future, which iterate the forcewake domains to find out which ones are currently active.
To save them from doing this iteration, we can cheaply keep a mask of active domains in
dev_priv->uncore.fw_domains_active.This has no cost in terms of object size, even manages to shrink it overall by 368 bytes on my config.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc "Paneri, Praveen" <[email protected]>Looks solid and should not run afoul of the games played during reset or suspend.
Reviewed-by Chris Wilson <[email protected]>
Thanks!
Praveen, you can see if this patch would help for your decoupled MMIO patches, and if you like it you can incrorporate it in your series if you want?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Tvrtko Ursulin
Quoted 18 lines · Chris Wilson
Quoted 6 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
There are current places in the code, and there will be more in the future, which iterate the forcewake domains to find out which ones are currently active.
Quoted 8 lines
To save them from doing this iteration, we can cheaply keep a mask of active domains in
dev_priv->uncore.fw_domains_active.This has no cost in terms of object size, even manages to shrink it overall by 368 bytes on my config.
Signed-off-by Tvrtko Ursulin <[email protected]>Cc "Paneri, Praveen" <[email protected]>Looks solid and should not run afoul of the games played during reset or suspend.
Quoted 7 lines
Quoted 1 line
Reviewed-by Chris Wilson <[email protected]>Thanks!
Praveen, you can see if this patch would help for your decoupled MMIO patches, and if you like it you can incrorporate it in your series if you want?
Thanks for the patch Tvrtko! I can definitely use it :)
Quoted 5 lines
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915: Keep track of active forcewake domains in a bitmask
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Keep track of active forcewake domains in a bitmask
URL : https://patchwork.freedesktop.org/series/12960/
State : warning
== Summary ==
Series 12960v1 drm/i915: Keep track of active forcewake domains in a bitmask
https://patchwork.freedesktop.org/api/1.0/series/12960/revisions/1/mbox/
Test kms_psr_sink_crc:
Subgroup psr_basic:
pass -> DMESG-WARN (fi-skl-6700hq)
Test pm_rpm:
Subgroup basic-pci-d3-state:
dmesg-warn -> PASS (fi-skl-6770hq)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:244 pass:213 dwarn:0 dfail:0 fail:1 skip:30 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-hsw-4770r total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:244 pass:182 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:1 dfail:0 fail:0 skip:22 fi-skl-6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:228 dwarn:1 dfail:0 fail:1 skip:14 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2581/
67a915c510e83bc3892361db0d85a94275f05359 drm-intel-nightly: 2016y-09m-27d-11h-21m-20s UTC integration manifest 6e81cfc drm/i915: Keep track of active forcewake domains in a bitmask
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx