Skip to contentSkip to conversation

kernel/zram: Fix testcase for kernels >= v4.7

PATCH New Cyril Hrubis 2 participants 3 messages Sep 27, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 kernel/zram: Fix testcase for kernels >= v4.7

Hi!

Quoted 17 lines

max_comp_streams is depreciated in kernels >= v4.7, bail instead of failing.

---
 testcases/kernel/device-drivers/zram/zram_lib.sh | 8 ++++++++
 1 file changed, 8 insertions(+)
testcases/kernel/device-drivers/zram/zram_lib.sh +1 -0
index d3e62e0dff43..2144227df001 100755
@@ -62,6 +62,14 @@ zram_load()
 
 zram_max_streams()
 {
+	tst_kvercmp 4 7 0

testcases/kernel/device-drivers/zram/zram_lib.sh zram_load() · line 75

Quoted 10 lines
testcases/kernel/device-drivers/zram/zram_lib.sh +7 -0
+	if [ $? -gt 0 ]; then
+		tst_resm TCONF "device attribute max_comp_streams is"\
+			"depriciated since kernel v4.7, the running kernel"\
+			"does not support it"
+		return
+	fi
+
 	tst_kvercmp 3 15 0
 	if [ $? -eq 0 ]; then
 		tst_resm TCONF "device attribute max_comp_streams is"\

Pushed, thanks.

BTW: The LTP mailing list is for quite some time hosted at
lists.linux.it. And all places in documentation should have been fixed to point to it. Where did you find the old address?

Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 kernel/zram: Fix testcase for kernels >= v4.7

Quoted 4 lines · Cyril Hrubis

BTW: The LTP mailing list is for quite some time hosted at
lists.linux.it. And all places in documentation should have been fixed to point to it. Where did you find the old address?

Copy/pasted from a google search.

#3 lore raw

PATCH 1/1 kernel/zram: Fix testcase for kernels >= v4.7

Hi!

Quoted 6 lines
Quoted 4 lines

BTW: The LTP mailing list is for quite some time hosted at
lists.linux.it. And all places in documentation should have been fixed to point to it. Where did you find the old address?

Copy/pasted from a google search.

Hmm, that's not something I can fix :(

And FYI we even have up to date record in MAINTAINERS file, you can grep it for "ltp" next time...

Signature · 2 lines
Cyril Hrubis
[email protected]