Patch "mac80211: reject TSPEC TIDs (TSIDs) for aggregation" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
mac80211: reject TSPEC TIDs (TSIDs) for aggregation
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mac80211-reject-tspec-tids-tsids-for-aggregation.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
85d5313ed717ad60769491c7c072d23bc0a68e7aMon Sep 17 00:00:00 2001
From: Johannes Berg <[email protected]>
Date: Wed, 14 Sep 2016 11:38:31 +0200
Subject: mac80211: reject TSPEC TIDs (TSIDs) for aggregation
From: Johannes Berg <[email protected]>
commit 85d5313ed717ad60769491c7c072d23bc0a68e7a upstream.
Since mac80211 doesn't currently support TSIDs 8-15 which can only be used after QoS TSPEC negotiation (and not even after WMM negotiation), reject attempts to set up aggregation sessions for them, which might confuse drivers. In mac80211 we do correctly handle that, but the TSIDs should never get used anyway, and drivers might not be able to handle it.
--- net/mac80211/agg-rx.c | 8 +++++++- net/mac80211/agg-tx.c | 3 +++ 2 files changed, 10 insertions(+), 1 deletion(-)
net/mac80211/agg-rx.c +7 -1
@@ -261,10 +261,16 @@ void __ieee80211_start_rx_ba_session(str .timeout = timeout, .ssn = start_seq_num, }; -int i, ret = -EOPNOTSUPP ;u16 status =WLAN_STATUS_REQUEST_DECLINED ; +if (tid >=IEEE80211_FIRST_TSPEC_TSID ) { +ht_dbg (sta->sdata, +"STA %pM requests BA session on unsupported tid %d\n" , + sta->sta.addr, tid); + goto end_no_lock; + } +if (!sta->sta.ht_cap.ht_supported) { ht_dbg(sta->sdata, "STA %pM erroneously requests BA session on tid %d w/o QoS\n",
net/mac80211/agg-tx.c +3 -0
@@ -580,6 +580,9 @@ int ieee80211_start_tx_ba_session(struct ieee80211_hw_check(&local->hw, TX_AMPDU_SETUP_IN_HW))return -EINVAL ; +if (WARN_ON (tid >=IEEE80211_FIRST_TSPEC_TSID )) +return -EINVAL ; +ht_dbg (sdata,"Open BA session requested for %pM tid %u\n" , pubsta->addr, tid);
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/nl80211-validate-number-of-probe-response-csa-counters.patch queue-4.7/mac80211-reject-tspec-tids-tsids-for-aggregation.patch