Skip to contentSkip to conversation

mkefidisk.wks: use partition UUID and GPT partition table

PATCH NAK Ed Bartosh 2 participants 2 messages Sep 30, 2016 – Oct 2, 2016

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 mkefidisk.wks: use partition UUID and GPT partition table

This is a preparation to use mkefidisk as a default wks for genericx86* BSPs. This change enables usage of partition UUID instead of device name to specify root partition in kernel command line. It should make images to boot on devices with boot device names that differ from what's mentioned in wks file.

Signed-off-by Ed Bartosh <[email protected]>
---
 scripts/lib/wic/canned-wks/mkefidisk.wks | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/lib/wic/canned-wks/mkefidisk.wks +2 -2
index 696e94e..73886ab 100644
@@ -4,8 +4,8 @@
 
 part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active --align 1024
 
-part / --source rootfs --ondisk sda --fstype=ext4 --label platform --align 1024
+part / --source rootfs --ondisk sda --fstype=ext4 --label platform --align 1024 --use-uuid
 
 part swap --ondisk sda --size 44 --label swap1 --fstype=swap
 
-bootloader  --timeout=10  --append="rootwait rootfstype=ext4 console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda-intel.enable_msi=0"
+bootloader --ptable gpt --timeout=10 --append="rootwait rootfstype=ext4 console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda-intel.enable_msi=0"
Signature · 1 line
2.1.4
NAK
#1 lore raw
Quoted 26 lines · Ed Bartosh

This is a preparation to use mkefidisk as a default wks for genericx86* BSPs. This change enables usage of partition UUID instead of device name to specify root partition in kernel command line. It should make images to boot on devices with boot device names that differ from what's mentioned in wks file.

Signed-off-by Ed Bartosh <[email protected]>

---
 scripts/lib/wic/canned-wks/mkefidisk.wks | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/lib/wic/canned-wks/mkefidisk.wks +0 -0
index 696e94e..73886ab 100644
@@ -4,8 +4,8 @@


 part /boot --source bootimg-efi --sourceparams="loader=grub-efi" -- ondisk sda --label msdos --active --align 1024

scripts/lib/wic/canned-wks/mkefidisk.wks +1 -3
-part / --source rootfs --ondisk sda --fstype=ext4 --label platform
--align 1024
+part / --source rootfs --ondisk sda --fstype=ext4 --label platform
--align 1024 --use-uuid

Quoted 8 lines

 part swap --ondisk sda --size 44 --label swap1 --fstype=swap
-bootloader  --timeout=10  --append="rootwait rootfstype=ext4 console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda- intel.enable_msi=0"
+bootloader --ptable gpt --timeout=10 --append="rootwait rootfstype=ext4 console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda-intel.enable_msi=0"

NAK!

Not all devices can handle GPT correct it seems, I can't use this version to boot a Turobot for example, where is was usable before.

The use-uuid works.

Sau!

Quoted 3 lines

--
2.1.4