Skip to contentSkip to conversation

i915/GuC: Make GuC loads default

PATCH In review Anusha Srivatsa 5 participants 7 messages Oct 5, 2016 – Oct 31, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915/GuC: Make GuC loads default

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter. Once the issues around GuC submission is resolved it is intended to make it default as well.

It is now safe to make GuC loads default.

---
 drivers/gpu/drm/i915/i915_params.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +2 -2
index 768ad89..256a512 100644
@@ -55,7 +55,7 @@ struct i915_params i915 __read_mostly = {
 	.verbose_state_checks = 1,
 	.nuclear_pageflip = 0,
 	.edp_vswing = 0,
-	.enable_guc_loading = 0,
+	.enable_guc_loading = -1,
 	.enable_guc_submission = 0,
 	.guc_log_level = -1,
 	.enable_dp_mst = true,
@@ -209,7 +209,7 @@ MODULE_PARM_DESC(edp_vswing,
 module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400);
 MODULE_PARM_DESC(enable_guc_loading,
 		"Enable GuC firmware loading "
-		"(-1=auto, 0=never [default], 1=if available, 2=required)");
+		"(-1=auto [default], 0=never, 1=if available, 2=required )");
 
 module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400);
 MODULE_PARM_DESC(enable_guc_submission,
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: warning for i915/GuC: Make GuC loads default

== Series Details ==

== Series Details ==

Series: i915/GuC: Make GuC loads default
URL : https://patchwork.freedesktop.org/series/13356/
State : warning

== Summary ==

Series 13356v1 i915/GuC: Make GuC loads default
https://patchwork.freedesktop.org/api/1.0/series/13356/revisions/1/mbox/

Test drv_module_reload_basic:

                pass       -> SKIP       (fi-skl-6260u)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-b:
                pass       -> DMESG-WARN (fi-skl-6770hq)
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-byt-j1900)
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                pass       -> DMESG-WARN (fi-skl-6700hq)
fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:202  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:244  pass:214  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:244  pass:211  dwarn:1   dfail:0   fail:1   skip:31 
fi-byt-n2820     total:244  pass:208  dwarn:0   dfail:0   fail:1   skip:35 
fi-hsw-4770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ilk-650       total:244  pass:182  dwarn:0   dfail:0   fail:2   skip:60 
fi-ivb-3520m     total:244  pass:219  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:244  pass:207  dwarn:0   dfail:0   fail:0   skip:37 
fi-kbl-7200u     total:244  pass:220  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-skl-6700hq    total:244  pass:221  dwarn:1   dfail:0   fail:0   skip:22 
fi-skl-6700k     total:244  pass:219  dwarn:1   dfail:0   fail:0   skip:24 
fi-skl-6770hq    total:244  pass:227  dwarn:2   dfail:0   fail:1   skip:14 
fi-snb-2520m     total:244  pass:208  dwarn:0   dfail:0   fail:0   skip:36 
fi-snb-2600      total:244  pass:207  dwarn:0   dfail:0   fail:0   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_2633/

2dff18acaa95a26b882a5f9910d7ded514f18415 drm-intel-nightly: 2016y-10m-05d-13h-58m-08s UTC integration manifest dd07634 i915/GuC: Make GuC loads default

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Anusha Srivatsa
Quoted 7 lines · Anusha Srivatsa

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter. Once the issues around GuC submission is resolved it is intended to make it default as well.

<broken record>Why is this even a separate parameter?</> -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 10 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Wednesday, October 5, 2016 11:57 PM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:

Quoted 8 lines
Quoted 6 lines

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter.
Once the issues around GuC submission is resolved it is intended to make it default as well.

<broken record>Why is this even a separate parameter?</> -Chris

It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function.

Anusha

Quoted 2 lines

--
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#4 lore raw

I also asked that same question many times. Maybe they can be unified later when we enable submission by default, but right now I believe this is the way to go, so

Quoted 28 lines · Anusha
Quoted 10 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Wednesday, October 5, 2016 11:57 PM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:

Quoted 8 lines
Quoted 6 lines

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter.
Once the issues around GuC submission is resolved it is intended to make it default as well.

<broken record>Why is this even a separate parameter?</> -Chris

It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function.

Anusha

Quoted 2 lines

--
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

Could someone please ack this? We need this before getting HuC.

GuC submission has regressions so the submission is not getting enabled. But we need to have GuC loaded to be able to use HuC.

Thanks,
Rodrigo.

Quoted 43 lines · Rodrigo Vivi

I also asked that same question many times. Maybe they can be unified later when we enable submission by default, but right now I believe this is the way to go, so

Quoted 21 lines · Anusha
Quoted 10 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Wednesday, October 5, 2016 11:57 PM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:

Quoted 8 lines
Quoted 6 lines

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter.
Once the issues around GuC submission is resolved it is intended to make it default as well.

<broken record>Why is this even a separate parameter?</> -Chris

It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function.

Quoted 7 lines

Anusha

Quoted 2 lines

--
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by
#6 lore raw

I agree that the parameter controls could use a clean-up, which could include eventual removal of the enable_guc_loading parameter. But for now loading parameter should be auto by default.

Might be a good idea to temporarily set the has_guc parameter to 0 for BXT and KBL since those firmwares have not yet been made available (I don't see them on 01.org).

In either case...

Quoted 49 lines · Rodrigo Vivi

Could someone please ack this? We need this before getting HuC.

GuC submission has regressions so the submission is not getting enabled. But we need to have GuC loaded to be able to use HuC.

Thanks,
Rodrigo.

Quoted 40 lines · Rodrigo Vivi

I also asked that same question many times. Maybe they can be unified later when we enable submission by default, but right now I believe this is the way to go, so

Quoted 28 lines · Anusha
Quoted 10 lines

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Wednesday, October 5, 2016 11:57 PM
To: Srivatsa, Anusha <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:

Quoted 8 lines
Quoted 6 lines

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly.
Also, note that GuC submission is not made default and still needs to be given as a kernel parameter.
Once the issues around GuC submission is resolved it is intended to make it default as well.

<broken record>Why is this even a separate parameter?</> -Chris

It is a separate parameter because HuC requires GuC to be loaded. It is ok if command submission is not happening through GuC but GuC "has to" be loaded for HuC to function. Guc_submission parameter enables the command submission through GUC. But, guc_loading parameter ensures not only that the GuC is loaded but also that HuC can now function.

Anusha

Quoted 2 lines

--
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 13 lines
Quoted 3 lines

--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx