Skip to contentSkip to conversation

Remove unused HIDDEN gcc attribute

PATCH New Leon Romanovsky 1 participant 1 message Oct 6, 2016 InfiniBand

lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

PATCH 1/1 Remove unused HIDDEN gcc attribute

The attribute HIDDEN was declared in almost every provider, but it wasn't used, except in libibverbs. This attribute is configured by linker map now and can be safely removed.

Signed-off-by Leon Romanovsky <[email protected]>
Reviewed-by Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

---
Changelog v0->v1:
* Add Jason's RB tag
* Remove hidden parameter from libibverbs too
* Improve commit message

---
 libhfi1verbs/src/hfiverbs.h    | 2 --
 libi40iw/src/i40iw_umain.h     | 2 --
 libibverbs/src/ibverbs.h       | 6 ++----
 libibverbs/src/init.c          | 4 ++--
 libipathverbs/src/ipathverbs.h | 2 --
 libmlx4/src/mlx4.h             | 2 --
 libmlx5/src/mlx5.h             | 2 --
 libmthca/src/mthca.h           | 2 --
 libnes/src/nes_umain.h         | 2 --
 9 files changed, 4 insertions(+), 20 deletions(-)
libhfi1verbs/src/hfiverbs.h +0 -2
index deebc65..e82ba2b 100644
@@ -67,8 +67,6 @@
 #include <infiniband/arch.h>
 #include <infiniband/verbs.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"hfi1: "
 
 struct hfi1_device {
libi40iw/src/i40iw_umain.h +0 -2
index 13d3da8..719aefc 100644
@@ -54,8 +54,6 @@
 #define unlikely(x) __builtin_expect((x), 0)
 #endif
 
-#define HIDDEN __attribute__((visibility("hidden")))
-
 #define PFX "libi40iw-"
 
 #define  I40IW_BASE_PUSH_PAGE	1
libibverbs/src/ibverbs.h +2 -4
index a01dff2..dd2dacf 100644
@@ -40,8 +40,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define INIT		__attribute__((constructor))
 #define FINI		__attribute__((destructor))
 

@@ -58,9 +56,9 @@ struct ibv_abi_compat_v2 {
 	pthread_mutex_t		in_use;
 };
 
-extern HIDDEN int abi_ver;
+extern int abi_ver;
 
-HIDDEN int ibverbs_init(struct ibv_device ***list);
+int ibverbs_init(struct ibv_device ***list);
 
 struct verbs_ex_private {
 	struct ibv_cq_ex *(*create_cq_ex)(struct ibv_context *context,
libibverbs/src/init.c +2 -2
index 7797569..03f3c42 100644
@@ -48,7 +48,7 @@
 
 #include "ibverbs.h"
 
-HIDDEN int abi_ver;
+int abi_ver;
 
 struct ibv_sysfs_dev {
 	char		        sysfs_name[IBV_SYSFS_NAME_MAX];

@@ -498,7 +498,7 @@ static void add_device(struct ibv_device *dev,
 	(*dev_list)[(*num_devices)++] = dev;
 }
 
-HIDDEN int ibverbs_init(struct ibv_device ***list)
+int ibverbs_init(struct ibv_device ***list)
 {
 	const char *sysfs_path;
 	struct ibv_sysfs_dev *sysfs_dev, *next_dev;
libipathverbs/src/ipathverbs.h +0 -2
index 05e1c71..ff25854 100644
@@ -47,8 +47,6 @@
 #include <infiniband/arch.h>
 #include <infiniband/verbs.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"ipath: "
 
 struct ipath_device {
libmlx4/src/mlx4.h +0 -2
index 1855cfb..95a6521 100644
@@ -49,8 +49,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"mlx4: "
 
 enum {
libmlx5/src/mlx5.h +0 -2
index c209a79..f8674c7 100644
@@ -54,8 +54,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility("hidden")))
-
 #ifdef HAVE_FUNC_ATTRIBUTE_ALWAYS_INLINE
 #define ALWAYS_INLINE __attribute__((always_inline))
 #else
libmthca/src/mthca.h +0 -2
index da53010..b4b0b6a 100644
@@ -41,8 +41,6 @@
 
 #include <valgrind/memcheck.h>
 
-#define HIDDEN		__attribute__((visibility ("hidden")))
-
 #define PFX		"mthca: "
 
 enum mthca_hca_type {
libnes/src/nes_umain.h +0 -2
index 9129982..f3cc348 100644
@@ -48,8 +48,6 @@
 #define unlikely(x) __builtin_expect((x),0)
 #endif
 
-#define HIDDEN __attribute__((visibility ("hidden")))
-
 #define PFX	"libnes: "
 
 #define  NES_QP_MMAP		1

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html