Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

PATCH In review Nadim Almas 3 participants 5 messages Oct 5, 2016 – Oct 6, 2016 Staging

lore

Share & tools

lore

Nadim Almas

author

2016-10-05 21:54 UTC #0 lore raw

PATCH 1/1 Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

Fixed coding style issue

Signed-off-by Nadim Almas <[email protected]>

---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

drivers/staging/dgnc/dgnc_neo.h +12 -6

index abddd48..65994e3 100644
@@ -30,7 +30,8 @@
 struct neo_uart_struct {
 	u8 txrx;		/* WR  RHR/THR - Holding Reg */
 	u8 ier;		/* WR  IER - Interrupt Enable Reg */
-	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+									/*Reg */
 	u8 lcr;		/* WR  LCR - Line Control Reg */
 	u8 mcr;		/* WR  MCR - Modem Control Reg */
 	u8 lsr;		/* WR  LSR - Line Status Reg */

@@ -108,7 +109,8 @@ struct neo_uart_struct {
 /* 17158 Extended IIR's */
 #define UART_17158_IIR_RDI_TIMEOUT	0x0C	/* Receiver data TIMEOUT */
 #define UART_17158_IIR_XONXOFF		0x10	/* Received an XON/XOFF char */
-#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20	/* CTS/DSR or RTS/DTR state change */
+#define UART_17158_IIR_HWFLOW_STATE_CHANGE 0x20	/* CTS/DSR or RTS/DTR state */
+								/* change */
 #define UART_17158_IIR_FIFO_ENABLED	0xC0	/* 16550 FIFOs are Enabled */
 
 /*

@@ -119,8 +121,10 @@ struct neo_uart_struct {
 #define UART_17158_RXRDY_TIMEOUT	0x2	/* RX Ready Timeout */
 #define UART_17158_TXRDY		0x3	/* TX Ready */
 #define UART_17158_MSR			0x4	/* Modem State Change */
-#define UART_17158_TX_AND_FIFO_CLR	0x40	/* Transmitter Holding Reg Empty */
-#define UART_17158_RX_FIFO_DATA_ERROR	0x80	/* UART detected an RX FIFO Data error */
+#define UART_17158_TX_AND_FIFO_CLR	0x40	/* Transmitter Holding Reg */
+								/* Empty */
+#define UART_17158_RX_FIFO_DATA_ERROR	0x80	/* UART detected an RX FIFO */
+								/* Data error */
 
 /*
  * These are the EXTENDED definitions for the 17C158's Interrupt

@@ -132,8 +136,10 @@ struct neo_uart_struct {
 #define UART_17158_EFR_RTSDTR	0x40	/* Auto RTS/DTR Flow Control Enable */
 #define UART_17158_EFR_CTSDSR	0x80	/* Auto CTS/DSR Flow COntrol Enable */
 
-#define UART_17158_XOFF_DETECT	0x1	/* Indicates whether chip saw an incoming XOFF char  */
-#define UART_17158_XON_DETECT	0x2	/* Indicates whether chip saw an incoming XON char */
+#define UART_17158_XOFF_DETECT	0x1	/* Indicates whether chip saw an */
+						/* incoming XOFF char  */
+#define UART_17158_XON_DETECT	0x2	/* Indicates whether chip saw an */
+							/* incoming XON char */
 
 #define UART_17158_IER_RSVD1	0x10	/* Reserved by Exar */
 #define UART_17158_IER_XOFF	0x20	/* Xoff Interrupt Enable */

Signature · 1 line

2.7.4

Greg KH

maintainer

2016-10-06 05:21 UTC #1 lore raw

Quoted 12 lines · Nadim Almas

Fixed coding style issue
Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/dgnc/dgnc_neo.h +0 -0
index abddd48..65994e3 100644

drivers/staging/dgnc/dgnc_neo.h line 34

Quoted 6 lines

drivers/staging/dgnc/dgnc_neo.h +2 -1

@@ -30,7 +30,8 @@
 struct neo_uart_struct {
 	u8 txrx;		/* WR  RHR/THR - Holding Reg */
 	u8 ier;		/* WR  IER - Interrupt Enable Reg */
-	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+	u8 isr_fcr;	/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+									/*Reg */

Does that really look better now than it did before?

I don't think so :(

sorry,

greg k-h

Nadim Almas

author

2016-10-06 08:22 UTC #2 lore raw

May be it is not looking better than yours but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend

Quoted 27 lines · Greg KH

Quoted 12 lines · Nadim Almas

Fixed coding style issue
Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/dgnc/dgnc_neo.h +0 -0
index abddd48..65994e3 100644

drivers/staging/dgnc/dgnc_neo.h line 34

Quoted 6 lines

drivers/staging/dgnc/dgnc_neo.h +2 -1

@@ -30,7 +30,8 @@
 struct neo_uart_struct {
      u8 txrx;                /* WR  RHR/THR - Holding Reg */
      u8 ier;         /* WR  IER - Interrupt Enable Reg */
-     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+                                                                     /*Reg */

Does that really look better now than it did before?

I don't think so :(

sorry,

greg k-h

May be it is not looking better than it did before but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend
than why it is not acceptable

Quoted 32 lines · Nadim Almas

May be it is not looking better than yours but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend
Quoted 27 lines · Greg KH
Quoted 12 lines · Nadim Almas
Fixed coding style issue
Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/staging/dgnc/dgnc_neo.h +0 -0
index abddd48..65994e3 100644
drivers/staging/dgnc/dgnc_neo.h line 34
Quoted 6 lines
drivers/staging/dgnc/dgnc_neo.h +2 -1
@@ -30,7 +30,8 @@
 struct neo_uart_struct {
      u8 txrx;                /* WR  RHR/THR - Holding Reg */
      u8 ier;         /* WR  IER - Interrupt Enable Reg */
-     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+                                                                     /*Reg */
Does that really look better now than it did before?
I don't think so :(
sorry,
greg k-h

Joe Perches

2016-10-06 16:00 UTC #4 lore raw

Quoted 4 lines · Nadim Almas

May be it is not looking better than it did before but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend
than why it is not acceptable

(please don't top post)

Because it's ugly and checkpatch output messages are not dicta.

If this is really useful, realign all the comments to start on the same column.

more below...

Quoted 14 lines · Nadim Almas

Quoted 13 lines
May be it is not looking better than yours but it removed 6 warning of the file which is shown by running "perl scripts/checkpatch.pl -f drivers/staging/dgnc/* | less" commend
Quoted 8 lines · Greg KH
Quoted 7 lines · Nadim Almas
Fixed coding style issue
Signed-off-by Nadim Almas <[email protected]>
---
 drivers/staging/dgnc/dgnc_neo.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

Quoted 11 lines

drivers/staging/dgnc/dgnc_neo.h line 34

Quoted 11 lines

drivers/staging/dgnc/dgnc_neo.h +2 -1

index abddd48..65994e3 100644
@@ -30,7 +30,8 @@
 struct neo_uart_struct {O
      u8 txrx;                /* WR  RHR/THR - Holding Reg */
      u8 ier;         /* WR  IER - Interrupt Enable Reg */
-     u8 isr_fcr;             /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
+     u8 isr_fcr;     /* WR  ISR/FCR - Interrupt Status Reg/Fifo Control */
+                                                                     /*Reg */

Consider

12345678901234567890123456789012345678901234567890123456789012345678901234567890

struct neo_uart_struct {
u8 txrx; /* WR RHR/THR - Holding Reg */
u8 ier; /* WR IER - Interrupt Enable Reg */
u8 isr_fcr; /* WR ISR/FCR - Interrupt Status & Fifo Control Reg */

struct neo_uart_struct {
u8 txrx; /* WR RHR/THR - Holding Reg */
u8 ier; /* WR IER - Interrupt Enable Reg */
u8 isr_fcr; /* WR ISR/FCR - Interrupt Status Reg and
* Fifo Control Reg
*/

struct neo_uart_struct {
u8 txrx; // WR RHR/THR - Holding Reg
u8 ier; // WR IER - Interrupt Enable Reg
u8 isr_fcr; // WR ISR/FCR - Interrupt Status/Fifo Control Reg