Skip to contentSkip to conversation

bootm: fix ramdisk relocation

RFC PATCH New Cédric Le Goater 2 participants 3 messages Oct 6, 2016 – Oct 9, 2016

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 bootm: fix ramdisk relocation

We are working on bringing to mainline a set of changes adding support for the Aspeed SoC and we have a couple of work around we are trying to elimitate first. This is one of them. The ramdisk is not relocated and Linux fails to boot. The current port does not use a device tree (yet) so that might be the most obvious culprit.

Thanks

---
 cmd/bootm.c |    3 +++
 1 file changed, 3 insertions(+)
cmd/bootm.c +3 -0
Index: u-boot-v2016.09-aspeed-openbmc.git/cmd/bootm.c
===================================================================
@@ -126,6 +126,9 @@ int do_bootm(cmd_tbl_t *cmdtp, int flag,
 	return do_bootm_states(cmdtp, flag, argc, argv, BOOTM_STATE_START |
 		BOOTM_STATE_FINDOS | BOOTM_STATE_FINDOTHER |
 		BOOTM_STATE_LOADOS |
+#ifdef CONFIG_SYS_BOOT_RAMDISK_HIGH
+		BOOTM_STATE_RAMDISK |
+#endif
 #if defined(CONFIG_PPC) || defined(CONFIG_MIPS)
 		BOOTM_STATE_OS_CMDLINE |
 #endif
#1 lore raw

RFC PATCH 1/1 bootm: fix ramdisk relocation

Quoted 9 lines · C?dric Le Goater

We are working on bringing to mainline a set of changes adding support for the Aspeed SoC and we have a couple of work around we are trying to elimitate first. This is one of them. The ramdisk is not relocated and Linux fails to boot. The current port does not use a device tree (yet) so that might be the most obvious culprit.

Thanks

I suspect that you want to have bootm_size set in your environment so that all relocations happen within that value and will remain visible to the kernel.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161008/41d5fb0c/attachment.sig>
#2 lore raw

RFC PATCH 1/1 bootm: fix ramdisk relocation

Hello,

Quoted 8 lines · Tom Rini
Quoted 6 lines · C?dric Le Goater

We are working on bringing to mainline a set of changes adding support for the Aspeed SoC and we have a couple of work around we are trying to elimitate first. This is one of them. The ramdisk is not relocated and Linux fails to boot. The current port does not use a device tree (yet) so that might be the most obvious culprit.

Quoted 7 lines
Quoted 3 lines

Thanks

I suspect that you want to have bootm_size set in your environment so that all relocations happen within that value and will remain visible to the kernel.

Well, I am discovering the code so I might be wrong in the way it should be used.

boot_ramdisk_high() does the copy to ram and relocation but it is not called as we are booting using ATAGS and a legacy image. This patch enables the copy but even in that case the load address of the image is not used, which can be a problem for the linux memblocks after boot.

So I am wondering if we should put some effort to fix this scenario. Or is it totally wrong and in that case, should we be using some other mechanism ?

Thanks,

C.