IB/hfi1: Prevent NULL pointer deferences in caching code

Hello Mitko Haralanov,

The patch f19bd643dbde: "IB/hfi1: Prevent NULL pointer deferences in caching code" from Apr 12, 2016, leads to the following static checker warning:

	drivers/infiniband/hw/hfi1/user_sdma.c:1147 pin_vector_pages()
	warn: 'rb_node' isn't an ERR_PTR

drivers/infiniband/hw/hfi1/user_sdma.c
1135 static int pin_vector_pages(struct user_sdma_request *req,
1136 struct user_sdma_iovec *iovec)
1137 {

  1138          int ret = 0, pinned, npages, cleared;
  1139          struct page **pages;
  1140          struct hfi1_user_sdma_pkt_q *pq = req->pq;
  1141          struct sdma_mmu_node *node = NULL;
  1142          struct mmu_rb_node *rb_node;
  1143  
  1144          rb_node = hfi1_mmu_rb_extract(pq->handler,
  1145                                        (unsigned long)iovec->iov.iov_base,
  1146                                        iovec->iov.iov_len);
  1147          if (rb_node && !IS_ERR(rb_node))
                                ^^^^^^^^^^^^^^^

hfi1_mmu_rb_extract() never returns error pointers. Plz delete.

  1148                  node = container_of(rb_node, struct sdma_mmu_node, rb);
  1149          else
  1150                  rb_node = NULL;
  1151  
  1152          if (!node) {
  1153                  node = kzalloc(sizeof(*node), GFP_KERNEL);
  1154                  if (!node)
  1155                          return -ENOMEM;
  1156  
  1157                  node->rb.addr = (unsigned long)iovec->iov.iov_base;
  1158                  node->pq = pq;
  1159                  atomic_set(&node->refcount, 0);
  1160          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

VGhhbmtzIERhbiwgd2UnbGwgdGFrZSBjYXJlIG9mIGl0Lg0KDQotRGVubnkNCg0KT24gV2VkLCAy MDE2LTEwLTEyIGF0IDA5OjA2ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0KPiBIZWxsbyBN aXRrbyBIYXJhbGFub3YsDQo+IA0KPiBUaGUgcGF0Y2ggZjE5YmQ2NDNkYmRlOiAiSUIvaGZpMTog UHJldmVudCBOVUxMIHBvaW50ZXIgZGVmZXJlbmNlcyBpbg0KPiBjYWNoaW5nIGNvZGUiIGZyb20g QXByIDEyLCAyMDE2LCBsZWFkcyB0byB0aGUgZm9sbG93aW5nIHN0YXRpYw0KPiBjaGVja2VyIHdh cm5pbmc6DQo+IA0KPiAJZHJpdmVycy9pbmZpbmliYW5kL2h3L2hmaTEvdXNlcl9zZG1hLmM6MTE0 NyBwaW5fdmVjdG9yX3BhZ2VzKCkNCj4gCXdhcm46ICdyYl9ub2RlJyBpc24ndCBhbiBFUlJfUFRS DQo+IA0KPiBkcml2ZXJzL2luZmluaWJhbmQvaHcvaGZpMS91c2VyX3NkbWEuYw0KPiDCoCAxMTM1 wqDCoHN0YXRpYyBpbnQgcGluX3ZlY3Rvcl9wYWdlcyhzdHJ1Y3QgdXNlcl9zZG1hX3JlcXVlc3Qg KnJlcSwNCj4gwqAgMTEzNsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCB1c2VyX3NkbWFfaW92ZWMgKmlvdmVjKQ0KPiDCoCAx MTM3wqDCoHsNCj4gwqAgMTEzOMKgwqDCoMKgwqDCoMKgwqDCoMKgaW50IHJldCA9IDAsIHBpbm5l ZCwgbnBhZ2VzLCBjbGVhcmVkOw0KPiDCoCAxMTM5wqDCoMKgwqDCoMKgwqDCoMKgwqBzdHJ1Y3Qg cGFnZSAqKnBhZ2VzOw0KPiDCoCAxMTQwwqDCoMKgwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgaGZpMV91 c2VyX3NkbWFfcGt0X3EgKnBxID0gcmVxLT5wcTsNCj4gwqAgMTE0McKgwqDCoMKgwqDCoMKgwqDC oMKgc3RydWN0IHNkbWFfbW11X25vZGUgKm5vZGUgPSBOVUxMOw0KPiDCoCAxMTQywqDCoMKgwqDC oMKgwqDCoMKgwqBzdHJ1Y3QgbW11X3JiX25vZGUgKnJiX25vZGU7DQo+IMKgIDExNDPCoMKgDQo+ IMKgIDExNDTCoMKgwqDCoMKgwqDCoMKgwqDCoHJiX25vZGUgPSBoZmkxX21tdV9yYl9leHRyYWN0 KHBxLT5oYW5kbGVyLA0KPiDCoCAxMTQ1wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAodW5zaWduZWQg bG9uZylpb3ZlYy0NCj4gPmlvdi5pb3ZfYmFzZSwNCj4gwqAgMTE0NsKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgaW92ZWMtPmlvdi5pb3ZfbGVuKTsNCj4gwqAgMTE0N8KgwqDCoMKgwqDCoMKgwqDCoMKg aWYgKHJiX25vZGUgJiYgIUlTX0VSUihyYl9ub2RlKSkNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoF5eXl5eXl5eXl5eXl5e Xg0KPiANCj4gaGZpMV9tbXVfcmJfZXh0cmFjdCgpIG5ldmVyIHJldHVybnMgZXJyb3IgcG9pbnRl cnMuwqDCoFBseiBkZWxldGUuDQo+IA0KPiDCoCAxMTQ4wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgbm9kZSA9IGNvbnRhaW5lcl9vZihyYl9ub2RlLCBzdHJ1Y3QNCj4gc2RtYV9t bXVfbm9kZSwgcmIpOw0KPiDCoCAxMTQ5wqDCoMKgwqDCoMKgwqDCoMKgwqBlbHNlDQo+IMKgIDEx NTDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByYl9ub2RlID0gTlVMTDsNCj4g wqAgMTE1McKgwqANCj4gwqAgMTE1MsKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKCFub2RlKSB7DQo+ IMKgIDExNTPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBub2RlID0ga3phbGxv YyhzaXplb2YoKm5vZGUpLCBHRlBfS0VSTkVMKTsNCj4gwqAgMTE1NMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGlmICghbm9kZSkNCj4gwqAgMTE1NcKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gLUVOT01FTTsNCj4gwqAg MTE1NsKgwqANCj4gwqAgMTE1N8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoG5v ZGUtPnJiLmFkZHIgPSAodW5zaWduZWQgbG9uZylpb3ZlYy0NCj4gPmlvdi5pb3ZfYmFzZTsNCj4g wqAgMTE1OMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoG5vZGUtPnBxID0gcHE7 DQo+IMKgIDExNTnCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBhdG9taWNfc2V0 KCZub2RlLT5yZWZjb3VudCwgMCk7DQo+IMKgIDExNjDCoMKgwqDCoMKgwqDCoMKgwqDCoH0NCj4g DQo+IHJlZ2FyZHMsDQo+IGRhbiBjYXJwZW50ZXINCj4gLS0NCj4gVG8gdW5zdWJzY3JpYmUgZnJv bSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXJkbWEiIA0KPiBp bg0KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZw0K PiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0wqDCoGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jk b21vLWluZm8uaHRtbA==
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html