spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

PATCH New dumitru.bacrau at intel.com 4 participants 7 messages Oct 12, 2016 – Nov 17, 2016 Memory technology devices (MTD)

lore

Share & tools

lore

dumitru.bacrau at intel.com

author

2016-10-12 14:15 UTC #0 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

From: Radu Bacrau <[email protected]>

This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.

Signed-off-by Radu Bacrau <[email protected]>

Cc Chin Liang See <[email protected]>

Cc Dinh Nguyen <[email protected]>

Cc Jagan Teki <[email protected]>

Cc Radu Bacrau <[email protected]>

---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/mtd/spi/sf_params.c +3 -0

index 5b50114..8b50465 100644
@@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"MX25L25635F",	   0xc22019, 0x0,	64 * 1024,   512, RD_FULL | WR_QPP},
 	{"MX25L51235F",	   0xc2201a, 0x0,	64 * 1024,  1024, RD_FULL | WR_QPP},
 	{"MX25L12855E",	   0xc22618, 0x0,	64 * 1024,   256, RD_FULL | WR_QPP},
+	{"MX66U51235F",    0xc2253a, 0x0,	64 * 1024,  1024, RD_FULL | WR_QPP},
+	{"MX66L1G45G",     0xc2201b, 0x0,	64 * 1024,  2048, RD_FULL | WR_QPP},
 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */
 	{"S25FL008A",	   0x010213, 0x0,	64 * 1024,    16, 0},

@@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"N25Q512A",	   0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP | E_FSR | SECT_4K},
 	{"N25Q1024",	   0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
 	{"N25Q1024A",	   0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
+	{"MT25QU02G",	   0x20bb22, 0x0,       64 * 1024,  4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},
 #endif
 #ifdef CONFIG_SPI_FLASH_SST		/* SST */
 	{"SST25VF040B",	   0xbf258d, 0x0,	64 * 1024,     8, SECT_4K | SST_WR},

Signature · 1 line

1.9.1

Chin Liang See

2016-10-12 15:21 UTC #1 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Quoted 5 lines · dumitru.bacrau at intel.com

From: Radu Bacrau <[email protected]>
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.

Quoted 9 lines

Signed-off-by Radu Bacrau <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Radu Bacrau <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)

Reviewed-by Chin Liang See <[email protected]>

Thanks
Chin Liang

Jagan Teki

2016-10-26 07:24 UTC #2 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

In reply to dumitru.bacrau at intel.com

Quoted 18 lines · On Wed, Oct 12, 2016 at 7:45 PM, <[email protected]> wrote:

From: Radu Bacrau <[email protected]>
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by Radu Bacrau <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Radu Bacrau <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +0 -0
index 5b50114..8b50465 100644

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 56

Quoted 5 lines

drivers/mtd/spi/sf_params.c +2 -0

@@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512, RD_FULL | WR_QPP},
        {"MX25L51235F",    0xc2201a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
        {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256, RD_FULL | WR_QPP},
+       {"MX66U51235F",    0xc2253a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
+       {"MX66L1G45G",     0xc2201b, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP},

OK.

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 103

Quoted 8 lines

drivers/mtd/spi/sf_params.c +1 -0

 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
        {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16, 0},

@@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"N25Q512A",       0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024",       0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024A",      0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
+       {"MT25QU02G",      0x20bb22, 0x0,       64 * 1024,  4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},

Can you send the link for flash data sheet I couldn't find it.

thanks!

Signature · 4 lines

Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Bacrau

2016-10-26 15:48 UTC #3 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Hello Teki,

The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_02g_cbb_0.pdf.

Thanks a lot,
Radu

-----Original Message-----
From: Jagan Teki [mailto:jagan at openedev.com]
Sent: Wednesday, October 26, 2016 2:25 AM
To: Bacrau, Dumitru <[email protected]>
Cc: u-boot at lists.denx.de; Chin Liang See <[email protected]>; Dinh Nguyen <[email protected]>; Radu Bacrau <[email protected]>
Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Quoted 18 lines · On Wed, Oct 12, 2016 at 7:45 PM, <[email protected]> wrote:

From: Radu Bacrau <[email protected]>
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by Radu Bacrau <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Radu Bacrau <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +0 -0
index 5b50114..8b50465 100644

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 56

Quoted 5 lines

drivers/mtd/spi/sf_params.c +2 -0

@@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512, RD_FULL | WR_QPP},
        {"MX25L51235F",    0xc2201a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
        {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256, RD_FULL | WR_QPP},
+       {"MX66U51235F",    0xc2253a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
+       {"MX66L1G45G",     0xc2201b, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP},

OK.

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 103

Quoted 8 lines

drivers/mtd/spi/sf_params.c +1 -0

 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
        {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16, 0},

@@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"N25Q512A",       0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024",       0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024A",      0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
+       {"MT25QU02G",      0x20bb22, 0x0,       64 * 1024,  4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},

Can you send the link for flash data sheet I couldn't find it.

thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.

Jagan Teki

2016-10-26 17:53 UTC #4 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Quoted 3 lines · Dumitru

Hello Teki,
The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_02g_cbb_0.pdf.

Thanks.

Quoted 35 lines

-----Original Message-----
From: Jagan Teki [mailto:jagan at openedev.com]
Sent: Wednesday, October 26, 2016 2:25 AM
To: Bacrau, Dumitru <[email protected]>
Cc: u-boot at lists.denx.de; Chin Liang See <[email protected]>; Dinh Nguyen <[email protected]>; Radu Bacrau <[email protected]>
Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
Quoted 18 lines · On Wed, Oct 12, 2016 at 7:45 PM, <[email protected]> wrote:
From: Radu Bacrau <[email protected]>
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by Radu Bacrau <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Radu Bacrau <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +0 -0
index 5b50114..8b50465 100644
drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 56
Quoted 5 lines
drivers/mtd/spi/sf_params.c +2 -0
@@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512, RD_FULL | WR_QPP},
        {"MX25L51235F",    0xc2201a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
        {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256, RD_FULL | WR_QPP},
+       {"MX66U51235F",    0xc2253a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
+       {"MX66L1G45G",     0xc2201b, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP},
OK.

Quoted 8 lines

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 103

Quoted 8 lines

drivers/mtd/spi/sf_params.c +1 -0

 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
        {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16, 0},

@@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"N25Q512A",       0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024",       0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024A",      0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
+       {"MT25QU02G",      0x20bb22, 0x0,       64 * 1024,  4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},

Since it's bb 1.8v we usually differentiate to use 'A' at the end of the name like
N25Q1024 - 0x20ba
N25Q1024A - 0x20bb

So, we need append A at end of the name - MT25QU02GA. If you agree please try to send the next version with this update.

thanks!

Signature · 4 lines

Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

Bacrau

2016-10-26 22:18 UTC #5 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Hi Teki,

Sure, I can do that, but here is more information, maybe we can come up with a better solution:

For this device, the "U" in the part name means "1.8V". The equivalent 3.3V part has "L" in the part name. So I would prefer having the names:
- MT25QL02G - for 3.3V device
- MT25QU02G - for the 1.8V device

The advantages of this naming is that the string is easily searchable on the web (for example if you search for N25Q1024 you will not find it on the Micron website).

If that is not acceptable, then I would suggest the following alternative (without 'U' or 'L'):
- MT25Q02G - for 3.3V device
- MT25Q02GA - for the 1.8V device

Just let me know which one you prefer, and I will re-submit. I can include the 3.3V part according to datasheet, although I cannot test it.

Thank you,
Radu

-----Original Message-----
From: Jagan Teki [mailto:jagan at openedev.com]
Sent: Wednesday, October 26, 2016 12:53 PM
To: Bacrau, Dumitru <[email protected]>
Cc: u-boot at lists.denx.de; Radu Bacrau <[email protected]>; Chin Liang See <[email protected]>
Subject: Re: [U-Boot] [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Quoted 3 lines · Dumitru

Hello Teki,
The device that I have used is MT25QU02GCBB8E12-0SIT, with the datasheet available here: https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_02g_cbb_0.pdf.

Thanks.

Quoted 38 lines

-----Original Message-----
From: Jagan Teki [mailto:jagan at openedev.com]
Sent: Wednesday, October 26, 2016 2:25 AM
To: Bacrau, Dumitru <[email protected]>
Cc: u-boot at lists.denx.de; Chin Liang See <[email protected]>; Dinh Nguyen <[email protected]>; Radu Bacrau <[email protected]>
Subject: Re: [PATCH] spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G
Quoted 18 lines · On Wed, Oct 12, 2016 at 7:45 PM, <[email protected]> wrote:
From: Radu Bacrau <[email protected]>
This commit adds support for the Macronix MX66U51235F, MX66L1G45G and Micron MT25QU02G flash parts.
Signed-off-by Radu Bacrau <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Radu Bacrau <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0
b/drivers/mtd/spi/sf_params.c index 5b50114..8b50465 100644
drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 56
Quoted 5 lines
drivers/mtd/spi/sf_params.c +2 -0
@@ -52,6 +52,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512, RD_FULL | WR_QPP},
        {"MX25L51235F",    0xc2201a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
        {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256, RD_FULL | WR_QPP},
+       {"MX66U51235F",    0xc2253a, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP},
+       {"MX66L1G45G",     0xc2201b, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP},
OK.

Quoted 8 lines

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = { · line 103

Quoted 8 lines

drivers/mtd/spi/sf_params.c +1 -0

 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
        {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16, 0},

@@ -98,6 +100,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"N25Q512A",       0x20bb20, 0x0,       64 * 1024,  1024, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024",       0x20ba21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
        {"N25Q1024A",      0x20bb21, 0x0,       64 * 1024,  2048, RD_FULL | WR_QPP | E_FSR | SECT_4K},
+       {"MT25QU02G",      0x20bb22, 0x0,       64 * 1024,  4096, RD_FULL | WR_QPP | E_FSR | SECT_4K},

Since it's bb 1.8v we usually differentiate to use 'A' at the end of the name like N25Q1024 - 0x20ba
N25Q1024A - 0x20bb

So, we need append A at end of the name - MT25QU02GA. If you agree please try to send the next version with this update.

thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.

Jagan Teki

2016-11-17 16:13 UTC #6 lore raw

PATCH 1/1 spi: Add support for MX66U51235F, MX66L1G45G and MT25QU02G

Quoted 9 lines · Dumitru

Hi Teki,
Sure, I can do that, but here is more information, maybe we can come up with a better solution:
For this device, the "U" in the part name means "1.8V". The equivalent 3.3V part has "L" in the part name. So I would prefer having the names:
- MT25QL02G - for 3.3V device
- MT25QU02G - for the 1.8V device
The advantages of this naming is that the string is easily searchable on the web (for example if you search for N25Q1024 you will not find it on the Micron website).

Sounds valid, submit with these changes, thanks.

Signature · 4 lines

Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.