Patch "mfd: 88pm80x: Double shifting bug in suspend/resume" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
mfd: 88pm80x: Double shifting bug in suspend/resume
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mfd-88pm80x-double-shifting-bug-in-suspend-resume.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
9a6dc644512fd083400a96ac4a035ac154fe6b8dMon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Thu, 4 Aug 2016 08:26:56 +0300
Subject: mfd: 88pm80x: Double shifting bug in suspend/resume
From: Dan Carpenter <[email protected]>
commit 9a6dc644512fd083400a96ac4a035ac154fe6b8d upstream.
set_bit() and clear_bit() take the bit number so this code is really doing "1 << (1 << irq)" which is a double shift bug. It's done consistently so it won't cause a problem unless "irq" is more than 4.
--- include/linux/mfd/88pm80x.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mfd/88pm80x.h +2 -2
@@ -350,7 +350,7 @@ static inline int pm80x_dev_suspend(struint irq =platform_get_irq (pdev,0 );if (device_may_wakeup (dev)) -set_bit ((1 << irq), &chip->wu_flag); +set_bit (irq, &chip->wu_flag);return 0 ; }
@@ -362,7 +362,7 @@ static inline int pm80x_dev_resume(strucint irq =platform_get_irq (pdev,0 );if (device_may_wakeup (dev)) -clear_bit ((1 << irq), &chip->wu_flag); +clear_bit (irq, &chip->wu_flag);return 0 ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/kvm-ppc-booke-fix-a-sanity-check.patch queue-4.7/mfd-88pm80x-double-shifting-bug-in-suspend-resume.patch