drm/i915: Suppress underrun reporting around DP link retraining
Subsystems (2)
cover drm/i915: Suppress underrun reporting around DP link retraining
From: Ville Syrjälä <[email protected]>
This series should reduce the underrn spam in CI. I expect it won't eliminate it entirely as we seem to have two classes of dmesg warns: from link retraining, and from normal modesets. The second category will need more investigation, but one suspect might be the audio enable sequence.
Ville Syrjälä (2):
drm/i915: Extract intel_crtc_pch_transcoder() drm/i915: Suppress underruns during DP link retraining
drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++------- drivers/gpu/drm/i915/intel_dp.c | 29 +++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 42 insertions(+), 9 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/2 drm/i915: Extract intel_crtc_pch_transcoder()
From: Ville Syrjälä <[email protected]>
Extract the code to determine which PCH transcoder we're using to a small helper.
--- drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++------- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 15 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_display.c +14 -7
@@ -1926,6 +1926,18 @@ void lpt_disable_pch_transcoder(struct drm_i915_private *dev_priv)I915_WRITE (TRANS_CHICKEN2 (PIPE_A ), val); } +enum transcoder intel_crtc_pch_transcoder (struct intel_crtc *crtc) +{ +struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); + +WARN_ON (!crtc->config->has_pch_encoder); + +if (HAS_PCH_LPT (dev_priv)) +return TRANSCODER_A ; +else +return (enum transcoder ) crtc->pipe; +} +/** * intel_enable_pipe - enable a pipe, asserting requirements * @crtc: crtc responsible for the pipe
@@ -1939,7 +1951,6 @@ static void intel_enable_pipe(struct intel_crtc *crtc)struct drm_i915_private *dev_priv =to_i915 (dev);enum pipe pipe = crtc->pipe;enum transcoder cpu_transcoder = crtc->config->cpu_transcoder; -enum pipe pch_transcoder;i915_reg_t reg;u32 val;
@@ -1949,11 +1960,6 @@ static void intel_enable_pipe(struct intel_crtc *crtc)assert_cursor_disabled (dev_priv, pipe);assert_sprites_disabled (dev_priv, pipe); -if (HAS_PCH_LPT (dev_priv)) - pch_transcoder =TRANSCODER_A ; -else - pch_transcoder = pipe; -/* * A pipe without a PLL won't actually be able to drive bits from * a plane. On ILK+ the pipe PLLs are integrated, so we don't
@@ -1967,7 +1973,8 @@ static void intel_enable_pipe(struct intel_crtc *crtc) }else {if (crtc->config->has_pch_encoder) {/* if driving the PCH, we need FDI enabled */ -assert_fdi_rx_pll_enabled (dev_priv, pch_transcoder); +assert_fdi_rx_pll_enabled (dev_priv, + (enum pipe )intel_crtc_pch_transcoder (crtc));assert_fdi_tx_pll_enabled (dev_priv, (enum pipe ) cpu_transcoder); }
drivers/gpu/drm/i915/intel_drv.h +1 -0
@@ -1183,6 +1183,7 @@ void i915_audio_component_init(struct drm_i915_private *dev_priv);void i915_audio_component_cleanup (struct drm_i915_private *dev_priv);/* intel_display.c */ +enum transcoder intel_crtc_pch_transcoder (struct intel_crtc *crtc);void skl_set_preferred_cdclk_vco (struct drm_i915_private *dev_priv,int vco);void intel_update_rawclk (struct drm_i915_private *dev_priv); int vlv_get_cck_clock(struct drm_i915_private *dev_priv,
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915: Suppress underruns during DP link retraining
In reply to [email protected]From: Ville Syrjälä <[email protected]>
DP link retraining causes (spurious?) underruns. We can't really avoid them, except perhaps by doing a full modeset (which has its own underrun suppression anyway). So let's just hide them.
MST still has its own logic for retrainin, but a bigger hpd handling cleanup/unification is needed there anyway, so let's leave that be for now.
References: https://bugs.freedesktop.org/show_bug.cgi?id=98251
--- drivers/gpu/drm/i915/intel_dp.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +27 -2
@@ -3988,6 +3988,31 @@ go_again: }static void +intel_dp_retrain_link (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct intel_crtc *crtc =to_intel_crtc (encoder->base.crtc); + +/* Suppress underruns caused by re-training */ +intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, false); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), false); + +intel_dp_start_link_train (intel_dp); +intel_dp_stop_link_train (intel_dp); + +/* Keep underrun reporting disabled until things are stable */ +intel_wait_for_vblank (&dev_priv->drm, crtc->pipe); + +intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, true); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), true); +} + +static void intel_dp_check_link_status (struct intel_dp *intel_dp) {struct intel_encoder *intel_encoder = &dp_to_dig_port (intel_dp)->base;
@@ -4012,8 +4037,8 @@ intel_dp_check_link_status(struct intel_dp *intel_dp) (!drm_dp_channel_eq_ok(link_status, intel_dp->lane_count))) {DRM_DEBUG_KMS ("%s: channel EQ not ok, retraining\n" , intel_encoder->base.name); -intel_dp_start_link_train (intel_dp); -intel_dp_stop_link_train (intel_dp); + +intel_dp_retrain_link (intel_dp); } }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915: Suppress underruns during DP link retraining
Quoted 30 lines · On Fri, Oct 14, 2016 at 08:02:54PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
DP link retraining causes (spurious?) underruns. We can't really avoid them, except perhaps by doing a full modeset (which has its own underrun suppression anyway). So let's just hide them.
MST still has its own logic for retrainin, but a bigger hpd handling cleanup/unification is needed there anyway, so let's leave that be for now.
References: https://bugs.freedesktop.org/show_bug.cgi?id=98251
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +7
-0@@ -3988,6 +3988,31 @@ go_again: }static void +intel_dp_retrain_link (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct intel_crtc *crtc =to_intel_crtc (encoder->base.crtc); + +/* Suppress underruns caused by re-training */
drivers/gpu/drm/i915/intel_dp.c go_again: · line 4007
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +10
-0+intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, false); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), false); + +intel_dp_start_link_train (intel_dp); +intel_dp_stop_link_train (intel_dp); + +/* Keep underrun reporting disabled until things are stable */ +intel_wait_for_vblank (&dev_priv->drm, crtc->pipe);
I panicked over the irqreturn for hpd_pulse. That's a scary way of saying the return type is boolean.
drivers/gpu/drm/i915/intel_dp.c go_again: · line 4012
Quoted 4 lines
drivers/gpu/drm/i915/intel_dp.c +4
-0+intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, true); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), true);
These are becoming quite popular. Is has_pch_encoder generic enough for all crtc?
intel_crtc_suppress_underruns(struct intel_crtc *crtc, bool state)
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
if (!state)
intel_wait_for_vblank(&dev_priv->drm, crtc->pipe);
intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, state);
if (crtc->config->has_pch_encoder)
intel_set_pch_fifo_underrun_reporting(dev_priv,
intel_crtc_pch_transcoder(crtc),
state);
}If this was igt, we would be writing all kinds of silly
#define intel_crtc_suppress_underruns(crtc, state) \
for (state = true; __intel_crtc_suppress_underruns(crtc, state); state = false)
intel_crtc_suppress_underruns(crtc, state) {
intel_dp_start_link_train(intel_dp);
intel_dp_stop_link_train(intel_dp);
}Other than bikeshedding to see if we can trim down the profileration, this looks inline with the suppression everywhere else, so
Main concern was over the vblank wait making short/long pulse handling slower, but the code looks like it will survive - and the only noticeable artifacts would be if link training failed anyway with the small delay before recovery.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915: Suppress underruns during DP link retraining
Quoted 36 lines · Chris Wilson
Quoted 35 lines · On Fri, Oct 14, 2016 at 08:02:54PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
DP link retraining causes (spurious?) underruns. We can't really avoid them, except perhaps by doing a full modeset (which has its own underrun suppression anyway). So let's just hide them.
MST still has its own logic for retrainin, but a bigger hpd handling cleanup/unification is needed there anyway, so let's leave that be for now.
References: https://bugs.freedesktop.org/show_bug.cgi?id=98251
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_dp.c +12
-0@@ -3988,6 +3988,31 @@ go_again: }static void +intel_dp_retrain_link (struct intel_dp *intel_dp) +{ +struct intel_encoder *encoder = &dp_to_dig_port (intel_dp)->base; +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct intel_crtc *crtc =to_intel_crtc (encoder->base.crtc); + +/* Suppress underruns caused by re-training */ +intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, false); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), false); +
Quoted 8 lines
drivers/gpu/drm/i915/intel_dp.c go_again: · line 4007
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +5
-0+intel_dp_start_link_train (intel_dp); +intel_dp_stop_link_train (intel_dp); + +/* Keep underrun reporting disabled until things are stable */ +intel_wait_for_vblank (&dev_priv->drm, crtc->pipe);I panicked over the irqreturn for
hpd_pulse. That's a scary way of saying the return type is boolean.
It's been known to cause bugs too when people don't remember what it means.
Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c go_again: · line 4012
Quoted 5 lines
drivers/gpu/drm/i915/intel_dp.c +4
-0+intel_set_cpu_fifo_underrun_reporting (dev_priv, crtc->pipe, true); +if (crtc->config->has_pch_encoder) +intel_set_pch_fifo_underrun_reporting (dev_priv, +intel_crtc_pch_transcoder (crtc), true);These are becoming quite popular. Is
has_pch_encodergeneric enough for all crtc?
intel_crtc_suppress_underruns(struct intel_crtc *crtc, bool state)
Quoted 12 lines
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
if (!state)
intel_wait_for_vblank(&dev_priv->drm, crtc->pipe);
intel_set_cpu_fifo_underrun_reporting(dev_priv, crtc->pipe, state);
if (crtc->config->has_pch_encoder)
intel_set_pch_fifo_underrun_reporting(dev_priv,
intel_crtc_pch_transcoder(crtc),
state);
}Hmm. I suppose we could replace a the ones in dp/hdmi/sdvo code with something like that. Would need to use intel_wait_for_vblank_if_active() though.
The ones directly in the crtc enable/disable paths paths aren't quite that straightforward though. Making them simpler might ease the maintenance burden though, with the cost of a slight loss in coverage.
Quoted 12 lines
If this was igt, we would be writing all kinds of silly
#define
intel_crtc_suppress_underruns(crtc, state)\
for (state = true;__intel_crtc_suppress_underruns(crtc, state); state = false)intel_crtc_suppress_underruns(crtc, state) { intel_dp_start_link_train(intel_dp); intel_dp_stop_link_train(intel_dp); }
Quoted 8 lines
Other than bikeshedding to see if we can trim down the profileration, this looks inline with the suppression everywhere else, so
Reviewed-by Chris Wilson <[email protected]>Main concern was over the vblank wait making short/long pulse handling slower, but the code looks like it will survive - and the only noticeable artifacts would be if link training failed anyway with the small delay before recovery.
The pipe should be running still so at least it shouldn't have to wait for a timeout.
In general the retraining doesn't feel entirely robust. If I try force a retraining on my ILK or IVB when the link is actually good, it generally doesn't succeed. If I toggle the port state at the start of the retraining it starts to work. The spec even says we should do that, so might be we should go for it. I think I'll need to digest this idea a bit more thogh, as I haven't pondered the ramifications thorougly.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining
In reply to [email protected]== Series Details ==
== Series Details ==
Series: drm/i915: Suppress underrun reporting around DP link retraining
URL : https://patchwork.freedesktop.org/series/13805/
State : warning
== Summary ==
Series 13805v1 drm/i915: Suppress underrun reporting around DP link retraining
https://patchwork.freedesktop.org/api/1.0/series/13805/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (fi-skl-6770hq)
dmesg-warn -> PASS (fi-skl-6700k)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-a-frame-sequence:
dmesg-warn -> PASS (fi-ilk-650)
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (fi-ilk-650)
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-skl-6700k)
Test vgem_basic:
Subgroup unload:
pass -> SKIP (fi-hsw-4770)fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30 fi-byt-j1900 total:246 pass:213 dwarn:1 dfail:0 fail:1 skip:31 fi-byt-n2820 total:246 pass:210 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23 fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:246 pass:184 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24 fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23 fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24 fi-skl-6770hq total:246 pass:229 dwarn:1 dfail:0 fail:1 skip:15 fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2727/
38ecbe9082e477953fe165265c76e6c6061aeaf6 drm-intel-nightly: 2016y-10m-14d-16h-23m-48s UTC integration manifest 171418c drm/i915: Suppress underruns during DP link retraining
2a576f6 drm/i915: Extract intel_crtc_pch_transcoder()
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Suppress underrun reporting around DP link retraining
URL : https://patchwork.freedesktop.org/series/13805/
State : warning
OK, but...
Quoted 7 lines
== Summary ==
Series 13805v1 drm/i915: Suppress underrun reporting around DP link retraining
https://patchwork.freedesktop.org/api/1.0/series/13805/revisions/1/mbox/Test
kms_flip:
Quoted 13 lines
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (fi-skl-6770hq)
dmesg-warn -> PASS (fi-skl-6700k)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-a-frame-sequence:
dmesg-warn -> PASS (fi-ilk-650)
Subgroup read-crc-pipe-b:
dmesg-warn -> PASS (fi-ilk-650)
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-skl-6700k)
Test vgem_basic:
Subgroup unload:
pass -> SKIP (fi-hsw-4770)... where is the warn here?
Quoted 24 lines
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42 fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30 fi-byt-j1900 total:246 pass:213 dwarn:1 dfail:0 fail:1 skip:31 fi-byt-n2820 total:246 pass:210 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770 total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23 fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-ilk-650 total:246 pass:184 dwarn:0 dfail:0 fail:2 skip:60 fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25 fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24 fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23 fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24 fi-skl-6770hq total:246 pass:229 dwarn:1 dfail:0 fail:1 skip:15 fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37Results at /archive/results/CI_IGT_test/Patchwork_2727/
38ecbe9082e477953fe165265c76e6c6061aeaf6drm-intel-nightly: 2016y-10m-14d-16h-23m-48s UTC integration manifest 171418c drm/i915: Suppress underruns during DP link retraining
2a576f6 drm/i915: Extractintel_crtc_pch_transcoder()
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining
Quoted 15 lines · On Monday, 17 October 2016 14:33:28 EEST Ville Syrjälä wrote:
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Suppress underrun reporting around DP link retraining
URL : https://patchwork.freedesktop.org/series/13805/
State : warningOK, but...
Quoted 6 lines
== Summary ==
Series 13805v1 drm/i915: Suppress underrun reporting around DP link retraining
https://patchwork.freedesktop.org/api/1.0/series/13805/revisions/1/mbox/>
Quoted 5 lines
Quoted 3 lines
Test
vgem_basic:Subgroup unload: pass -> SKIP (fi-hsw-4770)... where is the warn here?
This was added to comparison code because I was asked to:
# pass -> SKIP
if testresult < 1 and (lastres == 'pass' and res == 'skip'):
testresult = 1Unintuitive, but there you go.
Tomi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining
Quoted 22 lines · Tomi Sarvela
Quoted 15 lines · On Monday, 17 October 2016 14:33:28 EEST Ville Syrjälä wrote:
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Suppress underrun reporting around DP link retraining
URL : https://patchwork.freedesktop.org/series/13805/
State : warningOK, but...
Quoted 6 lines
== Summary ==
Series 13805v1 drm/i915: Suppress underrun reporting around DP link retraining
https://patchwork.freedesktop.org/api/1.0/series/13805/revisions/1/mbox/>Quoted 5 lines
Quoted 3 lines
Test
vgem_basic:Subgroup unload: pass -> SKIP (fi-hsw-4770)... where is the warn here?
Quoted 7 lines
This was added to comparison code because I was asked to:
# pass -> SKIP if testresult < 1 and (lastres == 'pass' and res == 'skip'): testresult = 1Unintuitive, but there you go.
OK. Well, this test seems to skip<->pass quite a lot, so I'll put it down as already busted somehow.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · On Fri, Oct 14, 2016 at 08:02:52PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
This series should reduce the underrn spam in CI. I expect it won't eliminate it entirely as we seem to have two classes of dmesg warns: from link retraining, and from normal modesets. The second category will need more investigation, but one suspect might be the audio enable sequence.
Ville Syrjälä (2):
drm/i915: Extractintel_crtc_pch_transcoder()drm/i915: Suppress underruns during DP link retraining
Series merge to dinq. Thanks for the reviews.
Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c | 21 ++++++++++++++------- drivers/gpu/drm/i915/intel_dp.c | 29 +++++++++++++++++++++++++++-- drivers/gpu/drm/i915/intel_drv.h | 1 + 3 files changed, 42 insertions(+), 9 deletions(-)Signature · 1 line
2.7.4
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx