ARM: dts: rockchip: temporarily remove emmc hs200 speed from rk3288-veyron-speedy.
Subsystems (2)
PATCH v2 1/1 ARM: dts: rockchip: temporarily remove emmc hs200 speed from rk3288-veyron-speedy.
This essentially mimics what was done with rk3288-veyron-minnie in commit 984926781122f034d5bc9962815d135b6c4a8e1d.
The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
---
Changes in v2:
- Added Signed-off-by.
arch/arm/boot/dts/rk3288-veyron-speedy.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/rk3288-veyron-speedy.dts +5 -0
@@ -124,6 +124,11 @@ &sdmmc_bus4>; }; + +&emmc { + /delete-property/mmc-hs200-1_8v; +}; + &vcc_5v { enable-active-high; gpio = <&gpio7 21 GPIO_ACTIVE_HIGH>;
Signature · 8 lines
2.9.3 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 818 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160927/2c08807f/attachment.sig>
Am Dienstag, 27. September 2016, 13:53:46 CEST schrieb Vagrant Cascadian:
Quoted 7 lines
This essentially mimics what was done with rk3288-veyron-minnie in commit
984926781122f034d5bc9962815d135b6c4a8e1d.The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
Signed-off-by Vagrant Cascadian <[email protected]>
applied as fix for 4.9.
Your mail client mangled that patch a lot (tabs etc), so it didn't apply cleanly. As it is a quite small one, I fixed that up myself, but please try to make your mail client send correct patches in the future or use git send-email :-)
Thanks
Heiko
Hi,
Le mardi 27 septembre 2016 ? 13:53 -0700, Vagrant Cascadian a ?crit?:
Quoted 5 lines
This essentially mimics what was done with rk3288-veyron-minnie in commit
984926781122f034d5bc9962815d135b6c4a8e1d.The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
I have a device where (without this patch) eMMC sometimes fails, with:
[????3.561010] dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 175 [????3.571742] mmc2: new HS200 MMC card at address 0001
[????3.571943] mmcblk2: mmc2:0001 HAG2e 14.7 GiB?
[????3.572026] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB
[????3.572107] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB
[????3.572181] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB
[????3.685647] mmcblk2: error -110 transferring data, sector 0, nr 8, cmd response 0x900, card status 0x0
And sometimes works, with:
[????3.451058] dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 176 [????3.491093] mmc2: new HS200 MMC card at address 0001 [????3.491277] mmcblk2: mmc2:0001 HAG2e 14.7 GiB?
[????3.491345] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [????3.491409] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [????3.491474] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [????3.493548]??mmcblk2: p1 p2
However, with this change, it always fails, with:
[????3.322129] mmc_host mmc2: Bus speed (slot 0) = 50000000Hz (slot req 52000000Hz, actual 50000000HZ div = 0) [????3.333174] mmc2: error -110 whilst initialising MMC card
I don't have so much time to investigate this issue, but it's clear that this patch doesn't fix the issue (and actually worsens it) for my device.
Cheers!
Quoted 29 lines
Signed-off-by Vagrant Cascadian <[email protected]>---
Changes in v2:
?- Added Signed-off-by.?arch/arm/boot/dts/rk3288-veyron-speedy.dts | 5 +++++ ?1 file changed, 5 insertions(+)
arch/arm/boot/dts/rk3288-veyron-speedy.dts +5
-0@@ -124,6 +124,11 @@ ????????????&sdmmc_bus4>; ?}; + +&emmc { +???????/delete-property/mmc-hs200-1_8v; +}; + ?&vcc_5v { ????enable-active-high; ????gpio = <&gpio7 21 GPIO_ACTIVE_HIGH>;_______________________________________________
Linux-rockchip mailing list
Linux-rockchip at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Signature · 12 lines
Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161016/6ae8dfd0/attachment.sig>
Heiko Stübner
maintainerAm Sonntag, 16. Oktober 2016, 21:49:43 schrieb Paul Kocialkowski:
Quoted 28 lines
Hi,
Le mardi 27 septembre 2016 ? 13:53 -0700, Vagrant Cascadian a ?crit :
Quoted 5 lines
This essentially mimics what was done with rk3288-veyron-minnie in commit
984926781122f034d5bc9962815d135b6c4a8e1d.The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
I have a device where (without this patch) eMMC sometimes fails, with:
[ 3.561010] dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 175 [ 3.571742] mmc2: new HS200 MMC card at address 0001 [ 3.571943] mmcblk2: mmc2:0001 HAG2e 14.7 GiB [ 3.572026] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [ 3.572107] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [ 3.572181] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [ 3.685647] mmcblk2: error -110 transferring data, sector 0, nr 8, cmdresponse
0x900, card status0x0And sometimes works, with:
[ 3.451058] dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 176 [ 3.491093] mmc2: new HS200 MMC card at address 0001 [ 3.491277] mmcblk2: mmc2:0001 HAG2e 14.7 GiB [ 3.491345] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [ 3.491409] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [ 3.491474] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [ 3.493548] mmcblk2: p1 p2
Quoted 7 lines
However, with this change, it always fails, with:
[ 3.322129] mmc_host mmc2: Bus speed (slot 0) = 50000000Hz (slot req52000000Hz, actual 50000000HZ div = 0) [ 3.333174] mmc2: error -110
whilst initialising MMC cardI don't have so much time to investigate this issue, but it's clear that this patch doesn't fix the issue (and actually worsens it) for my device.
thanks for the heads up.
As discussed on IRC we now have varying reports of the emmc working or not working with and without that patch applied. So it's not really a bandaid fix and I've thus dropped this patch again.
Still hoping someone will find the source of the problem somewhere :-)
Heiko
Hi,
Le mardi 18 octobre 2016 ? 11:21 +0200, Heiko St?bner a ?crit?:
Quoted 36 lines
Am Sonntag, 16. Oktober 2016, 21:49:43 schrieb Paul Kocialkowski:
Quoted 35 lines
Hi,
Le mardi 27 septembre 2016 ? 13:53 -0700, Vagrant Cascadian a ?crit :
Quoted 6 lines
This essentially mimics what was done with rk3288-veyron-minnie in commit
984926781122f034d5bc9962815d135b6c4a8e1d.The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
I have a device where (without this patch) eMMC sometimes fails, with:
[????3.561010]dwmmc_rockchipff0f0000.dwmmc: Successfully tuned phase to 175 [????3.571742] mmc2: new HS200 MMC card at address 0001 [????3.571943] mmcblk2: mmc2:0001 HAG2e 14.7 GiB? [????3.572026] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [????3.572107] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [????3.572181] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [????3.685647] mmcblk2: error -110 transferring data, sector 0, nr 8, cmd response0x900, card status0x0And sometimes works, with:
[????3.451058]dwmmc_rockchipff0f0000.dwmmc: Successfully tuned phase to 176 [????3.491093] mmc2: new HS200 MMC card at address 0001 [????3.491277] mmcblk2: mmc2:0001 HAG2e 14.7 GiB? [????3.491345] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [????3.491409] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [????3.491474] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [????3.493548]??mmcblk2: p1 p2However, with this change, it always fails, with:
[????3.322129]mmc_hostmmc2: Bus speed (slot 0) = 50000000Hz (slot req 52000000Hz, actual 50000000HZ div = 0) [????3.333174] mmc2: error -110 whilst initialising MMC card
Quoted 8 lines
Quoted 2 lines
I don't have so much time to investigate this issue, but it's clear that this patch doesn't fix the issue (and actually worsens it) for my device.
thanks for the heads up.
As discussed on IRC we now have varying reports of the emmc working or not? working with and without that patch applied. So it's not really a bandaid fix? and I've thus dropped this patch again.
Thanks for dropping it! For the record, my eMMC shows up as:
mmcblk2: mmc2:0001 HAG2e 14.7 GiB
Maybe it could help to share what each tested device reports as eMMC model and associate that with the current behavior, in spite of getting a clearer idea of what issue affects what model.
Quoted 1 line
Still hoping someone will find the source of the problem somewhere :-)
I have started investigating the issue, but did not discover anything significant yet. I hope I'll be able to figure it out!
Cheers!
Signature · 12 lines
Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161018/1250804a/attachment.sig>
Quoted 28 lines · Paul Kocialkowski
Le mardi 18 octobre 2016 ? 11:21 +0200, Heiko St?bner a ?crit?:
Quoted 27 lines
Am Sonntag, 16. Oktober 2016, 21:49:43 schrieb Paul Kocialkowski:
Quoted 26 lines
Le mardi 27 septembre 2016 ? 13:53 -0700, Vagrant Cascadian a ?crit :
Quoted 6 lines
This essentially mimics what was done with rk3288-veyron-minnie in commit
984926781122f034d5bc9962815d135b6c4a8e1d.The eMMC of the speedy Chromebook also appears to need the same tuning workaround, as it frequently fails to recognize the eMMC without it.
I have a device where (without this patch) eMMC sometimes fails, with:
[????3.561010]dwmmc_rockchipff0f0000.dwmmc: Successfully tuned phase to 175 [????3.571742] mmc2: new HS200 MMC card at address 0001 [????3.571943] mmcblk2: mmc2:0001 HAG2e 14.7 GiB? [????3.572026] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [????3.572107] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [????3.572181] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [????3.685647] mmcblk2: error -110 transferring data, sector 0, nr 8, cmd response0x900, card status0x0And sometimes works, with:
[????3.451058]dwmmc_rockchipff0f0000.dwmmc: Successfully tuned phase to 176 [????3.491093] mmc2: new HS200 MMC card at address 0001 [????3.491277] mmcblk2: mmc2:0001 HAG2e 14.7 GiB? [????3.491345] mmcblk2boot0: mmc2:0001 HAG2e partition 1 4.00 MiB [????3.491409] mmcblk2boot1: mmc2:0001 HAG2e partition 2 4.00 MiB [????3.491474] mmcblk2rpmb: mmc2:0001 HAG2e partition 3 4.00 MiB [????3.493548]??mmcblk2: p1 p2
This is similar behavior to my veyron-speedy. Here are several boot logs
Quoted 1 line
From running 4.8.0-rc7, with some failures and some successes:
https://cascadia.aikidev.net/~vagrant/veyron-speedy/
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
However, with this change, it always fails, with:
[????3.322129]mmc_hostmmc2: Bus speed (slot 0) = 50000000Hz (slot req 52000000Hz, actual 50000000HZ div = 0) [????3.333174] mmc2: error -110 whilst initialising MMC cardI don't have so much time to investigate this issue, but it's clear that this patch doesn't fix the issue (and actually worsens it) for my device.
Well, that makes things more complicated.
Quoted 6 lines
Quoted 3 lines
As discussed on IRC we now have varying reports of the emmc working or not? working with and without that patch applied. So it's not really a bandaid fix? and I've thus dropped this patch again.
Thanks for dropping it! For the record, my eMMC shows up as:
mmcblk2: mmc2:0001 HAG2e 14.7 GiB
Mine looks similar, although reporting as mmc0:
[ 3.166550] mmcblk0: mmc0:0001 HAG2e 14.7 GiB
Quoted 3 lines
Maybe it could help to share what each tested device reports as eMMC model and associate that with the current behavior, in spite of getting a clearer idea of what issue affects what model.
FWIW, I'm using a veyron-speedy with 4GB of ram, not sure what other information might be useful to distinguish between different models.
On the bottom of the case, it claims to be a C201P. Near the serial, it's marked as C201PA-DS02-LG.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161018/643b245b/attachment.sig>