Skip to contentSkip to conversation

staging: slicoss: replace memcpy_fromio with memcpy

PATCH In review Ryan Swan 2 participants 2 messages Oct 18, 2016 Staging

lore
Share & tools
lore

Ryan Swan

author
#0 lore raw

PATCH 1/1 staging: slicoss: replace memcpy_fromio with memcpy

As per discusion with Lino Sanfilippo, memcpy is the proper way to copy across dma memory, which also removes sparse warning that triggered inquiry.

Signed-off-by Ryan Swan <[email protected]>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/slicoss/slicoss.c +1 -1
index 2802b90..9a1dc72 100644
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
 		if (stats->rcv_drops > old->rcv_drops)
 			adapter->rcv_drops += (stats->rcv_drops -
 					       old->rcv_drops);
-		memcpy_fromio(old, stats, sizeof(*stats));
+		memcpy(old, stats, sizeof(*stats));
 		break;
 	}
 	case SLIC_UPR_RLSR:
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Ryan Swan

As per discusion with Lino Sanfilippo, memcpy is the proper way to copy across dma memory, which also removes sparse warning that triggered inquiry.

Signed-off-by Ryan Swan <[email protected]>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/slicoss/slicoss.c +0 -0
index 2802b90..9a1dc72 100644

drivers/staging/slicoss/slicoss.c static void slic_upr_request_complete(struct adapter *adapter, u32 isr) · line 1063

Quoted 8 lines
drivers/staging/slicoss/slicoss.c +1 -1
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
 		if (stats->rcv_drops > old->rcv_drops)
 			adapter->rcv_drops += (stats->rcv_drops -
 					       old->rcv_drops);
-		memcpy_fromio(old, stats, sizeof(*stats));
+		memcpy(old, stats, sizeof(*stats));
 		break;
 	}
 	case SLIC_UPR_RLSR:
Reviewed-by Lino Sanfilippo <[email protected]>