Skip to contentSkip to conversation

drm/amdgpu: avoid drm error log during S3 on RHEL7.3

PATCH In review jimqu 2 participants 3 messages Oct 20, 2016 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

jimqu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: avoid drm error log during S3 on RHEL7.3

Change-Id I04dc3d2749d162367a6745ea0e618c4d7d3cae8d
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2 -1
index cf03f9f..7182812 100644
@@ -530,7 +530,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
 		r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
 					   &duplicates);
 		if (unlikely(r != 0)) {
-			DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
+			if (r != -ERESTARTSYS)
+				DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
 			goto error_free_pages;
 		}
 
Signature · 6 lines
1.9.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1476946812-11494-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 20.10.2016 um 09:00 schrieb jimqu:

Quoted 2 lines
Change-Id I04dc3d2749d162367a6745ea0e618c4d7d3cae8d

Patch is Reviewed-by: Christian König <[email protected]>.

Nice catch, we probably have that on some other places as well. Have you also checked the other DRM_ERROR() occasions in that file?

Regards,
Christian.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +0 -0
index cf03f9f..7182812 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, · line 537

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2 -1
@@ -530,7 +530,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
  		r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
  					   &duplicates);
  		if (unlikely(r != 0)) {
-			DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
+			if (r != -ERESTARTSYS)
+				DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
  			goto error_free_pages;
  		}
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): eddd8703-d68f-3ebb-a81d-f313c836b1f3-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org

author
#4 lore raw

No problem!

Thanks
JimQu

________________________________________
发件人: Christian König <[email protected]>
发送时间: 2016年10月20日 15:50
收件人: Qu, Jim; [email protected]
主题: Re: [PATCH] drm/amdgpu: avoid drm error log during S3 on RHEL7.3

Am 20.10.2016 um 09:00 schrieb jimqu:

Quoted 2 lines
Change-Id I04dc3d2749d162367a6745ea0e618c4d7d3cae8d

Patch is Reviewed-by: Christian König <[email protected]>.

Nice catch, we probably have that on some other places as well. Have you also checked the other DRM_ERROR() occasions in that file?

Regards,
Christian.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +0 -0
index cf03f9f..7182812 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, · line 537

Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +2 -1
@@ -530,7 +530,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
              r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
                                         &duplicates);
              if (unlikely(r != 0)) {
-                     DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
+                     if (r != -ERESTARTSYS)
+                             DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
                      goto error_free_pages;
              }
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx