Skip to contentSkip to conversation

MAINTAINERS: Add "B:" for URI where to file bugs

PATCH Applied Jani Nikula 6 participants 11 messages Oct 20, 2016 – Nov 3, 2016 GET_MAINTAINER script

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 MAINTAINERS: Add "B:" for URI where to file bugs

Different subsystems and drivers have different preferences for where to file bugs and what information to include. Add "B:" entry for specifying the URI for the bug tracker directly, a web page for detailed info on filing bugs, or a mailto: URI.

Cc Daniel Vetter <[email protected]>
Cc Joe Perches <[email protected]>
Cc Andrew Morton <[email protected]>

---

Dust settled since the last time, maybe we can make URI work?

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 89112a65b831..4a47ec00a09d 100644
@@ -74,6 +74,8 @@ Descriptions of section entries:
 	   These reviewers should be CCed on patches.
 	L: Mailing list that is relevant to this area
 	W: Web-page with status/info
+	B: URI for where to file bugs. A web-page with detailed bug
+	   filing info, a direct bug tracker link, or a mailto: URI.
 	Q: Patchwork web based patch tracking system site
 	T: SCM tree type and location.
 	   Type is one of: git, hg, quilt, stgit, topgit
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/4 MAINTAINERS: add drm and drm/i915 bug filing info

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 4a47ec00a09d..689f7f08a100 100644
@@ -3951,6 +3951,7 @@ DRM DRIVERS
 M:	David Airlie <[email protected]>
 L:	[email protected]
 T:	git git://people.freedesktop.org/~airlied/linux
+B:	https://bugs.freedesktop.org/
 S:	Maintained
 F:	drivers/gpu/drm/
 F:	drivers/gpu/vga/
@@ -4003,6 +4004,7 @@ M:	Jani Nikula <[email protected]>
 L:	[email protected]
 L:	[email protected]
 W:	https://01.org/linuxgraphics/
+B:	https://01.org/linuxgraphics/documentation/how-report-bugs
 Q:	http://patchwork.freedesktop.org/project/intel-gfx/
 T:	git git://anongit.freedesktop.org/drm-intel
 S:	Supported
Signature · 6 lines
2.1.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw

PATCH 3/4 MAINTAINERS: Add "C:" for URI for chat where developers hang out

In reply to Jani Nikula

Make it easier to find the developer chat for the subsystem or driver.

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 689f7f08a100..53df9ccc5573 100644
@@ -76,6 +76,8 @@ Descriptions of section entries:
 	W: Web-page with status/info
 	B: URI for where to file bugs. A web-page with detailed bug
 	   filing info, a direct bug tracker link, or a mailto: URI.
+	C: URI for chat protocol, server and channel where developers
+	   usually hang out, for example irc://server/channel.
 	Q: Patchwork web based patch tracking system site
 	T: SCM tree type and location.
 	   Type is one of: git, hg, quilt, stgit, topgit
Signature · 6 lines
2.1.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw

PATCH 4/4 MAINTAINERS: add drm and drm/i915 irc channels

In reply to Jani Nikula
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 53df9ccc5573..a6bde481170c 100644
@@ -3954,6 +3954,7 @@ M:	David Airlie <[email protected]>
 L:	[email protected]
 T:	git git://people.freedesktop.org/~airlied/linux
 B:	https://bugs.freedesktop.org/
+C:	irc://chat.freenode.net/dri-devel
 S:	Maintained
 F:	drivers/gpu/drm/
 F:	drivers/gpu/vga/
@@ -4007,6 +4008,7 @@ L:	[email protected]
 L:	[email protected]
 W:	https://01.org/linuxgraphics/
 B:	https://01.org/linuxgraphics/documentation/how-report-bugs
+C:	irc://chat.freenode.net/intel-gfx
 Q:	http://patchwork.freedesktop.org/project/intel-gfx/
 T:	git git://anongit.freedesktop.org/drm-intel
 S:	Supported
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

✗ Fi.CI.BAT: warning for series starting with [1/4] MAINTAINERS: Add "B:" for URI where to file bugs

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: series starting with [1/4] MAINTAINERS: Add "B:" for URI where to file bugs
URL : https://patchwork.freedesktop.org/series/14106/
State : warning

== Summary ==

Series 14106v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14106/revisions/1/mbox/

Test drv_module_reload_basic:

                pass       -> DMESG-WARN (fi-skl-6770hq)
                pass       -> DMESG-WARN (fi-skl-6700hq)
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (fi-skl-6700hq)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (fi-skl-6700hq)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:1   skip:60 
fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:221  dwarn:1   dfail:0   fail:0   skip:24 
fi-skl-6770hq    total:246  pass:231  dwarn:1   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36 
fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_2776/

908632bd31141332e8fabea8b452c27c122da6a6 drm-intel-nightly: 2016y-10m-20d-12h-00m-29s UTC integration manifest a717ceb MAINTAINERS: add drm and drm/i915 irc channels
96f4724 MAINTAINERS: Add "C:" for URI for chat where developers hang out
557b2fb MAINTAINERS: add drm and drm/i915 bug filing info
c550701 MAINTAINERS: Add "B:" for URI where to file bugs

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to Jani Nikula
Quoted 5 lines · Jani Nikula

Different subsystems and drivers have different preferences for where to file bugs and what information to include. Add "B:" entry for specifying the URI for the bug tracker directly, a web page for detailed info on filing bugs, or a mailto: URI.

Quoted 8 lines
Cc Daniel Vetter <[email protected]>
Cc Joe Perches <[email protected]>
Cc Andrew Morton <[email protected]>

---

Dust settled since the last time, maybe we can make URI work?

fwiw I want this, I think documenting bugzilla and irc channels (for subsystems and drivers using them) will help a lot to make (sub)communities of the kernel more approachable. On the entire series:

Quoted 20 lines
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 89112a65b831..4a47ec00a09d 100644
@@ -74,6 +74,8 @@ Descriptions of section entries:
 	   These reviewers should be CCed on patches.
 	L: Mailing list that is relevant to this area
 	W: Web-page with status/info
+	B: URI for where to file bugs. A web-page with detailed bug
+	   filing info, a direct bug tracker link, or a mailto: URI.
 	Q: Patchwork web based patch tracking system site
 	T: SCM tree type and location.
 	   Type is one of: git, hg, quilt, stgit, topgit
Signature · 1 line
2.1.4
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Reviewed-by on v1 1/4
#6 lore raw
In reply to Jani Nikula
Quoted 9 lines · Jani Nikula

Different subsystems and drivers have different preferences for where to file bugs and what information to include. Add "B:" entry for specifying the URI for the bug tracker directly, a web page for detailed info on filing bugs, or a mailto: URI.

Cc Daniel Vetter <[email protected]>
Cc Joe Perches <[email protected]>
Cc Andrew Morton <[email protected]>

Both new fields seem like a very, very good idea to me. It'll definitely save me a bit of googling and wiki-searching on the rare occasion I venture outside powerpc...

For the whole series:

Signature · 2 lines
Andrew Donnellan              OzLabs, ADL Canberra
[email protected]  IBM Australia Limited
maintainer
#7 lore raw

RFC PATCH 1/1 get_maintainer: Look for arbitrary letter prefixes in sections

In reply to Jani Nikula

Jani Nikula proposes patches to add a few new letter prefixes for "B:" bug reporting and "C:" maintainer chatting to the various sections of MAINTAINERS.

Add a generic mechanism to get_maintainer.pl to find sections that have any combination of "[A-Z]" letter prefix types in a section.

---
 scripts/get_maintainer.pl | 12 +++++++++---

 1 file changed, 9 insertions(+), 3 deletions(-)
scripts/get_maintainer.pl +0 -0
index aed4511f0304..633f2dd3de27 100755
@@ -49,6 +49,7 @@ my $scm = 0;

 my $web = 0;
 my $subsystem = 0;
 my $status = 0;
+my $letters = "";
 my $keywords = 1;
 my $sections = 0;
 my $file_emails = 0;
@@ -241,6 +242,7 @@ if (!GetOptions(
  'status!' => \$status,
  'scm!' => \$scm,
  'web!' => \$web,
+ 'letters=s' => \$letters,
  'pattern-depth=i' => \$pattern_depth, 'k|keywords!' => \$keywords,
  'sections!' => \$sections,
@@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", "); $output_rolestats = 1 if ($interactive);
 $output_roles = 1 if ($output_rolestats);

-if ($sections) {
+if ($sections || $letters ne "") {
+    $sections = 1;
     $email = 0;
     $email_list = 0;
     $scm = 0;
@@ -682,8 +685,10 @@ sub get_maintainers {
  $line =~ s/\\\./\./g;        ##Convert \. to .
  $line =~ s/\.\*/\*/g;        ##Convert .* to *
      }
-     $line =~ s/^([A-Z]):/$1:\t/g;
-     print("$line\n");
+     my $count = $line =~ s/^([A-Z]):/$1:\t/g;
+     if ($letters eq "" || (!$count || $letters =~ /$1/i)) {
+ print("$line\n");
+     }
  }
  print("\n");
      }
@@ -814,6 +819,7 @@ Other options:
   --pattern-depth => Number of pattern directory traversals (default: 0 (all)) --keywords => scan patch for keywords (default: $keywords) --sections => print all of the subsystem sections with pattern matches +  --letters => print all matching 'letter' types from all matching sections --mailmap => use .mailmap file (default: $email_use_mailmap) --version => show version
   --help => show this help information
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

Quoted 8 lines · Joe Perches

Jani Nikula proposes patches to add a few new letter prefixes for "B:" bug reporting and "C:" maintainer chatting to the various sections of MAINTAINERS.

Add a generic mechanism to get_maintainer.pl to find sections that have any combination of "[A-Z]" letter prefix types in a section.

This patch made it into linux-next (ie, next-20161028).

scripts/get_maintainer.pl

Quoted 10 lines
scripts/get_maintainer.pl +0 -0
@@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
  $output_rolestats = 1 if ($interactive);
  $output_roles = 1 if ($output_rolestats);

scripts/get_maintainer.pl +2 -1
-if ($sections) {
+if ($sections || $letters ne "") {
+    $sections = 1;

This triggers:
    Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at ./scripts/get_maintainer.pl line 277.

Git blame shows:
    git blame -L 277,+1 ./scripts/get_maintainer.pl

    b67071653d3fc (Joe Perches 2016-10-28 13:22:01 +1100 277) <A0><A0><A0><A0>$sections = 1;

(A0 seems to be the no break space. That character was inserted more often further down the patch.)

Anybody else seeing this?

Paul Bolle
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#9 lore raw

Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

Quoted 25 lines · Paul Bolle
Quoted 8 lines · Joe Perches

Jani Nikula proposes patches to add a few new letter prefixes for "B:" bug reporting and "C:" maintainer chatting to the various sections of MAINTAINERS.

Add a generic mechanism to get_maintainer.pl to find sections that have any combination of "[A-Z]" letter prefix types in a section.

This patch made it into linux-next (ie, next-20161028).

scripts/get_maintainer.pl

Quoted 9 lines
scripts/get_maintainer.pl +0 -0
@@ -271,7 +273,8 @@ $output_multiline = 0 if ($output_separator ne ", ");
  $output_rolestats = 1 if ($interactive);
  $output_roles = 1 if ($output_rolestats);

scripts/get_maintainer.pl +2 -1
-if ($sections) {
+if ($sections || $letters ne "") {
+    $sections = 1;

This triggers:
    Unrecognized character \xA0; marked by <-- HERE after <-- HERE near column 1 at ./scripts/get_maintainer.pl line 277.

Quoted 8 lines

Git blame shows:
    git blame -L 277,+1 ./scripts/get_maintainer.pl

    b67071653d3fc (Joe Perches 2016-10-28 13:22:01 +1100 277) <A0><A0><A0><A0>$sections = 1;

(A0 seems to be the no break space. That character was inserted more often further down the patch.)

Anybody else seeing this?

Yes, it's been reported and should be fixed in -mm. The fix should show up in -next in a little bit.

For now, try:

$ sed -i -e 's/\xA0/ /g' scripts/get_maintainer.pl

cheers, Joe

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw

Re: [RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

Quoted 2 lines · Joe Perches

Yes, it's been reported and should be fixed in -mm. The fix should show up in -next in a little bit.

Great.

Quoted 2 lines

For now, try:

$ sed -i -e 's/\xA0/ /g' scripts/get_maintainer.pl

Thanks,

Paul Bolle