Patch "scsi: arcmsr: Buffer overflow in arcmsr_iop_message_xfer()" has been added to the 4.7-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
scsi: arcmsr: Buffer overflow in arcmsr_iop_message_xfer()
to the 4.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-arcmsr-buffer-overflow-in-arcmsr_iop_message_xfer.patch
and it can be found in the queue-4.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7bc2b55a5c030685b399bb65b6baa9ccc3d1f167Mon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Thu, 15 Sep 2016 16:44:56 +0300
Subject: scsi: arcmsr: Buffer overflow in arcmsr_iop_message_xfer()
From: Dan Carpenter <[email protected]>
commit 7bc2b55a5c030685b399bb65b6baa9ccc3d1f167 upstream.
We need to put an upper bound on "user_len" so the memcpy() doesn't overflow.
--- drivers/scsi/arcmsr/arcmsr_hba.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/scsi/arcmsr/arcmsr_hba.c +7 -1
@@ -2388,7 +2388,8 @@ static int arcmsr_iop_message_xfer(struc }case ARCMSR_MESSAGE_WRITE_WQBUFFER : {unsigned char *ver_addr; -int32_t user_len, cnt2end; +uint32_t user_len; +int32_t cnt2end;uint8_t *pQbuffer, *ptmpuserbuffer; ver_addr =kmalloc (ARCMSR_API_DATA_BUFLEN ,GFP_ATOMIC );if (!ver_addr) {
@@ -2397,6 +2398,11 @@ static int arcmsr_iop_message_xfer(struc } ptmpuserbuffer = ver_addr; user_len = pcmdmessagefld->cmdmessage.Length; +if (user_len >ARCMSR_API_DATA_BUFLEN ) { + retvalue =ARCMSR_MESSAGE_FAIL ; +kfree (ver_addr); + goto message_out; + }memcpy (ptmpuserbuffer, pcmdmessagefld->messagedatabuffer, user_len);spin_lock_irqsave (&acb->wqbuffer_lock, flags);
Patches currently in stable-queue which might be from [email protected] are
queue-4.7/scsi-arcmsr-simplify-user_len-checking.patch queue-4.7/scsi-arcmsr-buffer-overflow-in-arcmsr_iop_message_xfer.patch