Skip to contentSkip to conversation

Patch "acpi, nfit: check for the correct event code in notifications" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 20, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

acpi, nfit: check for the correct event code in notifications

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
acpi-nfit-check-for-the-correct-event-code-in-notifications.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c09f12186d6b03b798832d95289af76495990192 Mon Sep 17 00:00:00 2001

From: Vishal Verma <[email protected]>
Date: Fri, 19 Aug 2016 14:40:58 -0600
Subject: acpi, nfit: check for the correct event code in notifications

From: Vishal Verma <[email protected]>

commit c09f12186d6b03b798832d95289af76495990192 upstream.

Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added support for _FIT notifications, but it neglected to verify the notification event code matches the one in the ACPI spec for "NFIT Update". Currently there is only one code in the spec, but once additional codes are added, older kernels (without this fix) will misbehave by assuming all event notifications are for an NFIT Update.

Fixes 209851649dc4 ("acpi: nfit: Add support for hot-add")
Cc Dan Williams <[email protected]>
---
 drivers/acpi/nfit/core.c |    3 +++
 drivers/acpi/nfit/nfit.h |    4 ++++
 2 files changed, 7 insertions(+)
drivers/acpi/nfit/core.c +3 -0
@@ -2689,6 +2689,9 @@ static void acpi_nfit_notify(struct acpi
 
 	dev_dbg(dev, "%s: event: %d\n", __func__, event);
 
+	if (event != NFIT_NOTIFY_UPDATE)
+		return;
+
 	device_lock(dev);
 	if (!dev->driver) {
 		/* dev->driver may be null if we're being removed */
drivers/acpi/nfit/nfit.h +4 -0
@@ -78,6 +78,10 @@ enum {
 	NFIT_ARS_TIMEOUT = 90,
 };
 
+enum nfit_root_notifiers {
+	NFIT_NOTIFY_UPDATE = 0x80,
+};
+
 struct nfit_spa {
 	struct list_head list;
 	struct nd_region *nd_region;

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/acpi-nfit-check-for-the-correct-event-code-in-notifications.patch