Skip to contentSkip to conversation

drm/i915: Rotated view does not need a fence

PATCH Superseded Tvrtko Ursulin 5 participants 18 messages Oct 25, 2016 – Oct 26, 2016

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/2 drm/i915: Rotated view does not need a fence

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem_gtt.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_gtt.h +2 -1
index c241d8143255..c79d7ab75003 100644
@@ -251,7 +251,8 @@ static inline bool i915_vma_is_ggtt(const struct i915_vma *vma)
 
 static inline bool i915_vma_is_map_and_fenceable(const struct i915_vma *vma)
 {
-	return vma->flags & I915_VMA_CAN_FENCE;
+	return vma->flags & I915_VMA_CAN_FENCE &&
+	       vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED;
 }
 
 static inline bool i915_vma_is_closed(const struct i915_vma *vma)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#1 lore raw

PATCH 2/2 drm/i915: Remove two invalid warns

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -3
index 0e26ee96856e..96f48d2c971c 100644
@@ -3595,8 +3595,6 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,
 
 	vma->display_alignment = max_t(u64, vma->display_alignment, alignment);
 
-	WARN_ON(obj->pin_display > i915_vma_pin_count(vma));
-
 	i915_gem_object_flush_cpu_write_domain(obj);
 
 	old_write_domain = obj->base.write_domain;
@@ -3633,7 +3631,6 @@ i915_gem_object_unpin_from_display_plane(struct i915_vma *vma)
 		list_move_tail(&vma->vm_link, &vma->vm->inactive_list);
 
 	i915_vma_unpin(vma);
-	WARN_ON(vma->obj->pin_display > i915_vma_pin_count(vma));
 }
 
 /**
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH 2/2] drm/i915: Remove two invalid warns

Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect.

But each of those vma are pinned, as many times as they are used by display. This explanation doesn't hold.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Re: [PATCH 2/2] drm/i915: Remove two invalid warns

Quoted 9 lines · Chris Wilson
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect.

But each of those vma are pinned, as many times as they are used by display. This explanation doesn't hold.

We can have a normal and a rotated vma, each pinned once, object pinned therefore pinned to display twice.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [PATCH 2/2] drm/i915: Remove two invalid warns

Quoted 9 lines · Tvrtko Ursulin
Quoted 7 lines · Chris Wilson
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect.

Quoted 5 lines
Quoted 2 lines

But each of those vma are pinned, as many times as they are used by display. This explanation doesn't hold.

We can have a normal and a rotated vma, each pinned once, object pinned therefore pinned to display twice.

P.S. I need a fixes tag for this as well. Looking for a suitable candidate in the VMA rewrite series.. suggestions welcome. :)

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by
#5 lore raw

Re: [PATCH 2/2] drm/i915: Remove two invalid warns

In reply to Tvrtko Ursulin
Quoted 9 lines · Tvrtko Ursulin
Quoted 7 lines · Chris Wilson
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect.

Quoted 5 lines
Quoted 2 lines

But each of those vma are pinned, as many times as they are used by display. This explanation doesn't hold.

We can have a normal and a rotated vma, each pinned once, object pinned therefore pinned to display twice.

Oh, vma_pin_count not obj_pin_count. Bleh. Is the warn useful to keep, and so we need to iterate over all vma? Probably not. Especially as we then start asking questions like, should we track pin_display on the vma as well for better accuracy in their assertion

s/their single dislay related/the current/

Ok, I don't have a great idea for replacing it with some other early warning signal. With the slight tweak to the changelog,

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#6 lore raw

PATCH v2 2/2 drm/i915: Remove two invalid warns

From: Tvrtko Ursulin <[email protected]>

Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than the current VMA is incorrect.

v2: Commit message update. (Chris Wilson)

Fixes 058d88c4330f ("drm/i915: Track pinned VMA")
Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Cc Ville Syrjälä <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -3
index eb524bdf0c35..87018df94d68 100644
@@ -3595,8 +3595,6 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,
 
 	vma->display_alignment = max_t(u64, vma->display_alignment, alignment);
 
-	WARN_ON(obj->pin_display > i915_vma_pin_count(vma));
-
 	i915_gem_object_flush_cpu_write_domain(obj);
 
 	old_write_domain = obj->base.write_domain;
@@ -3633,7 +3631,6 @@ i915_gem_object_unpin_from_display_plane(struct i915_vma *vma)
 		list_move_tail(&vma->vm_link, &vma->vm->inactive_list);
 
 	i915_vma_unpin(vma);
-	WARN_ON(vma->obj->pin_display > i915_vma_pin_count(vma));
 }
 
 /**
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw
In reply to Tvrtko Ursulin
Quoted 5 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

See __i915_vma_set_map_and_fenceable. Stop the bit at source. And include the above line as a comment.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author maintainer
#8 lore raw

PATCH v2 1/2 drm/i915: Rotated view does not need a fence

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

v2: Move code to __i915_vma_set_map_and_fenceable. (Chris Wilson)

Fixes 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA")
Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +6 -1
index 9361c7b54a7f..eb524bdf0c35 100644
@@ -3790,7 +3790,12 @@ void __i915_vma_set_map_and_fenceable(struct i915_vma *vma)
 	mappable = (vma->node.start + fence_size <=
 		    dev_priv->ggtt.mappable_end);
 
-	if (mappable && fenceable)
+	/*
+	 * Explicitly disable for rotated VMA since the display does not
+	 * need the fence and the VMA is not accessible to other users.
+	 */
+	if (mappable && fenceable &&
+	    vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED)
 		vma->flags |= I915_VMA_CAN_FENCE;
 	else
 		vma->flags &= ~I915_VMA_CAN_FENCE;
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 1/2
#9 lore raw
Quoted 24 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

v2: Move code to __i915_vma_set_map_and_fenceable. (Chris Wilson)

Fixes 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA")
Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.c +0 -0
index 9361c7b54a7f..eb524bdf0c35 100644
@@ -3790,7 +3790,12 @@ void __i915_vma_set_map_and_fenceable(struct i915_vma *vma)
 	mappable = (vma->node.start + fence_size <=
 		    dev_priv->ggtt.mappable_end);
 

drivers/gpu/drm/i915/i915_gem.c void __i915_vma_set_map_and_fenceable(struct i915_vma *vma) · line 3801

Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +6 -1
-	if (mappable && fenceable)
+	/*
+	 * Explicitly disable for rotated VMA since the display does not
+	 * need the fence and the VMA is not accessible to other users.
+	 */
+	if (mappable && fenceable &&
+	    vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED)
 		vma->flags |= I915_VMA_CAN_FENCE;
 	else
 		vma->flags &= ~I915_VMA_CAN_FENCE;

Penciled i915_vma_is_rotated() onto the todo list.

-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#10 lore raw
In reply to Tvrtko Ursulin
Quoted 9 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>

Broken by 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA") ?

Quoted 25 lines
---
 drivers/gpu/drm/i915/i915_gem_gtt.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_gtt.h +2 -1
index c241d8143255..c79d7ab75003 100644
@@ -251,7 +251,8 @@ static inline bool i915_vma_is_ggtt(const struct i915_vma *vma)
 
 static inline bool i915_vma_is_map_and_fenceable(const struct i915_vma *vma)
 {
-	return vma->flags & I915_VMA_CAN_FENCE;
+	return vma->flags & I915_VMA_CAN_FENCE &&
+	       vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED;
 }
 
 static inline bool i915_vma_is_closed(const struct i915_vma *vma)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw
Quoted 5 lines · Ville Syrjälä
Quoted 4 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Quoted 8 lines
Quoted 5 lines

Display does not need it and no one can access it.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>

Broken by 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA") ?

Have a bug link? :)

There shouldn't be any fail other than reserving a fence, right? -Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#12 lore raw
Quoted 12 lines · Chris Wilson
Quoted 11 lines · Ville Syrjälä
Quoted 9 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Display does not need it and no one can access it.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>
Quoted 6 lines
Quoted 2 lines

Broken by 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA") ?

Have a bug link? :)

There shouldn't be any fail other than reserving a fence, right?

I suppose not. But doesn't hurt to toss in a Fixes tag anyway.

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#13 lore raw
In reply to Ville Syrjälä
Quoted 5 lines · Ville Syrjälä
Quoted 4 lines · Tvrtko Ursulin

From: Tvrtko Ursulin <[email protected]>

We do not need to set up a fence for the rotated view.

Quoted 8 lines
Quoted 5 lines

Display does not need it and no one can access it.

Cc Chris Wilson <[email protected]>
Cc Joonas Lahtinen <[email protected]>

Broken by 05a20d098db1 ("drm/i915: Move map-and-fenceable tracking to the VMA") ?

Wasn't sure if this is considered a breakage. Will add when you made the effort to dig out the commit, thanks!

Regards,

Tvrtko

Quoted 18 lines
Quoted 18 lines
---
 drivers/gpu/drm/i915/i915_gem_gtt.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem_gtt.h +2 -1
index c241d8143255..c79d7ab75003 100644
@@ -251,7 +251,8 @@ static inline bool i915_vma_is_ggtt(const struct i915_vma *vma)
 
 static inline bool i915_vma_is_map_and_fenceable(const struct i915_vma *vma)
 {
-	return vma->flags & I915_VMA_CAN_FENCE;
+	return vma->flags & I915_VMA_CAN_FENCE &&
+	       vma->ggtt_view.type != I915_GGTT_VIEW_ROTATED;
 }
 
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/i915/i915_gem_gtt.h +0 -1
 static inline bool i915_vma_is_closed(const struct i915_vma *vma)
--

2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Rotated view does not need a fence

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Rotated view does not need a fence
URL : https://patchwork.freedesktop.org/series/14340/
State : warning

== Summary ==

Series 14340v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14340/revisions/1/mbox/

Test drv_module_reload_basic:

                dmesg-warn -> PASS       (fi-skl-6770hq)
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (fi-skl-6770hq)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                fail       -> PASS       (fi-skl-6770hq)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-ilk-650)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23 
fi-ilk-650       total:246  pass:184  dwarn:1   dfail:0   fail:0   skip:61 
fi-ivb-3520m     total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26 
fi-ivb-3770      total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:219  dwarn:4   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 
fi-snb-2600      total:246  pass:208  dwarn:0   dfail:0   fail:0   skip:38 

3ce99d02d8f2b7d1414d20d5972f8e277b33693e drm-intel-nightly: 2016y-10m-25d-13h-55m-46s UTC integration manifest 36e261e drm/i915: Remove two invalid warns
ddb7358 drm/i915: Rotated view does not need a fence

Full results at https://intel-gfx-ci.01.org/CI/Patchwork_2811/

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2811/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)
URL : https://patchwork.freedesktop.org/series/14340/
State : failure

== Summary ==

Series 14340v3 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14340/revisions/3/mbox/

Test drv_module_reload_basic:

                pass       -> SKIP       (fi-skl-6700hq)
Test gem_exec_suspend:
        Subgroup basic-s3:
                dmesg-warn -> PASS       (fi-skl-6700hq)
Test gem_ringfill:
        Subgroup basic-default-hang:
                pass       -> TIMEOUT    (fi-ivb-3520m)
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                dmesg-warn -> PASS       (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-skl-6700hq)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (fi-skl-6700hq)
Test prime_self_import:
        Subgroup basic-with_one_bo:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-with_one_bo_two_files:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-with_two_bos:
                pass       -> INCOMPLETE (fi-ivb-3520m)
Test prime_vgem:
        Subgroup basic-busy-default:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-fence-flip:
                skip       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-fence-mmap:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-fence-read:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-fence-wait-default:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-gtt:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-read:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-sync-default:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-wait-default:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup basic-write:
                pass       -> INCOMPLETE (fi-ivb-3520m)
Test vgem_basic:
        Subgroup create:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup debugfs:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup dmabuf-export:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup dmabuf-fence:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup dmabuf-fence-before:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup dmabuf-mmap:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup mmap:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup second-client:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup sysfs:
                pass       -> INCOMPLETE (fi-ivb-3520m)
        Subgroup unload:
                pass       -> INCOMPLETE (fi-ivb-3520m)
fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23 
fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:0   skip:61 
fi-ivb-3520m     total:246  pass:197  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 
fi-snb-2600      total:246  pass:208  dwarn:0   dfail:0   fail:0   skip:38 

9e8e859eec7e29c4ef33413560819617a7f9f6bf drm-intel-nightly: 2016y-10m-25d-16h-30m-11s UTC integration manifest b116793 drm/i915: Remove two invalid warns
acd3753 drm/i915: Rotated view does not need a fence

Full results at https://intel-gfx-ci.01.org/CI/Patchwork_2815/

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2815/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)
URL : https://patchwork.freedesktop.org/series/14340/
State : success

== Summary ==

Series 14340v3 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14340/revisions/3/mbox/

fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23 
fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:0   skip:61 
fi-ivb-3520m     total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26 
fi-ivb-3770      total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 
fi-snb-2600      total:246  pass:208  dwarn:0   dfail:0   fail:0   skip:38 

f746a2112fbb563743acc132304075706551d123 drm-intel-nightly: 2016y-10m-25d-20h-02m-34s UTC integration manifest 8bf8257 drm/i915: Remove two invalid warns
c81be94 drm/i915: Rotated view does not need a fence

Full results at https://intel-gfx-ci.01.org/CI/Patchwork_2821/

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2821/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

Re: ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)

Quoted 29 lines · Patchwork

== Series Details ==

Series: series starting with [v2,1/2] drm/i915: Rotated view does not need a fence (rev3)
URL : https://patchwork.freedesktop.org/series/14340/
State : success

== Summary ==

Series 14340v3 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/14340/revisions/3/mbox/

fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22
fi-hsw-4770r     total:246  pass:223  dwarn:0   dfail:0   fail:0   skip:23
fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:0   skip:61
fi-ivb-3520m     total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26
fi-ivb-3770      total:246  pass:220  dwarn:0   dfail:0   fail:0   skip:26
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hq    total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23
fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23
fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14
fi-snb-2520m     total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37
fi-snb-2600      total:246  pass:208  dwarn:0   dfail:0   fail:0   skip:38
Quoted 3 lines

f746a2112fbb563743acc132304075706551d123 drm-intel-nightly: 2016y-10m-25d-20h-02m-34s UTC integration manifest 8bf8257 drm/i915: Remove two invalid warns
c81be94 drm/i915: Rotated view does not need a fence

Sweet success. :) Pushed to dinq, thanks for the review!

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx