Skip to contentSkip to conversation

Patch "ALSA: hda - Fix a failure of micmute led when having multi adcs" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 26, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: hda - Fix a failure of micmute led when having multi adcs

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-fix-a-failure-of-micmute-led-when-having-multi-adcs.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4875a5f7218068cdeea5f998330dfa3d118b2fea Mon Sep 17 00:00:00 2001

From: Hui Wang <[email protected]>
Date: Tue, 11 Oct 2016 10:48:58 +0800
Subject: ALSA: hda - Fix a failure of micmute led when having multi adcs

From: Hui Wang <[email protected]>

commit 4875a5f7218068cdeea5f998330dfa3d118b2fea upstream.

On a Dell laptop, there is no global adcs for all input devices, so the input devices use the different adc, as a result, dyn_adc_switch is set to true.

In this situation, it is safe to control the micmute led according to user's choice of muting/unmuting the current input device, since only current input device path is active, while other input device paths are inactive and powered down.

Fixes 00ef99408b6c ('ALSA: hda - add mic mute led hook for dell machines')
---
 sound/pci/hda/dell_wmi_helper.c |    2 +-
 sound/pci/hda/thinkpad_helper.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/dell_wmi_helper.c +1 -1
@@ -49,7 +49,7 @@ static void alc_fixup_dell_wmi(struct hd
 		removefunc = true;
 		if (dell_led_set_func(DELL_LED_MICMUTE, false) >= 0) {
 			dell_led_value = 0;
-			if (spec->gen.num_adc_nids > 1)
+			if (spec->gen.num_adc_nids > 1 && !spec->gen.dyn_adc_switch)
 				codec_dbg(codec, "Skipping micmute LED control due to several ADCs");
 			else {
 				dell_old_cap_hook = spec->gen.cap_sync_hook;
sound/pci/hda/thinkpad_helper.c +1 -1
@@ -75,7 +75,7 @@ static void hda_fixup_thinkpad_acpi(stru
 			removefunc = false;
 		}
 		if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) {
-			if (spec->num_adc_nids > 1)
+			if (spec->num_adc_nids > 1 && !spec->dyn_adc_switch)
 				codec_dbg(codec,
 					  "Skipping micmute LED control due to several ADCs");
 			else {

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-hda-fix-a-failure-of-micmute-led-when-having-multi-adcs.patch