Skip to contentSkip to conversation

Patch "NFSv4: Don't report revoked delegations as valid in nfs_have_delegation()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 26, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

NFSv4: Don't report revoked delegations as valid in nfs_have_delegation()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfsv4-don-t-report-revoked-delegations-as-valid-in-nfs_have_delegation.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b3f9e7239074613aa6bdafa4caf7c104fe1e7276 Mon Sep 17 00:00:00 2001

From: Trond Myklebust <[email protected]>
Date: Thu, 22 Sep 2016 13:38:53 -0400
Subject: NFSv4: Don't report revoked delegations as valid in nfs_have_delegation()

From: Trond Myklebust <[email protected]>

commit b3f9e7239074613aa6bdafa4caf7c104fe1e7276 upstream.

If the delegation is revoked, then it can't be used for caching.

Fixes 869f9dfa4d6d ("NFSv4: Fix races between nfs_remove_bad_delegation()...")
---
 fs/nfs/delegation.c |    1 +
 1 file changed, 1 insertion(+)
fs/nfs/delegation.c +1 -0
@@ -51,6 +51,7 @@ nfs4_do_check_delegation(struct inode *i
 	rcu_read_lock();
 	delegation = rcu_dereference(NFS_I(inode)->delegation);
 	if (delegation != NULL && (delegation->type & flags) == flags &&
+	    !test_bit(NFS_DELEGATION_REVOKED, &delegation->flags) &&
 	    !test_bit(NFS_DELEGATION_RETURNING, &delegation->flags)) {
 		if (mark)
 			nfs_mark_delegation_referenced(delegation);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/nfsv4-don-t-report-revoked-delegations-as-valid-in-nfs_have_delegation.patch queue-4.4/nfsv4.2-fix-a-reference-leak-in-nfs42_proc_layoutstats_generic.patch queue-4.4/nfsv4-open-state-recovery-must-account-for-file-permission-changes.patch queue-4.4/nfsv4-nfs4_copy_delegation_stateid-must-fail-if-the-delegation-is-invalid.patch