Skip to contentSkip to conversation

Patch "mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 26, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mmc-rtsx_usb_sdmmc-avoid-keeping-the-device-runtime-resumed-when-unused.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 31cf742f515c275d22843c4c756e048d2b6d716c Mon Sep 17 00:00:00 2001

From: Ulf Hansson <[email protected]>
Date: Tue, 27 Sep 2016 08:44:33 -0700
Subject: mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused

From: Ulf Hansson <[email protected]>

commit 31cf742f515c275d22843c4c756e048d2b6d716c upstream.

The rtsx_usb_sdmmc driver may bail out in its ->set_ios() callback when no SD card is inserted. This is wrong, as it could cause the device to remain runtime resumed when it's unused. Fix this behaviour.

---
 drivers/mmc/host/rtsx_usb_sdmmc.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/mmc/host/rtsx_usb_sdmmc.c +0 -5
@@ -1138,11 +1138,6 @@ static void sdmmc_set_ios(struct mmc_hos
 	dev_dbg(sdmmc_dev(host), "%s\n", __func__);
 	mutex_lock(&ucr->dev_mutex);
 
-	if (rtsx_usb_card_exclusive_check(ucr, RTSX_USB_SD_CARD)) {
-		mutex_unlock(&ucr->dev_mutex);
-		return;
-	}
-
 	sd_set_power_mode(host, ios->power_mode);
 	sd_set_bus_width(host, ios->bus_width);
 	sd_set_timing(host, ios->timing, &host->ddr_mode);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/memstick-rtsx_usb_ms-manage-runtime-pm-when-accessing-the-device.patch queue-4.8/mmc-sdhci-cast-unsigned-int-to-unsigned-long-long-to-avoid-unexpeted-error.patch queue-4.8/mmc-core-annotate-cmd_hdr-as-__le32.patch queue-4.8/mmc-block-don-t-use-cmd23-with-very-old-mmc-cards.patch queue-4.8/mmc-core-switch-to-1v8-or-1v2-for-hs400es-mode.patch queue-4.8/memstick-rtsx_usb_ms-runtime-resume-the-device-when-polling-for-cards.patch queue-4.8/mmc-rtsx_usb_sdmmc-avoid-keeping-the-device-runtime-resumed-when-unused.patch queue-4.8/mmc-rtsx_usb_sdmmc-handle-runtime-pm-while-changing-the-led.patch