usb: musb: remove duplicated actions
Subsystems (2)
PATCH v3 1/1 usb: musb: remove duplicated actions
Removing unnecessary duplicated actions that we've got while merging:19915e623458 ("Merge 4.1-rc7 into usb-next")
Signed-off-by Kirill Esipov <[email protected]>
--- drivers/usb/musb/musb_core.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/usb/musb/musb_core.c +0 -6
@@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)if (musb->ops->ep_select) musb->io.ep_select = musb->ops->ep_select; -/* At least tusb6010 has its own offsets */ -if (musb->ops->ep_offset) - musb->io.ep_offset = musb->ops->ep_offset; -if (musb->ops->ep_select) - musb->io.ep_select = musb->ops->ep_select; -if (musb->ops->fifo_mode) fifo_mode = musb->ops->fifo_mode;else
Signature · 1 line
2.7.4
Bin Liu
maintainerHi,
Quoted 13 lines · Kirill Esipov
Removing unnecessary duplicated actions that we've got while merging:
19915e623458("Merge 4.1-rc7 into usb-next")Signed-off-by Kirill Esipov <[email protected]>--- drivers/usb/musb/musb_core.c | 6 ------ 1 file changed, 6 deletions(-)drivers/usb/musb/musb_core.c +0
-0
drivers/usb/musb/musb_core.c musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl) · line 2123
Quoted 4 lines
drivers/usb/musb/musb_core.c +0
-1@@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)if (musb->ops->ep_select) musb->io.ep_select = musb->ops->ep_select; -/* At least tusb6010 has its own offsets */
I prefer to keep this comment and drop the first one "/* And override them with platform specific ops if specified. */" as it doesn't provide any value.
Quoted 10 lines
drivers/usb/musb/musb_core.c +0
-5-if (musb->ops->ep_offset) - musb->io.ep_offset = musb->ops->ep_offset; -if (musb->ops->ep_select) - musb->io.ep_select = musb->ops->ep_select; -if (musb->ops->fifo_mode) fifo_mode = musb->ops->fifo_mode;else Signature · 1 line
2.7.4
Thanks,
-Bin.