Skip to contentSkip to conversation

xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64

PATCH In review [email protected] 3 participants 4 messages Oct 28, 2016 – Oct 31, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xterm: use ${libdir} to avoid installed-vs-shipped error on ppc64

From: Ting Liu <[email protected]>

xterm installs files into PREFIX/lib/X11/app-defaults by default.
This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
/usr/lib
/usr/lib/X11
/usr/lib/X11/app-defaults
/usr/lib/X11/app-defaults/UXTerm /usr/lib/X11/app-defaults/KOI8RXTerm-color /usr/lib/X11/app-defaults/XTerm-color /usr/lib/X11/app-defaults/UXTerm-color /usr/lib/X11/app-defaults/KOI8RXTerm
/usr/lib/X11/app-defaults/XTerm

Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.

---
 meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-graphics/xorg-app/xterm_325.bb +1 -0
index e0baf3c..48556c7 100644
@@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft fontconfig fre
 
 EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
                  --x-libraries=${STAGING_LIBDIR} \
+                 --with-app-defaults=${libdir}/X11/app-defaults \
                  FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config \
                  --disable-imake \
                  --disable-rpath-hack \
Signature · 1 line
2.7.4
#1 lore raw
Quoted 30 lines · On Fri, Oct 28, 2016 at 3:07 AM, <[email protected]> wrote:

xterm installs files into PREFIX/lib/X11/app-defaults by default. This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
/usr/lib
/usr/lib/X11
/usr/lib/X11/app-defaults
/usr/lib/X11/app-defaults/UXTerm /usr/lib/X11/app-defaults/KOI8RXTerm-color /usr/lib/X11/app-defaults/XTerm-color /usr/lib/X11/app-defaults/UXTerm-color /usr/lib/X11/app-defaults/KOI8RXTerm /usr/lib/X11/app-defaults/XTerm

Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.

---
 meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-graphics/xorg-app/xterm_325.bb +0 -0
index e0baf3c..48556c7 100644
@@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft

fontconfig fre

Quoted 8 lines
 EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
                  --x-libraries=${STAGING_LIBDIR} \
+                 --with-app-defaults=${libdir}/X11/app-defaults \
                  FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
\
                  --disable-imake \
                  --disable-rpath-hack \

Are you sure this is correct? I highly doubt those files are actually multilib specific. Would it not be better to just package these files in their current location?

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 32 lines · Christopher Larson
Quoted 30 lines · On Fri, Oct 28, 2016 at 3:07 AM, <[email protected]> wrote:

xterm installs files into PREFIX/lib/X11/app-defaults by default. This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
/usr/lib
/usr/lib/X11
/usr/lib/X11/app-defaults
/usr/lib/X11/app-defaults/UXTerm /usr/lib/X11/app-defaults/KOI8RXTerm-color /usr/lib/X11/app-defaults/XTerm-color /usr/lib/X11/app-defaults/UXTerm-color /usr/lib/X11/app-defaults/KOI8RXTerm /usr/lib/X11/app-defaults/XTerm

Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.

---
 meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-graphics/xorg-app/xterm_325.bb +0 -0
index e0baf3c..48556c7 100644
@@ -14,6 +14,7 @@ PACKAGECONFIG[xft] = "--enable-freetype,--disable-freetype,libxft

fontconfig fre

Quoted 12 lines
Quoted 8 lines
 EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
                  --x-libraries=${STAGING_LIBDIR} \
+                 --with-app-defaults=${libdir}/X11/app-defaults \
                  FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config
\
                  --disable-imake \
                  --disable-rpath-hack \

Are you sure this is correct? I highly doubt those files are actually multilib specific. Would it not be better to just package these files in their current location?

Or use datadir

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
author
#3 lore raw
In reply to Christopher Larson
Quoted 48 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Christopher Larson
Sent: Friday, October 28, 2016 11:07 PM
To: Openembedded Discussion <openembedded- [email protected]>
Cc: Otavio Salvador <[email protected]>
Subject: Re: [oe] [meta-oe][PATCH] xterm: use ${libdir} to avoid installed-vs- shipped error on ppc64

Quoted 35 lines · On Fri, Oct 28, 2016 at 3:07 AM, <[email protected]> wrote:

xterm installs files into PREFIX/lib/X11/app-defaults by default. This leads to QA issue on ppc64 which defines libdir as /usr/lib64:
ERROR: QA Issue: xterm: Files/directories were installed but not shipped in any package:
/usr/lib
/usr/lib/X11
/usr/lib/X11/app-defaults /usr/lib/X11/app-defaults/UXTerm /usr/lib/X11/app-defaults/KOI8RXTerm-color /usr/lib/X11/app-defaults/XTerm-color /usr/lib/X11/app-defaults/UXTerm-color /usr/lib/X11/app-defaults/KOI8RXTerm /usr/lib/X11/app-defaults/XTerm

Fix it by passing --with-app-defaults=${libdir}/X11/app-defaults to configure.

---
 meta-oe/recipes-graphics/xorg-app/xterm_325.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-graphics/xorg-app/xterm_325.bb +0 -0
index e0baf3c..48556c7 100644
@@ -14,6 +14,7 @@ PACKAGECONFIG[xft] =

"--enable-freetype,--disable-freetype,libxft
fontconfig fre

 EXTRA_OECONF = " --x-includes=${STAGING_INCDIR} \
                  --x-libraries=${STAGING_LIBDIR} \

+ --with-app-defaults=${libdir}/X11/app-defaults \

Quoted 9 lines
Quoted 5 lines

FREETYPE_CONFIG=${STAGING_BINDIR_CROSS}/freetype-config

\
                  --disable-imake \
                  --disable-rpath-hack \

Are you sure this is correct? I highly doubt those files are actually multilib specific. Would it not be better to just package these files in their current location?

[Liu Ting-B28495] I have sent another patch to package these files in their current location. Thanks.

Quoted 10 lines

--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
--
_______________________________________________
Openembedded-devel mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel