Skip to contentSkip to conversation

Patch "spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 28, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
spi-spi-fsl-dspi-drop-extra-spi_master_put-in-device-remove-function.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6999aeabbb703a81a204cb6f9f8f151759a99ac4 Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Sat, 20 Aug 2016 15:25:32 +0000
Subject: spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function

From: Wei Yongjun <[email protected]>

commit 6999aeabbb703a81a204cb6f9f8f151759a99ac4 upstream.

The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is unnecessary and results in an access to free memory. Drop it.

Fixes 9298bc727385 ("spi: spi-fsl-dspi: Remove spi-bitbang")
---
 drivers/spi/spi-fsl-dspi.c |    1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-fsl-dspi.c +0 -1
@@ -753,7 +753,6 @@ static int dspi_remove(struct platform_d
 	/* Disconnect from the SPI framework */
 	clk_disable_unprepare(dspi->clk);
 	spi_unregister_master(dspi->master);
-	spi_master_put(dspi->master);
 
 	return 0;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/spi-spi-fsl-dspi-drop-extra-spi_master_put-in-device-remove-function.patch