Patch "hwrng: omap - Only fail if pm_runtime_get_sync returns < 0" has been added to the 4.8-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
hwrng: omap - Only fail if pm_runtime_get_sync returns < 0
to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hwrng-omap-only-fail-if-pm_runtime_get_sync-returns-0.patch
and it can be found in the queue-4.8 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ad8529fde9e3601180a839867a8ab041109aebb5Mon Sep 17 00:00:00 2001
From: Dave Gerlach <[email protected]>
Date: Tue, 20 Sep 2016 10:25:40 -0500
Subject: hwrng: omap - Only fail if pm_runtime_get_sync returns < 0
From: Dave Gerlach <[email protected]>
commit ad8529fde9e3601180a839867a8ab041109aebb5 upstream.
Currently omap-rng checks the return value of pm_runtime_get_sync and reports failure if anything is returned, however it should be checking if ret < 0 as pm_runtime_get_sync return 0 on success but also can return 1 if the device was already active which is not a failure case. Only values < 0 are actual failures.
--- drivers/char/hw_random/omap-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/char/hw_random/omap-rng.c +2 -2
@@ -385,7 +385,7 @@ static int omap_rng_probe(struct platforpm_runtime_enable (&pdev->dev); ret =pm_runtime_get_sync (&pdev->dev); -if (ret) { +if (ret <0 ) {dev_err (&pdev->dev,"Failed to runtime_get device: %d\n" , ret);pm_runtime_put_noidle (&pdev->dev); goto err_ioremap;
@@ -443,7 +443,7 @@ static int __maybe_unused omap_rng_resumint ret; ret =pm_runtime_get_sync (dev); -if (ret) { +if (ret <0 ) {dev_err (dev,"Failed to runtime_get device: %d\n" , ret);pm_runtime_put_noidle (dev);return ret;
Patches currently in stable-queue which might be from [email protected] are
queue-4.8/hwrng-omap-only-fail-if-pm_runtime_get_sync-returns-0.patch