Skip to contentSkip to conversation

Patch "staging: android ion/hisi: fix dependencies" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Oct 28, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

staging: android ion/hisi: fix dependencies

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
staging-android-ion-hisi-fix-dependencies.patch
and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4a236d01b5e0d7e6f4ee9e6c4056fce10b38e8ad Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Thu, 15 Sep 2016 17:57:40 +0200
Subject: staging: android ion/hisi: fix dependencies

From: Arnd Bergmann <[email protected]>

commit 4a236d01b5e0d7e6f4ee9e6c4056fce10b38e8ad upstream.

The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present:

drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to ion_destroy_platform_data' drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to ion_parse_dt' hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to ion_destroy_platform_data'

This selects the symbol when needed.

Fixes 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
---
 drivers/staging/android/ion/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/Kconfig +1 -0
@@ -36,6 +36,7 @@ config ION_TEGRA
 config ION_HISI
 	tristate "Ion for Hisilicon"
 	depends on ARCH_HISI && ION
+	select ION_OF
 	help
 	  Choose this option if you wish to use ion on Hisilicon Platform.
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/dmaengine-ipu-remove-bogus-no_irq-reference.patch queue-4.8/staging-android-ion-hisi-fix-dependencies.patch