Skip to contentSkip to conversation

qt4-embedded: Default to build tslib when touchscreen is defined

PATCH In review Mike Looijmans 4 participants 8 messages Oct 31, 2016 – Nov 3, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt4-embedded: Default to build tslib when touchscreen is defined

When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e
will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that
library is not being built by default, resulting in an error like:
opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.

To prevent that from happening, add "tslib" to the default PACKAGECONFIG when touchscreen is defined.

---
Applies to both morty and master branches.

 recipes-qt4/qt4/qt4-embedded.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt4/qt4/qt4-embedded.inc +1 -1
index 1122080..9c2d9da 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is
 SECTION = "libs"
 HOMEPAGE = "http://qt-project.org/"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES", "touchscreen", "tslib", "",d)}'
 PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"
 
 QT4EDEPENDS = ""
Signature · 1 line
1.9.1
#1 lore raw

Hi

I sent a similar patch:
https://lists.yoctoproject.org/pipermail/yocto/2016-October/032661.html

Both fix the build error with the HEAD of meta-qt4.

Question is if "touchscreen" in MACHINE_FEATURES should build for tslib by default.
If yes, your patch is needed.

However the error will pop up again if someone chooses to set PACKAGECONFIG to not include tslib.
That would be handled by the patch above, so applying both patches would fix the problem and default to having tslib support.

Max

P.S.What is the 'correct' mailinglist for meta-qt4?

2016-10-31 8:29 GMT+01:00 Mike Looijmans <[email protected]>:

Quoted 36 lines

When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e
will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that
library is not being built by default, resulting in an error like:
opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.

To prevent that from happening, add "tslib" to the default PACKAGECONFIG when touchscreen is defined.

---
Applies to both morty and master branches.

 recipes-qt4/qt4/qt4-embedded.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt4/qt4/qt4-embedded.inc +1 -2
index 1122080..9c2d9da 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is
 SECTION = "libs"
 HOMEPAGE = "http://qt-project.org/"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES", "touchscreen", "tslib", "",d)}'
 PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"
 
 QT4EDEPENDS = ""
--

1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Having some more experience with it, my suggestion would be to REVERT c4671873af5ab6c7d15ca397538f154c11c3486e "qt4-embedded.inc: provide PACKAGECONFIG for tslib".

The problem with using MACHINE_FEATURES for building the qt4 libs is that the qt4 package becomes machine-specific, and if you're buiding for multiple machines (with and without touchscreen), there'll be lots of "setstate" activity to take care of that.

Building tslib hardly hurts, it's a small dependency, while building qt4 takes something like 5 minutes on our big ass i7 build server. And deciding not to install the plugin is quite efficient.

At the very least, "tslib" should be in the default config.

I don't know the rationale behind commit c4671873af5, if reducing compile time was the incentive, it's not really paying off. Time would be better spent avoiding building "perl" or "bash"...

Quoted 48 lines · Max Krummenacher

Hi

I sent a similar patch:
https://lists.yoctoproject.org/pipermail/yocto/2016-October/032661.html

Both fix the build error with the HEAD of meta-qt4.

Question is if "touchscreen" in MACHINE_FEATURES should build for tslib by default.
If yes, your patch is needed.

However the error will pop up again if someone chooses to set PACKAGECONFIG to not include tslib.
That would be handled by the patch above, so applying both patches would fix the problem and default to having tslib support.

Max

P.S.What is the 'correct' mailinglist for meta-qt4?

2016-10-31 8:29 GMT+01:00 Mike Looijmans <[email protected]>:

Quoted 27 lines

When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e
will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that
library is not being built by default, resulting in an error like:
opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.

To prevent that from happening, add "tslib" to the default PACKAGECONFIG when touchscreen is defined.

---
Applies to both morty and master branches.

 recipes-qt4/qt4/qt4-embedded.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt4/qt4/qt4-embedded.inc +1 -1
index 1122080..9c2d9da 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is
 SECTION = "libs"
 HOMEPAGE = "http://qt-project.org/"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES", "touchscreen", "tslib", "",d)}'
 PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"
 
Quoted 6 lines
Quoted 6 lines
recipes-qt4/qt4/qt4-embedded.inc +0 -1
 QT4EDEPENDS = ""
--

1.9.1

--

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

_______________________________________________

Quoted 3 lines
Quoted 3 lines

Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

I have merged both of the patches to master and taken the liberty of merging them to morty as well, just so it isn't horribly broken. I appreciate it's still slightly broken from some perspectives.

I suspect the reason this was done was to remove the tslib dependency by default so that meta-oe wasn't pulled in. Whether or not that's a good idea is another question, personally I wouldn't have done it this way. It seems to me if you have a touchscreen arguably you need tslib here.

Maxin / Alex, can you please determine what the right course of action is going forward and take care of it?

Thanks,
Paul

Quoted 101 lines · On Tue, 01 Nov 2016 16:02:06 Mike Looijmans wrote:

Having some more experience with it, my suggestion would be to REVERT c4671873af5ab6c7d15ca397538f154c11c3486e "qt4-embedded.inc: provide PACKAGECONFIG for tslib".

The problem with using MACHINE_FEATURES for building the qt4 libs is that the qt4 package becomes machine-specific, and if you're buiding for multiple machines (with and without touchscreen), there'll be lots of "setstate" activity to take care of that.

Building tslib hardly hurts, it's a small dependency, while building qt4 takes something like 5 minutes on our big ass i7 build server. And deciding not to install the plugin is quite efficient.

At the very least, "tslib" should be in the default config.

I don't know the rationale behind commit c4671873af5, if reducing compile time was the incentive, it's not really paying off. Time would be better spent avoiding building "perl" or "bash"...

Quoted 51 lines · Max Krummenacher

Hi

I sent a similar patch:
https://lists.yoctoproject.org/pipermail/yocto/2016-October/032661.html

Both fix the build error with the HEAD of meta-qt4.

Question is if "touchscreen" in MACHINE_FEATURES should build for tslib by default.
If yes, your patch is needed.

However the error will pop up again if someone chooses to set PACKAGECONFIG to not include tslib.
That would be handled by the patch above, so applying both patches would fix the problem and default to having tslib support.

Max

P.S.What is the 'correct' mailinglist for meta-qt4?

2016-10-31 8:29 GMT+01:00 Mike Looijmans <[email protected]>:

Quoted 30 lines

When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that library is not being built by default, resulting in an error like:
opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.

To prevent that from happening, add "tslib" to the default PACKAGECONFIG when touchscreen is defined.

---
Applies to both morty and master branches.

 recipes-qt4/qt4/qt4-embedded.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/recipes-qt4/qt4/qt4-embedded.inc index 1122080..9c2d9da 100644

recipes-qt4/qt4/qt4-embedded.inc +0 -0
@@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform

application framework -- this is>>
SECTION = "libs"
HOMEPAGE = "http://qt-project.org/"

recipes-qt4/qt4/qt4-embedded.inc +1 -1
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES",

"touchscreen", "tslib", "",d)}'>>
PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"

Quoted 6 lines
Quoted 6 lines

QT4EDEPENDS = ""

--
1.9.1

--

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

_______________________________________________

Quoted 3 lines
Quoted 3 lines

Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#4 lore raw

BTW, earlier there was a question about what the correct mailing list for meta-qt4 is. According to the README it's [email protected]. I've updated the layer index page [1] accordingly (it didn't list any earlier).

Cheers,
Paul

[1] https://layers.openembedded.org/layerindex/branch/master/layer/meta-qt4/

Quoted 120 lines · On Wed, 02 Nov 2016 16:01:50 Paul Eggleton wrote:

I have merged both of the patches to master and taken the liberty of merging them to morty as well, just so it isn't horribly broken. I appreciate it's still slightly broken from some perspectives.

I suspect the reason this was done was to remove the tslib dependency by default so that meta-oe wasn't pulled in. Whether or not that's a good idea is another question, personally I wouldn't have done it this way. It seems to me if you have a touchscreen arguably you need tslib here.

Maxin / Alex, can you please determine what the right course of action is going forward and take care of it?

Thanks,
Paul

Quoted 104 lines · On Tue, 01 Nov 2016 16:02:06 Mike Looijmans wrote:

Having some more experience with it, my suggestion would be to REVERT c4671873af5ab6c7d15ca397538f154c11c3486e "qt4-embedded.inc: provide PACKAGECONFIG for tslib".

The problem with using MACHINE_FEATURES for building the qt4 libs is that the qt4 package becomes machine-specific, and if you're buiding for multiple machines (with and without touchscreen), there'll be lots of "setstate" activity to take care of that.

Building tslib hardly hurts, it's a small dependency, while building qt4 takes something like 5 minutes on our big ass i7 build server. And deciding
not to install the plugin is quite efficient.

At the very least, "tslib" should be in the default config.

I don't know the rationale behind commit c4671873af5, if reducing compile time was the incentive, it's not really paying off. Time would be better spent avoiding building "perl" or "bash"...

Quoted 51 lines · Max Krummenacher

Hi

I sent a similar patch:
https://lists.yoctoproject.org/pipermail/yocto/2016-October/032661.html

Both fix the build error with the HEAD of meta-qt4.

Question is if "touchscreen" in MACHINE_FEATURES should build for tslib by default.
If yes, your patch is needed.

However the error will pop up again if someone chooses to set PACKAGECONFIG to not include tslib.
That would be handled by the patch above, so applying both patches would fix the problem and default to having tslib support.

Max

P.S.What is the 'correct' mailinglist for meta-qt4?

2016-10-31 8:29 GMT+01:00 Mike Looijmans <[email protected]>:

Quoted 30 lines

When "touchscreen" is in the MACHINE_FEATURES, packagegroup-core-qt4e will RDEPEND on qt4-embedded-plugin-mousedriver-tslib, but that library is not being built by default, resulting in an error like:
opkg_prepare_url_for_install: Couldn't find anything to satisfy 'qt4-embedded-plugin-mousedriver-tslib'.

To prevent that from happening, add "tslib" to the default PACKAGECONFIG when touchscreen is defined.

---
Applies to both morty and master branches.

 recipes-qt4/qt4/qt4-embedded.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/recipes-qt4/qt4/qt4-embedded.inc index 1122080..9c2d9da 100644

recipes-qt4/qt4/qt4-embedded.inc +0 -0
@@ -3,7 +3,7 @@ DESCRIPTION = "Qt is a versatile cross-platform

application framework -- this is>>

SECTION = "libs"
HOMEPAGE = "http://qt-project.org/"

recipes-qt4/qt4/qt4-embedded.inc +1 -1
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= '${@bb.utils.contains("MACHINE_FEATURES",

"touchscreen", "tslib", "",d)}'>>

Quoted 8 lines
Quoted 8 lines

PACKAGECONFIG[tslib] = " -plugin-mouse-tslib, ,tslib"

QT4EDEPENDS = ""

--
1.9.1

--

Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: [email protected]
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

_______________________________________________

Quoted 3 lines
Quoted 3 lines

Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#5 lore raw
In reply to Paul Eggleton
Quoted 5 lines · Paul Eggleton

I have merged both of the patches to master and taken the liberty of merging
them to morty as well, just so it isn't horribly broken. I appreciate it's still slightly broken from some perspectives.

Quoted 7 lines

I suspect the reason this was done was to remove the tslib dependency by default so that meta-oe wasn't pulled in. Whether or not that's a good idea is
another question, personally I wouldn't have done it this way. It seems to me
if you have a touchscreen arguably you need tslib here.

AFAIK tslib is only required for some touchscreens, for example the one I have somewhere in the attic works with standard kernel input drivers. The LSB builds on the autobuilder pull in meta-qt4 so doesn't this mean that meta-oe is now a build dependency for the AB runs?

Ross

#6 lore raw
Quoted 14 lines · Ross
Quoted 11 lines · Paul Eggleton

I have merged both of the patches to master and taken the liberty of merging
them to morty as well, just so it isn't horribly broken. I appreciate it's still slightly broken from some perspectives.

I suspect the reason this was done was to remove the tslib dependency by default so that meta-oe wasn't pulled in. Whether or not that's a good idea is
another question, personally I wouldn't have done it this way. It seems to me
if you have a touchscreen arguably you need tslib here.

Quoted 4 lines

AFAIK tslib is only required for some touchscreens, for example the one I have somewhere in the attic works with standard kernel input drivers. The LSB builds on the autobuilder pull in meta-qt4 so doesn't this mean that meta-oe is now a build dependency for the AB runs?

Only if they have "touchscreen" in IMAGE_FEATURES - do any of the machines we build for on the autobuilder do that?

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#7 lore raw
Quoted 4 lines · Paul Eggleton

Only if they have "touchscreen" in IMAGE_FEATURES - do any of the machines we
build for on the autobuilder do that?

I thought the qemu machines did, but I was wrong.

Thanks,
Ross